On Tue, 21 Jan 2025 13:20:46 -0800 (PST)
Jeremy Drake wrote:
> dscho hooked me up with a workflow to run Git for Windows' test suite on
> an msys2-runtime pull request's CI artifacts. With this patch and the
> three you pushed (reverting the v2 patch we had applied already, and
> applying the two f
On Tue, 21 Jan 2025 10:00:23 -0800 (PST)
Jeremy Drake wrote:
> Not important, but
>
> On Tue, 21 Jan 2025, Takashi Yano wrote:
>
> > + if (!_my_tls.locals.cw_timer_inuse)
> > + _my_tls.locals.cw_timer_inuse = true;
>
> Couldn't you leave the if out?
That's right, I'm aware of that, but I
dscho hooked me up with a workflow to run Git for Windows' test suite on
an msys2-runtime pull request's CI artifacts. With this patch and the
three you pushed (reverting the v2 patch we had applied already, and
applying the two from the cygwin-3_5-branch), the test suite no longer
hangs.
On Mon,
Not important, but
On Tue, 21 Jan 2025, Takashi Yano wrote:
> + if (!_my_tls.locals.cw_timer_inuse)
> + _my_tls.locals.cw_timer_inuse = true;
Couldn't you leave the if out?
Oh, btw.
On Jan 21 17:28, Corinna Vinschen wrote:
> On Jan 21 23:25, Takashi Yano wrote:
> > On Tue, 21 Jan 2025 14:45:10 +0100
> > Corinna Vinschen wrote:
> > > This bugs me a bit. While your solution nicely wraps the entire
> > > timer problem into cygwait(), the downside is that each invocatio
On Jan 21 23:25, Takashi Yano wrote:
> On Tue, 21 Jan 2025 14:45:10 +0100
> Corinna Vinschen wrote:
> > This bugs me a bit. While your solution nicely wraps the entire
> > timer problem into cygwait(), the downside is that each invocation
> > of cygwait() creates its own timer. Theoretically, give
On Tue, 21 Jan 2025 14:45:10 +0100
Corinna Vinschen wrote:
> Hi Takashi,
>
> There's a minor style thingy and one question...
>
> On Jan 21 12:15, Takashi Yano wrote:
> > +++ b/winsup/cygwin/sigproc.cc
> > @@ -742,6 +742,12 @@ sig_send (_pinfo *p, siginfo_t& si, _cygtls *tls)
> >memcpy (p
Hi Mark,
On Jan 19 21:59, Mark Geisert wrote:
> Validate the fd returned by cygheap_getfd operating on given mqd.
> A release note is provided for 3.5.6.
>
> Reported-by: Christian Franke
> Addresses: https://cygwin.com/pipermail/cygwin/2025-January/257090.html
> Signed-off-by: Mark Geisert
> F
Hi Takashi,
There's a minor style thingy and one question...
On Jan 21 12:15, Takashi Yano wrote:
> +++ b/winsup/cygwin/sigproc.cc
> @@ -742,6 +742,12 @@ sig_send (_pinfo *p, siginfo_t& si, _cygtls *tls)
>memcpy (p, si._si_commune._si_str, n); p += n;
> }
>
> + unsigned cw_mask;
>
