Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Jeremy Drake via Cygwin-patches
On Sun, 19 Jan 2025, Takashi Yano wrote: > Thanks for pointing out this. You are right if othre threads may > set current_sig to non-zero value. Current cygwin sets current_sig > to non-zero only in > _cygtls::interrupt_setup() > and > _cygtls::handle_SIGCONT() > both are called from sigpacket::pr

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 17:06:50 -0800 (PST) Jeremy Drake wrote: > On Sat, 18 Jan 2025, Takashi Yano wrote: > > > While debugging this problem, I encountered another hang issue, > > which is fixed by: > > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch > > I'm concerned about this pat

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Jeremy Drake via Cygwin-patches
On Sat, 18 Jan 2025, Takashi Yano wrote: > While debugging this problem, I encountered another hang issue, > which is fixed by: > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch I'm concerned about this patch. There's a window where current_sig could be changed after exiting the

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Fri, 17 Jan 2025 18:52:41 +0900 Takashi Yano wrote: > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > Jeremy Drake wrote: > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > Corinna Vinschen wrote: > > > > Does this patch fix Bruno's bash issue as well? > > >

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 10:58:34 -0800 (PST) Jeremy Drake wrote: > On Sat, 18 Jan 2025, Takashi Yano wrote: > > > Jeremy, > > could you please apply the attached patches: > > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch > > 0003-Cygwin-signal-Do-not-handle-signal-when-__SIGFLUSHFA.p

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Jeremy Drake via Cygwin-patches
On Sat, 18 Jan 2025, Takashi Yano wrote: > Jeremy, > could you please apply the attached patches: > 0001-Cygwin-signal-Avoid-frequent-tls-lock-unlock-for-SIG.patch > 0003-Cygwin-signal-Do-not-handle-signal-when-__SIGFLUSHFA.patch > against cygwin-3_5-branch and test if these fix the issue? I open

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Sat, 18 Jan 2025 20:41:37 +0900 Takashi Yano wrote: > On Fri, 17 Jan 2025 18:52:41 +0900 > Takashi Yano wrote: > > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > > Jeremy Drake wrote: > > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > > Corinna Vinsch

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-18 Thread Takashi Yano
On Fri, 17 Jan 2025 18:52:41 +0900 Takashi Yano wrote: > On Wed, 8 Jan 2025 18:05:53 -0800 (PST) > Jeremy Drake wrote: > > On Thu, 9 Jan 2025, Takashi Yano wrote: > > > > > On Wed, 8 Jan 2025 16:48:41 +0100 > > > Corinna Vinschen wrote: > > > > Does this patch fix Bruno's bash issue as well? > > >