Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-08 Thread Jeremy Drake via Cygwin-patches
On Thu, 9 Jan 2025, Takashi Yano wrote: > On Wed, 8 Jan 2025 16:48:41 +0100 > Corinna Vinschen wrote: > > Does this patch fix Bruno's bash issue as well? > > I'm not sure because it is not reproducible as he said. > I also could not reproduce that. > > However, at least this fixes the issue that J

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-08 Thread Takashi Yano
On Wed, 8 Jan 2025 16:48:41 +0100 Corinna Vinschen wrote: > On Dec 23 10:33, Takashi Yano wrote: > > After the commit d243e51ef1d3, zsh sometimes hangs at startup. This > > occurs because SIGCHLD, which should trigger sigsuspend(), is handled > > in cygwait() that is used to wait for a wakeup event

[PATCH 5/5] Cygwin: remove winsup/cygwin/local_includes/mmap_helper.h

2025-01-08 Thread Ken Brown
Patch attached.From 8c3a918c346a9ae97e219679d780c9b716588fc8 Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Sun, 29 Dec 2024 18:47:54 -0500 Subject: [PATCH 5/5] Cygwin: remove winsup/cygwin/local_includes/mmap_helper.h None of its macros and functions are used anymore. Signed-off-by: Ken Brown

[PATCH 4/5] Cygwin: mmap_list::try_map: simplify

2025-01-08 Thread Ken Brown
Patch attached.From c01da9db1e76869621b63f8075505fa49acf0d56 Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Sun, 29 Dec 2024 18:20:07 -0500 Subject: [PATCH 4/5] Cygwin: mmap_list::try_map: simplify Save the result of mmap_record::find_unused pages, and then pass that result to the appropriate ve

[PATCH 2/5] Cygwin: mmap: remove is_mmapped_region()

2025-01-08 Thread Ken Brown
Patch attached.From d3c62d48f87044d7607d81559c58ae06df5839af Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Fri, 20 Dec 2024 12:17:34 -0500 Subject: [PATCH 2/5] Cygwin: mmap: remove is_mmapped_region() The last use was removed in commit 29a126322783 ("Simplify stack allocation code in child afte

[PATCH 3/5] Cygwin: mmap: remove __PROT_FILLER and the associated methods

2025-01-08 Thread Ken Brown
Patch attached.From 87e07edb7c53f425c86579d013d29efd3f905203 Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Fri, 20 Dec 2024 13:11:22 -0500 Subject: [PATCH 3/5] Cygwin: mmap: remove __PROT_FILLER and the associated methods This is left over from 32 bit Cygwin and is no longer used. Signed-off-

[PATCH 1/5] Cygwin: mmap: refactor mmap_record::match

2025-01-08 Thread Ken Brown
Patch attached.From 4387a73d5593ddad4cf7592865b5b257e6a9d6de Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Fri, 27 Dec 2024 15:30:12 -0500 Subject: [PATCH 1/5] Cygwin: mmap: refactor mmap_record::match Slightly simplify the code and add comments to explain what the function does. Add a new ref

Re: [PATCH 0/5] Some mmap code cleanup

2025-01-08 Thread Ken Brown
On 1/8/2025 10:34 AM, Corinna Vinschen wrote: Hi Ken, any chance you could resend the patches as a patch series with a single patch per email? It would be nice if we could review and, if necessary, discuss the patches independently of each other. git send-email usually does that for you. Sorry

Re: [RFC] POSIX Issue 8 2024 SUS V5 Cygwin Doc Changes

2025-01-08 Thread Corinna Vinschen
On Jan 8 16:45, Corinna Vinschen wrote: > - Deprectaed SUS functions from older SUS issues should be added to the ^ moved > std-deprec section and its title updated accor

Re: [PATCH v4] Cygwin: winsup/doc/posix.xml: update to SUS V5, POSIX 2024, TOG Base Specs Issue 8, ISO/IEC DIS 9945

2025-01-08 Thread Corinna Vinschen
On Jan 7 16:58, Brian Inglis wrote: > Update anchor id and description to current version, year, issue, etc. > Move new POSIX entries in other sections to the SUS/POSIX section. > Add new POSIX entries from din entries. > Add new entries with interfaces available in headers and packages. > Add tho

Re: [PATCH v2] Cygwin: signal: Do not handle signal when __SIGFLUSHFAST is sent

2025-01-08 Thread Corinna Vinschen
On Dec 23 10:33, Takashi Yano wrote: > After the commit d243e51ef1d3, zsh sometimes hangs at startup. This > occurs because SIGCHLD, which should trigger sigsuspend(), is handled > in cygwait() that is used to wait for a wakeup event in sig_send(), > even when __SIGFLUSHFAST is sent. Despite __SIGF

Re: [RFC] POSIX Issue 8 2024 SUS V5 Cygwin Doc Changes

2025-01-08 Thread Corinna Vinschen
Hi Brian, Hayy New Year! On Jan 5 13:43, Brian Inglis wrote: > - Move or copy the "new" entries to the SUS/POSIX section, update the > description to SUS V5 POSIX Issue 8 2024 and IEEE and ISO/IEC (almost) > Standards, update the id "std-susv4" and any refs. > Should we copy and keep original en

Re: [PATCH 0/5] Some mmap code cleanup

2025-01-08 Thread Corinna Vinschen
Hi Ken, any chance you could resend the patches as a patch series with a single patch per email? It would be nice if we could review and, if necessary, discuss the patches independently of each other. git send-email usually does that for you. Thanks, Corinna On Dec 30 14:44, Ken Brown wrote:

Re: [PATCH] Cygwin: mmap: allow remapping part of an existing anonymous, mapping

2025-01-08 Thread Corinna Vinschen
On Jan 7 21:27, Ken Brown wrote: > On 1/7/2025 3:18 PM, Corinna Vinschen wrote: > > - mmap_record::prot flag, should be an array of protection bits per page > >(POSIX page i e., 64K, not Windows page). > > Question: Since it only takes 3 bits to store all possible protections, do > you think

Re: [PATCH] Cygwin: access: Fix X_OK behaviour for administrator

2025-01-08 Thread Corinna Vinschen
Hi Takashi, On Jan 8 19:39, Takashi Yano wrote: > On Wed, 8 Jan 2025 06:14:24 +0900 > Takashi Yano wrote: > > Hi Corinna, > > > > On Tue, 7 Jan 2025 17:48:59 +0100 > > Corinna Vinschen wrote: > > > So... given how this is supposed to work, we must not use the > > > FILE_OPEN_FOR_BACKUP_INTENT fl

Re: [PATCH] Cygwin: access: Fix X_OK behaviour for administrator

2025-01-08 Thread Takashi Yano
On Wed, 8 Jan 2025 06:14:24 +0900 Takashi Yano wrote: > Hi Corinna, > > On Tue, 7 Jan 2025 17:48:59 +0100 > Corinna Vinschen wrote: > > Hi Takashi, > > > > Happy New Year! > > > > On Dec 26 21:34, Takashi Yano wrote: > > > @@ -613,6 +613,22 @@ check_file_access (path_conv &pc, int flags, bool >