Re: [PATCH v3] cygthread: suspend thread before terminating.

2024-11-22 Thread Jeremy Drake via Cygwin-patches
On Fri, 22 Nov 2024, Corinna Vinschen wrote: > > wait_thread is happily waiting in ReadFile, while the main thread is > > hanging in ForceCloseHandle1 (close_h, rd_proc_pipe);. > > which is one of the great annoyances of Windows. CloseHandle > on a pipe should never hang, but... well... Yeah

Re: [PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-22 Thread Jeremy Drake via Cygwin-patches
On Fri, 22 Nov 2024, Corinna Vinschen wrote: > On Nov 21 11:42, Jeremy Drake via Cygwin-patches wrote: > > Note the elif defined (__i386__) case won't compile because it references > > the no-longer-present `wow64` value. This was written and tested against > > 3.3.6, and the __i386__ case could

Re: [PATCH v2] Cygwin: Minor updates to load average calculations

2024-11-22 Thread Jon Turney
On 21/11/2024 23:49, Mark Geisert wrote: On 11/21/2024 2:35 AM, Mark Geisert hallucinated:   I used SysInternals tool [I don't remember] to explore the namespace. Turns out it was actually MSDN sample code under the topic "Browsing Performan

Re: [PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-22 Thread Jon Turney
On 21/11/2024 19:42, Jeremy Drake via Cygwin-patches wrote: @@ -282,4 +284,30 @@ wincapc::init () __small_sprintf (osnam, "NT-%d.%d", version.dwMajorVersion, version.dwMinorVersion); + + if (!IsWow64Process2 (GetCurrentProcess (), &emul_mach, &host_mach)) +{ + /

Re: [PATCH v2] Cygwin: sigtimedwait: Fix segfault when timeout is used

2024-11-22 Thread Christian Franke
Corinna Vinschen wrote: On Nov 20 22:00, Takashi Yano wrote: On Tue, 19 Nov 2024 11:51:17 +0100 Corinna Vinschen wrote: Maybe we can utilize WaitOnAddress, kind of like this? sigwait_common, just the fallthrough snippet: + /* sigpacket::process() already started. + Go thr

Re: [PATCH 1/2] Cygwin: cache IsWow64Process2 host arch in wincap.

2024-11-22 Thread Corinna Vinschen
On Nov 21 11:42, Jeremy Drake via Cygwin-patches wrote: > This was already used in the FAST_CWD check, and could be used in a > couple other places. > > I found the "emulated"/process value returned from the function largely > useless, so I did not cache it. It is useless because, as the docs say

Re: [PATCH v3] cygthread: suspend thread before terminating.

2024-11-22 Thread Corinna Vinschen
On Nov 21 17:20, Jeremy Drake via Cygwin-patches wrote: > On Wed, 20 Nov 2024, Jeremy Drake via Cygwin-patches wrote: > > > On Wed, 20 Nov 2024, Corinna Vinschen wrote: > > > > > Patch pushed. > > > > Thanks, folks on ARM64 will be very happy to see that deadlock gone. > > MSYS2 already made a rel