Re: [PATCH v3] cygthread: suspend thread before terminating.

2024-11-20 Thread Jeremy Drake via Cygwin-patches
On Wed, 20 Nov 2024, Corinna Vinschen wrote: > Patch pushed. Thanks, folks on ARM64 will be very happy to see that deadlock gone. MSYS2 already made a release based on v2 of the patch, and Git for Windows at least merged that version of the patch too, and is looking forward to making a release wi

Re: [PATCH] Cygwin: SetThreadName: avoid spurious debug message

2024-11-20 Thread Jon Turney
On 20/11/2024 15:33, Corinna Vinschen wrote: On Nov 20 16:26, Corinna Vinschen wrote: From: Corinna Vinschen The following debug message occassionally shows up in strace output: SetThreadName: SetThreadDescription() failed. 1000 The HRESULT of 0x1000 is not an error, rath

Re: [PATCH] Cygwin: SetThreadName: avoid spurious debug message

2024-11-20 Thread Corinna Vinschen
On Nov 20 16:26, Corinna Vinschen wrote: > From: Corinna Vinschen > > The following debug message occassionally shows up in strace output: > > SetThreadName: SetThreadDescription() failed. 1000 > > The HRESULT of 0x1000 is not an error, rather the set bit just > indicates tha

Re: [PATCH v2] Cygwin: sigtimedwait: Fix segfault when timeout is used

2024-11-20 Thread Corinna Vinschen
On Nov 20 22:00, Takashi Yano wrote: > On Tue, 19 Nov 2024 11:51:17 +0100 > Corinna Vinschen wrote: > > Maybe we can utilize WaitOnAddress, kind of like this? > > > > sigwait_common, just the fallthrough snippet: > > > > + /* sigpacket::process() already started. > > + Go throu

[PATCH] Cygwin: SetThreadName: avoid spurious debug message

2024-11-20 Thread Corinna Vinschen
From: Corinna Vinschen The following debug message occassionally shows up in strace output: SetThreadName: SetThreadDescription() failed. 1000 The HRESULT of 0x1000 is not an error, rather the set bit just indicates that this HRESULT has been created from an NTSTATUS value.

Re: [PATCH 1/2] Cygwin: lockf: Fix access violation in lf_clearlock().

2024-11-20 Thread Corinna Vinschen
On Nov 20 21:52, Takashi Yano wrote: > On Tue, 19 Nov 2024 22:18:11 +0100 > Corinna Vinschen wrote: > > On Nov 19 19:13, Takashi Yano wrote: > > > On Tue, 19 Nov 2024 10:49:39 +0100 > > > Corinna Vinschen wrote: > > > > > [PATCH v2] Cygwin: flock: Fix overlap handling in lf_setlock() and > > > >

Re: [PATCH 1/2] Cygwin: lockf: Fix access violation in lf_clearlock().

2024-11-20 Thread Takashi Yano
On Tue, 19 Nov 2024 22:18:11 +0100 Corinna Vinschen wrote: > On Nov 19 19:13, Takashi Yano wrote: > > On Tue, 19 Nov 2024 10:49:39 +0100 > > Corinna Vinschen wrote: > > > > [PATCH v2] Cygwin: flock: Fix overlap handling in lf_setlock() and > > > > lf_clearlock() > > > > as well? > > > > > > Give

Re: [PATCH v2] Cygwin: sigtimedwait: Fix segfault when timeout is used

2024-11-20 Thread Takashi Yano
On Tue, 19 Nov 2024 11:51:17 +0100 Corinna Vinschen wrote: > On Nov 19 17:40, Takashi Yano wrote: > > diff --git a/winsup/cygwin/signal.cc b/winsup/cygwin/signal.cc > > index 77152910b..eca536e90 100644 > > --- a/winsup/cygwin/signal.cc > > +++ b/winsup/cygwin/signal.cc > > @@ -618,6 +618,20 @@ sig

Re: [PATCH v3] cygthread: suspend thread before terminating.

2024-11-20 Thread Corinna Vinschen
Hi Jeremy, On Nov 19 13:58, Jeremy Drake via Cygwin-patches wrote: > On Tue, 19 Nov 2024, Corinna Vinschen wrote: > > > On Nov 19 11:06, Jeremy Drake via Cygwin-patches wrote: > > > (I searched for other callers of terminate_thread after this, and the only > > > one left without CancelSynchronous