Re: [PATCH v2] Cygwin: Minor updates to load average calculations

2024-11-18 Thread Jon Turney
On 13/11/2024 06:03, Mark Geisert wrote: Thanks very much for looking into this problem. Sorry about the inordinate time it's take for me to look at this. Commentary wording adjusted to say ProcessorQueueLength counts threads, not processes. Also mention (upcoming) new tool /bin/loadavg. The

Re: [PATCH v2] Cygwin: New tool loadavg to maintain load averages

2024-11-18 Thread Jon Turney
On 13/11/2024 06:21, Mark Geisert wrote: This program provides an up-to-the-moment load average measurement. The user can take 1 sample, or obtain the average of N samples by number or Sorry about the inordinate time it's take for me to look at this. So, this seems like two separate things s

Re: [PATCH v2] cygthread: suspend thread before terminating.

2024-11-18 Thread Jeremy Drake via Cygwin-patches
On Mon, 18 Nov 2024, Corinna Vinschen wrote: > Neat, but if this only affects the ARM64 emulation, shouldn't this only > be called under wincap.cpu_arch() == PROCESSOR_ARCHITECTURE_AMD64? Wouldn't this always be true though? (Except that I backported this to 3.3.6 for i686 support, where I'd hav

Re: [PATCH] Cygwin: sigtimedwait: Fix segfault when timeout is used

2024-11-18 Thread Corinna Vinschen
Hi Takashi, thanks for looking into this problem. On Nov 18 00:48, Takashi Yano wrote: > @@ -640,6 +641,16 @@ sigwait_common (const sigset_t *set, siginfo_t *info, > PLARGE_INTEGER waittime) > } > break; > case WAIT_TIMEOUT: > + _my_tls.lock (); > + if (_my_tl

Re: [PATCH 1/2] Cygwin: lockf: Fix access violation in lf_clearlock().

2024-11-18 Thread Corinna Vinschen
On Nov 15 22:14, Takashi Yano wrote: > The commit ae181b0ff122 has a bug that the pointer is referred bofore > NULL check in the function lf_clearlock(). This patch fixes that. > > Addresses: https://cygwin.com/pipermail/cygwin/2024-November/256750.html > Fixes: ae181b0ff122 ("Cygwin: lockf: Make

Re: [PATCH v2] cygthread: suspend thread before terminating.

2024-11-18 Thread Corinna Vinschen
Hi Jeremy, thanks for this patch, it looks pretty nice. A few minor points... On Nov 14 08:24, Jeremy Drake via Cygwin-patches wrote: > @@ -302,6 +302,20 @@ cygthread::terminate_thread () >if (!inuse) > goto force_notterminated; > > + if (_my_tls._ctinfo != this) > +{ > + CO

Re: [PATCH v2] Cygwin: New tool loadavg to maintain load averages

2024-11-18 Thread Corinna Vinschen
Hi Mark, Not being a bugfix, this patch should go into the main branch and only update release/3.6.0. Thanks, Corinna On Nov 12 22:21, Mark Geisert wrote: > This program provides an up-to-the-moment load average measurement. The > user can take 1 sample, or obtain the average of N samples by n

Re: [PATCH v2] Cygwin: Minor updates to load average calculations

2024-11-18 Thread Corinna Vinschen
Hi Mark, Jon, would you mind to take a look, please? This looks good to me, just one question... On Nov 12 22:03, Mark Geisert wrote: > Commentary wording adjusted to say ProcessorQueueLength counts threads, > not processes. Also mention (upcoming) new tool /bin/loadavg. The > release note f