Re: [PATCH v2] Cygwin: Make safe for c89 compilations

Corinna Vinschen wrote: On Jul 4 16:33, Corinna Vinschen wrote: On Jul 3 17:51, Mark Geisert wrote: Four modifications to include/sys/cpuset.h: * Change C++-style comments to C-style also supported by C++ * Change "inline" to "__inline" on code lines * Add "#include " to make sure __inline is

Re: [PATCH] fchmodat/fstatat: fix regression with empty `pathname`

On Jul 4 17:45, Johannes Schindelin wrote: > Hi Corinna, > > On Mon, 3 Jul 2023, Corinna Vinschen wrote: > > > Hi Johannes, > > > > On Jun 27 22:51, Johannes Schindelin wrote: > > > In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18) > > > the code of `readlinkat()` was adjust

Re: [PATCH] Cygwin: dtable: Delete old kludge code for /dev/tty.

Hi Takashi, On Tue, 4 Jul 2023, Takashi Yano wrote: > On Mon, 3 Jul 2023 12:52:25 +0200 > Corinna Vinschen wrote: > > > > On Jun 27 22:28, Takashi Yano wrote: > > > > > > diff --git a/winsup/cygwin/dtable.cc b/winsup/cygwin/dtable.cc > > > index 18e0f3097..9427e238e 100644 > > > --- a/winsup/cygw

Re: [PATCH] fchmodat/fstatat: fix regression with empty `pathname`

Hi Jeremy, On Wed, 28 Jun 2023, Jeremy Drake wrote: > On Tue, 27 Jun 2023, Johannes Schindelin wrote: > > > In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18) > > the code of `readlinkat()` was adjusted to align the `errno` with Linux' > > behavior. > > > > I noticed this

Re: [PATCH] fchmodat/fstatat: fix regression with empty `pathname`

Hi Corinna, On Mon, 3 Jul 2023, Corinna Vinschen wrote: > Hi Johannes, > > On Jun 27 22:51, Johannes Schindelin wrote: > > In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18) > > the code of `readlinkat()` was adjusted to align the `errno` with Linux' > > behavior. > > > > To a

[PATCH v2] fchmodat/fstatat: fix regression with empty `pathname`

In 4b8222983f (Cygwin: fix errno values set by readlinkat, 2023-04-18) the code of `readlinkat()` was adjusted to align the `errno` with Linux' behavior. To accommodate for that, the `gen_full_path_at()` function was modified, and the caller was adjusted to expect either `ENOENT` or `ENOTDIR` in t

Re: [PATCH v2] Cygwin: Make safe for c89 compilations

On Jul 4 16:33, Corinna Vinschen wrote: > On Jul 3 17:51, Mark Geisert wrote: > > Four modifications to include/sys/cpuset.h: > > * Change C++-style comments to C-style also supported by C++ > > * Change "inline" to "__inline" on code lines > > * Add "#include " to make sure __inline is defined >

Re: [PATCH v2] Cygwin: dtable: Delete old kludge code for /dev/tty.

On Jul 4 19:03, Takashi Yano wrote: > This old kludge code assigns fhandler_console for /dev/tty even > if the CTTY is not a console when stat() has been called. Due to > this, the problem reported in > https://cygwin.com/pipermail/cygwin/2023-June/253888.html > occurs after the commit 3721a756b0d

Re: [PATCH v2] Cygwin: Make safe for c89 compilations

On Jul 3 17:51, Mark Geisert wrote: > Four modifications to include/sys/cpuset.h: > * Change C++-style comments to C-style also supported by C++ > * Change "inline" to "__inline" on code lines > * Add "#include " to make sure __inline is defined > * Don't declare loop variables on for-loop init cl

[PATCH v2] Cygwin: dtable: Delete old kludge code for /dev/tty.

This old kludge code assigns fhandler_console for /dev/tty even if the CTTY is not a console when stat() has been called. Due to this, the problem reported in https://cygwin.com/pipermail/cygwin/2023-June/253888.html occurs after the commit 3721a756b0d8 ("Cygwin: console: Make the console accessibl

Re: [PATCH] Cygwin: dtable: Delete old kludge code for /dev/tty.

Hi Corinna, Thanks for reviewing the patch. On Mon, 3 Jul 2023 12:52:25 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Jun 27 22:28, Takashi Yano wrote: > > This old kludge code assigns fhandler_console for /dev/tty even > > if the CTTY is not a console when stat() has been called. Due to >