Re: [PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable

2023-03-28 Thread Corinna Vinschen
On Mar 28 13:34, Jon Turney wrote: > On 28/03/2023 11:35, Corinna Vinschen wrote: > > Apart from the doc change, the patch is ok now. > > The preceding text says "Four schema are predefined, two schemata are > variable", then we add "env" to both lists? That doesn't make much sense to > me. Surel

Re: [PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable

2023-03-28 Thread Jon Turney
On 28/03/2023 11:35, Corinna Vinschen wrote: Apart from the doc change, the patch is ok now. The preceding text says "Four schema are predefined, two schemata are variable", then we add "env" to both lists? That doesn't make much sense to me. Surely it's just a "predefined schema"? In any c

Re: [PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable

2023-03-28 Thread Corinna Vinschen
Apart from the doc change, the patch is ok now. On Mar 28 10:17, Johannes Schindelin wrote: > diff --git a/winsup/doc/ntsec.xml b/winsup/doc/ntsec.xml > index c6871ecf05..1678ff6575 100644 > --- a/winsup/doc/ntsec.xml > +++ b/winsup/doc/ntsec.xml > @@ -1203,6 +1203,17 @@ schemata are the following

Re: [PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined

2023-03-28 Thread Corinna Vinschen
On Mar 28 10:17, Johannes Schindelin wrote: > In particular when we cannot figure out a uid for the current user, we > should still respect the `db_home: env` setting. Such a situation occurs > for example when the domain returned by `LookupAccountSid()` is not our > machine name and at the same ti

Re: [PATCH v4 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts

2023-03-28 Thread Corinna Vinschen
On Mar 28 10:17, Johannes Schindelin wrote: > We should not blindly set the home directory of the SYSTEM account (or > of Microsoft accounts) to /home/SYSTEM, especially not when that value ^^ That should probably better be , no? > disagrees with what is confi

Re: [PATCH 0/2] Provide virtual /dev/fd and /dev/{stdin, stdout, stderr} symlinks

2023-03-28 Thread Johannes Schindelin
Hi Brian, On Fri, 25 Feb 2022, Brian Inglis wrote: > On 2022-02-21 06:36, Johannes Schindelin wrote: > > These symbolic links are crucial e.g. to support process substitution > > (Bash's > > very nice `<(SOME-COMMAND)` feature). > > > > For various reasons, it is a bit cumbersome (or impossible)

Re: [PATCH 0/2] Provide virtual /dev/fd and /dev/{stdin, stdout, stderr} symlinks

2023-03-28 Thread Johannes Schindelin
Hi Corinna, On Mon, 28 Feb 2022, Corinna Vinschen wrote: > On Feb 28 10:24, Corinna Vinschen wrote: > > On Feb 25 16:46, Johannes Schindelin wrote: > > > On Tue, 22 Feb 2022, Corinna Vinschen wrote: > > > > On Feb 21 14:36, Johannes Schindelin wrote: > > > > > If there is appetite for it, I wonde

Re: [PATCH] Cygwin: Improve FAQ on early breakpoint for ASLR

2023-03-28 Thread Johannes Schindelin
Hi Jon, On Wed, 14 Dec 2022, Jon Turney wrote: > On 11/12/2022 14:45, Johannes Schindelin wrote: > > On December 11, 2022 2:54:02 PM GMT+01:00, Jon Turney > > wrote: > > > On 05/12/2022 15:23, Johannes Schindelin wrote: > > > > On Mon, 28 Nov 2022, Corinna Vinschen wrote: > > > > > On Nov 28 13:

Re: [PATCH v2 1/2] Allow deriving the current user's home directory via the HOME variable

2023-03-28 Thread Johannes Schindelin
Hi Corinna, On Mon, 21 Nov 2022, Corinna Vinschen wrote: > On Nov 18 09:18, Johannes Schindelin wrote: > > Hi Corinna, > > > > On Thu, 10 Nov 2022, Corinna Vinschen wrote: > > > On Nov 10 16:16, Johannes Schindelin wrote: > > > > With this context in mind, I would like to ask to integrate the pat

[PATCH v4 2/3] Respect `db_home` setting even for SYSTEM/Microsoft accounts

2023-03-28 Thread Johannes Schindelin
We should not blindly set the home directory of the SYSTEM account (or of Microsoft accounts) to /home/SYSTEM, especially not when that value disagrees with what is configured via the `db_home` line in the `/etc/nsswitch.conf` file. Signed-off-by: Johannes Schindelin --- winsup/cygwin/uinfo.cc |

[PATCH v4 3/3] Respect `db_home: env` even when no uid can be determined

2023-03-28 Thread Johannes Schindelin
In particular when we cannot figure out a uid for the current user, we should still respect the `db_home: env` setting. Such a situation occurs for example when the domain returned by `LookupAccountSid()` is not our machine name and at the same time our machine is no domain member: In that case, we

[PATCH v4 1/3] Allow deriving the current user's home directory via the HOME variable

2023-03-28 Thread Johannes Schindelin
This patch hails from Git for Windows (where the Cygwin runtime is used in the form of a slightly modified MSYS2 runtime), where it is a well-established technique to let the `$HOME` variable define where the current user's home directory is, falling back to `$HOMEDRIVE$HOMEPATH` and `$USERPROFILE`

[PATCH v4 0/3] Support deriving the current user's home directory via HOME

2023-03-28 Thread Johannes Schindelin
This patch mini-series supports Git for Windows' default strategy to determine the current user's home directory by looking at the environment variable HOME, falling back to HOMEDRIVE and HOMEPATH, and if these variables are also unset, to USERPROFILE. This strategy is a quick method to determine