[PATCH] Cygwin: pty: Fix crash on master close in Windows 7.

2022-03-29 Thread Takashi Yano
- The 4th parameter of WriteFile() cannot be NULL especially in Windows 7 as mentioned in Microsoft documentation. This patch fixes that. Addresses: https://cygwin.com/pipermail/cygwin/2022-March/251162.html --- winsup/cygwin/fhandler_tty.cc | 2 +- winsup/cygwin/release/3.3.5 | 3 +++ 2 fi

[PATCH v5] Cygwin: pipe: Avoid deadlock for non-cygwin writer.

2022-03-29 Thread Takashi Yano
- As mentioned in commit message of the commit b531d6b0, if multiple writers including non-cygwin app exist, the non-cygwin app cannot detect pipe closure on the read side when the pipe is created by system account or the the pipe creator is running as service. This is because query_hdl whi

Re: [PATCH v4] Cygwin: pipe: Avoid deadlock for non-cygwin writer.

2022-03-29 Thread Takashi Yano
On Tue, 29 Mar 2022 08:21:11 -0700 (PDT) Jeremy Drake wrote: > On Tue, 29 Mar 2022, Takashi Yano wrote: > > > diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc > > index fb3d09d84..cd2d3a7ef 100644 > > --- a/winsup/cygwin/spawn.cc > > +++ b/winsup/cygwin/spawn.cc > > @@ -645,8 +646,18

Re: [PATCH v4] Cygwin: pipe: Avoid deadlock for non-cygwin writer.

2022-03-29 Thread Jeremy Drake via Cygwin-patches
On Tue, 29 Mar 2022, Takashi Yano wrote: > diff --git a/winsup/cygwin/fhandler.h b/winsup/cygwin/fhandler.h > index b87160edb..006c7b4bf 100644 > --- a/winsup/cygwin/fhandler.h > +++ b/winsup/cygwin/fhandler.h > @@ -1194,6 +1194,7 @@ private: >HANDLE hdl_cnt_mtx; >HANDLE query_hdl_proc; >

Re: [PATCH v4] Cygwin: pipe: Avoid deadlock for non-cygwin writer.

2022-03-29 Thread Jeremy Drake via Cygwin-patches
On Tue, 29 Mar 2022, Takashi Yano wrote: > diff --git a/winsup/cygwin/spawn.cc b/winsup/cygwin/spawn.cc > index fb3d09d84..cd2d3a7ef 100644 > --- a/winsup/cygwin/spawn.cc > +++ b/winsup/cygwin/spawn.cc > @@ -645,8 +646,18 @@ child_info_spawn::worker (const char *prog_arg, const > char *const *arg

[PATCH v4] Cygwin: pipe: Avoid deadlock for non-cygwin writer.

2022-03-29 Thread Takashi Yano
- As mentioned in commit message of the commit b531d6b0, if multiple writers including non-cygwin app exist, the non-cygwin app cannot detect pipe closure on the read side when the pipe is created by system account or the the pipe creator is running as service. This is because query_hdl whi