Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

Hi Corinna, On Wed, 9 Sep 2020 09:21:23 +0200 Corinna Vinschen wrote: > On Sep 8 17:16, Takashi Yano via Cygwin-patches wrote: > > On Mon, 7 Sep 2020 23:17:36 +0200 (CEST) > > Johannes Schindelin wrote: > > > Hi Takashi, > > > > > > On Sat, 5 Sep 2020, Takashi Yano wrote: > > > > > > > On Fri,

Re: [PATCH v3 0/2] Cygwin: pty: Changes regarding charset conversion.

On Wed, 9 Sep 2020 23:46:04 +0200 Corinna Vinschen wrote: > On Sep 10 00:27, Takashi Yano via Cygwin-patches wrote: > > Takashi Yano (2): > > Cygwin: pty: Revise convert_mb_str() function. > > Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon. > > > > winsup/cygwin/fhandler

Re: [PATCH v3 0/2] Cygwin: pty: Changes regarding charset conversion.

On Sep 10 00:27, Takashi Yano via Cygwin-patches wrote: > Takashi Yano (2): > Cygwin: pty: Revise convert_mb_str() function. > Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon. > > winsup/cygwin/fhandler_tty.cc | 151 +++--- > 1 file changed, 10

[PATCH v3 2/2] Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon.

- If the non-cygwin apps is executed under pseudo console disabled, multibyte input for the apps are garbled. This patch fixes the issue. --- winsup/cygwin/fhandler_tty.cc | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsu

[PATCH v3 1/2] Cygwin: pty: Revise convert_mb_str() function.

- Use tmp_pathbuf instead of HeapAlloc()/HeapFree(). - Remove mb_str_free() function. - Consider the case where the multibyte string stops in the middle of a multibyte char. --- winsup/cygwin/fhandler_tty.cc | 135 ++ 1 file changed, 88 insertions(+), 47 deletions

[PATCH v3 0/2] Cygwin: pty: Changes regarding charset conversion.

Takashi Yano (2): Cygwin: pty: Revise convert_mb_str() function. Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon. winsup/cygwin/fhandler_tty.cc | 151 +++--- 1 file changed, 103 insertions(+), 48 deletions(-) -- 2.28.0

Re: [PATCH v2 1/2] Cygwin: pty: Revise convert_mb_str() function.

On Sep 9 22:40, Takashi Yano via Cygwin-patches wrote: > - Use tmp_pathbuf instead of HeapAlloc()/HeapFree(). > - Remove mb_str_free() function. > - Consider the case where the multibyte string stops in the middle > of a multibyte char. > --- > winsup/cygwin/fhandler_tty.cc | 118 ++

[PATCH v2 0/2] Cygwin: pty: Changes regarding charset conversion.

Takashi Yano (2): Cygwin: pty: Revise convert_mb_str() function. Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon. winsup/cygwin/fhandler_tty.cc | 130 +++--- 1 file changed, 88 insertions(+), 42 deletions(-) -- 2.28.0

[PATCH v2 2/2] Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon.

- If the non-cygwin apps is executed under pseudo console disabled, multibyte input for the apps are garbled. This patch fixes the issue. --- winsup/cygwin/fhandler_tty.cc | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cy

[PATCH v2 1/2] Cygwin: pty: Revise convert_mb_str() function.

- Use tmp_pathbuf instead of HeapAlloc()/HeapFree(). - Remove mb_str_free() function. - Consider the case where the multibyte string stops in the middle of a multibyte char. --- winsup/cygwin/fhandler_tty.cc | 118 ++ 1 file changed, 77 insertions(+), 41 deletions

Re: [PATCH 1/2] Cygwin: pty: Revise convert_mb_str() function.

On Wed, 9 Sep 2020 17:07:20 +0900 Takashi Yano wrote: > + /* Max bytes in multibyte char is 6. */ > + for (mblen = 1; mblen <= 6; mblen ++) Sorry, I misunderstood that the max utf-8 char length is 6. Actually, it is 4, therefore mbstate_t can be used. I will submit v2 patch. --

[PATCH 1/2] Cygwin: pty: Revise convert_mb_str() function.

- Use tmp_pathbuf instead of HeapAlloc()/HeapFree(). - Remove mb_str_free() function. - Consider the case where the multibyte string stops in the middle of a multibyte char. --- winsup/cygwin/fhandler_tty.cc | 123 ++ 1 file changed, 82 insertions(+), 41 deletions

[PATCH 0/2] Cygwin: pty: Changes regarding charset conversion.

Takashi Yano (2): Cygwin: pty: Revise convert_mb_str() function. Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon. winsup/cygwin/fhandler_tty.cc | 135 +++--- 1 file changed, 93 insertions(+), 42 deletions(-) -- 2.28.0

[PATCH 2/2] Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon.

- If the non-cygwin apps is executed under pseudo console disabled, multibyte input for the apps are garbled. This patch fixes the issue. --- winsup/cygwin/fhandler_tty.cc | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cy

Re: [PATCH] Cygwin: pty: Fix input charset for non-cygwin apps with disable_pcon.

Hi Corinna, On Tue, 8 Sep 2020 20:42:47 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Sep 8 18:57, Takashi Yano via Cygwin-patches wrote: > > - If the non-cygwin apps is executed under pseudo console disabled, > > multibyte input for the apps are garbled. This patch fixes the > > issue.

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

On Sep 8 17:16, Takashi Yano via Cygwin-patches wrote: > On Mon, 7 Sep 2020 23:17:36 +0200 (CEST) > Johannes Schindelin wrote: > > Hi Takashi, > > > > On Sat, 5 Sep 2020, Takashi Yano wrote: > > > > > On Fri, 4 Sep 2020 08:23:42 +0200 (CEST) > > > Johannes Schindelin wrote: > > > > > > > > On Fr