[PATCH v4 1/3] Cygwin: rewrite and make public cmdline parser

2020-09-04 Thread Mingye Wang
This commit rewrites the cmdline parser to achieve the following: * MSVCRT compatibility. Except for the single-quote handling (an extension for compatibility with old Cygwin), the parser now interprets option boundaries exactly like MSVCR since 2008. This fixes the issue where our escaping d

[PATCH v4 3/3] testsuite: don't strip dir from obj files

2020-09-04 Thread Mingye Wang
Make has no idea how to build an o file when the correspoinding c file is not there. That happens when we strip the dir. --- winsup/testsuite/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/testsuite/Makefile.in b/winsup/testsuite/Makefile.in index bdc116d12.

[PATCH v4 2/3] regparm: make code highlight happy

2020-09-04 Thread Mingye Wang
--- winsup/cygwin/regparm.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/cygwin/regparm.h b/winsup/cygwin/regparm.h index cce1bab4a..a14c501db 100644 --- a/winsup/cygwin/regparm.h +++ b/winsup/cygwin/regparm.h @@ -8,7 +8,7 @@ details. */ #pragma once -#if defined

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Corinna Vinschen
Hi Takashi, On Sep 4 23:50, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Fri, 4 Sep 2020 14:44:00 +0200 > Corinna Vinschen wrote: > > On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: > > > I think I have found the answer to your request. > > > Patch attached. What do you th

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Takashi Yano via Cygwin-patches
Hi Johannes, On Fri, 4 Sep 2020 08:23:42 +0200 (CEST) Johannes Schindelin wrote: > Hi Takashi, > > On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote: > > > Hi Johannes and Corinna, > > > > On Tue, 1 Sep 2020 18:19:16 +0200 (CEST) > > Johannes Schindelin wrote: > > > > > When `LANG=en_US.

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Takashi Yano via Cygwin-patches
Hi Corinna, On Fri, 4 Sep 2020 14:44:00 +0200 Corinna Vinschen wrote: > Hi Takashi, > > On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: > > Hi Corinna, > > > > On Thu, 3 Sep 2020 19:59:12 +0200 > > Corinna Vinschen wrote: > > > The only idea I had so far was, changing the way __set_chars

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Johannes Schindelin
Hi Takashi, On Fri, 4 Sep 2020, Takashi Yano via Cygwin-patches wrote: > Hi Johannes and Corinna, > > On Tue, 1 Sep 2020 18:19:16 +0200 (CEST) > Johannes Schindelin wrote: > > > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > > correct, but after that (at least if Pseudo Consol

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Brian Inglis
On 2020-09-04 06:44, Corinna Vinschen wrote: > Hi Takashi, > > On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: >> Hi Corinna, >> >> On Thu, 3 Sep 2020 19:59:12 +0200 >> Corinna Vinschen wrote: >>> The only idea I had so far was, changing the way __set_charset_from_locale >>> works from wit

Re: [PATCH] Cygwin: create install dir for libs

2020-09-04 Thread Corinna Vinschen
On Aug 27 09:02, David McFarland via Cygwin-patches wrote: > This fixes a race in parallel installs. > --- > winsup/cygwin/Makefile.in | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/winsup/cygwin/Makefile.in b/winsup/cygwin/Makefile.in > index fac81759e..ea0243033 100644

[PATCH] Cygwin: create install dir for libs

2020-09-04 Thread David McFarland via Cygwin-patches
This fixes a race in parallel installs. --- winsup/cygwin/Makefile.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/cygwin/Makefile.in b/winsup/cygwin/Makefile.in index fac81759e..ea0243033 100644 --- a/winsup/cygwin/Makefile.in +++ b/winsup/cygwin/Makefile.in @@ -600,

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Corinna Vinschen
Hi Takashi, On Sep 4 18:21, Takashi Yano via Cygwin-patches wrote: > Hi Corinna, > > On Thu, 3 Sep 2020 19:59:12 +0200 > Corinna Vinschen wrote: > > The only idea I had so far was, changing the way __set_charset_from_locale > > works from within _setlocale_r: > > > > We could add a Cygwin-speci

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Takashi Yano via Cygwin-patches
Hi Johannes and Corinna, On Tue, 1 Sep 2020 18:19:16 +0200 (CEST) Johannes Schindelin wrote: > When `LANG=en_US.UTF-8`, the detected `LCID` is 0x0409, which is > correct, but after that (at least if Pseudo Console support is enabled), > we try to find the default code page for that `LCID`, which

Re: [PATCH 3/3] fhandler_pty_slave::setup_locale: respect charset == "UTF-8"

2020-09-04 Thread Takashi Yano via Cygwin-patches
Hi Corinna, On Thu, 3 Sep 2020 19:59:12 +0200 Corinna Vinschen wrote: > On Sep 2 18:38, Corinna Vinschen wrote: > > Hi Takashi, > > > > On Sep 3 01:25, Takashi Yano via Cygwin-patches wrote: > > > Hi Corinna, > > > > > > On Wed, 2 Sep 2020 17:24:50 +0200 > > > Corinna Vinschen wrote: > > > >