Hi,
On Fri, 28 Feb 2020, Jon Turney wrote:
> Mentioning the stack pointer in the clobber list is now a gcc warning.
>
> We never wanted gcc to try to restore %esp after this (x86-specific)
> asm, since the whole point of the inline asm here is to adjust %esp to
> satisfy alignment, so remove %esp
Am 28.02.2020 um 14:31 schrieb Corinna Vinschen:
[CC Hans]
Thanks. I wasn't subscribed to -patches so far. Will change that.
Hans,
as for making a patch for this issue, may I leave it to you
because you are already working on it?
My patch was meant only as a minimally-invasive stop-gap fi
On Feb 29 02:06, Takashi Yano wrote:
> On Fri, 28 Feb 2020 15:49:05 +0100
> Corinna Vinschen wrote:
> > Also, on second thought, given wpbuf is global inside this file, doesn't
> > this require guarding against multi-threaded access?
>
> wpbuf_put() is used in write(), and almost whole of write()
On Fri, 28 Feb 2020 15:49:05 +0100
Corinna Vinschen wrote:
> Also, on second thought, given wpbuf is global inside this file, doesn't
> this require guarding against multi-threaded access?
wpbuf_put() is used in write(), and almost whole of write()
code is guarded by output_mutex. So, I think it i
On Feb 28 15:44, Corinna Vinschen wrote:
> On Feb 28 14:31, Corinna Vinschen wrote:
> > [CC Hans]
> >
> > On Feb 28 11:14, Takashi Yano wrote:
> > > On Thu, 27 Feb 2020 18:03:47 +
> > > Jon Turney wrote:
> > > > > +#define wpbuf_put(x) \
> > > > > + wpbuf[wpixput++] = x; \
> > > > > + if (wp
On Feb 27 11:33, Takashi Yano wrote:
> - This patch makes some detailed behaviour of ESC sequences such as
> "CSI Ps L" (IL), "CSI Ps M" (DL) and "ESC M" (RI) in xterm mode
> match with real xterm.
> ---
> winsup/cygwin/fhandler.h | 1 +
> winsup/cygwin/fhandler_console.cc | 51 +
On Feb 28 14:31, Corinna Vinschen wrote:
> [CC Hans]
>
> On Feb 28 11:14, Takashi Yano wrote:
> > On Thu, 27 Feb 2020 18:03:47 +
> > Jon Turney wrote:
> > > > +#define wpbuf_put(x) \
> > > > + wpbuf[wpixput++] = x; \
> > > > + if (wpixput > WPBUF_LEN) \
> > > > +wpixput--;
> > > > +
> >
On Feb 28 12:04, Jon Turney wrote:
> Mentioning the stack pointer in the clobber list is now a gcc warning.
>
> We never wanted gcc to try to restore %esp after this (x86-specific)
> asm, since the whole point of the inline asm here is to adjust %esp to
> satisfy alignment, so remove %esp from the
[CC Hans]
On Feb 28 11:14, Takashi Yano wrote:
> On Thu, 27 Feb 2020 18:03:47 +
> Jon Turney wrote:
> > > +#define wpbuf_put(x) \
> > > + wpbuf[wpixput++] = x; \
> > > + if (wpixput > WPBUF_LEN) \
> > > +wpixput--;
> > > +
> >
> > So I think either the macro need it contents contained b
Mentioning the stack pointer in the clobber list is now a gcc warning.
We never wanted gcc to try to restore %esp after this (x86-specific)
asm, since the whole point of the inline asm here is to adjust %esp to
satisfy alignment, so remove %esp from the asm clobber list.
Of more concern is the al
10 matches
Mail list logo
