Re: [PATCH v2] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

2020-02-10 Thread Thomas Wolff
Am 10.02.2020 um 13:24 schrieb Takashi Yano: On Mon, 10 Feb 2020 11:07:10 +0100 Corinna Vinschen wrote: On Feb 8 18:13, Thomas Wolff wrote: On 22.01.2020 11:06, Corinna Vinschen wrote: On Jan 21 22:25, Takashi Yano wrote: - For programs which does not work properly with pseudo console, d

[PATCH v2] Cygwin: pty: Add error handling in setup_pseudoconsole().

2020-02-10 Thread Takashi Yano
- In setup_pseudoconsole(), many error handling was omitted. This patch adds missing error handling. --- winsup/cygwin/fhandler_tty.cc | 179 +- 1 file changed, 111 insertions(+), 68 deletions(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler

Re: [PATCH] Cygwin: pty: Add error handling in setup_pseudoconsoe().

2020-02-10 Thread Takashi Yano
[PATCH] Cygwin: pty: Add error handling in setup_pseudoconsoe(). s/pseudoconsoe/pseudoconsole/

Re: [PATCH] Cygwin: pty: Add error handling in setup_pseudoconsoe().

2020-02-10 Thread Corinna Vinschen
On Feb 11 00:12, Takashi Yano wrote: > - In setup_pseudoconsole(), many error handling was omitted. This > patch adds missing error handling. > --- > winsup/cygwin/fhandler_tty.cc | 94 +-- > 1 file changed, 68 insertions(+), 26 deletions(-) Uhm... please, no. T

[PATCH] Cygwin: pty: Add error handling in setup_pseudoconsoe().

2020-02-10 Thread Takashi Yano
- In setup_pseudoconsole(), many error handling was omitted. This patch adds missing error handling. --- winsup/cygwin/fhandler_tty.cc | 94 +-- 1 file changed, 68 insertions(+), 26 deletions(-) diff --git a/winsup/cygwin/fhandler_tty.cc b/winsup/cygwin/fhandler_

Re: [PATCH] Cygwin: pty: Prevent potential errno overwriting.

2020-02-10 Thread Corinna Vinschen
On Feb 10 20:42, Takashi Yano wrote: > - In push_to_pcon_screenbuffer(), open() and ioctl() are called. > Since push_to_pcon_screenbuffer() is called in read() and write(), > errno which is set in read() and write() code may be overwritten > in open() or ioctl() call. This patch prevent this

Re: [PATCH v2] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

2020-02-10 Thread Takashi Yano
On Mon, 10 Feb 2020 11:07:10 +0100 Corinna Vinschen wrote: > On Feb 8 18:13, Thomas Wolff wrote: > > On 22.01.2020 11:06, Corinna Vinschen wrote: > > > On Jan 21 22:25, Takashi Yano wrote: > > > > - For programs which does not work properly with pseudo console, > > > >disable_pcon in environme

Re: [PATCH] Cygwin: pty: Use pinfo() rather than kill() with signal 0.

2020-02-10 Thread Takashi Yano
Hi Corinna, On Mon, 10 Feb 2020 00:06:03 +0900 Takashi Yano wrote: > On Sat, 8 Feb 2020 23:53:11 +0900 > Takashi Yano wrote: > > On Thu, 6 Feb 2020 20:03:30 +0100 > > Corinna Vinschen wrote: > > > I'm inclined to release 3.1.3 next week. Is that ok with you or > > > do you anticipate more patches

[PATCH] Cygwin: pty: Prevent potential errno overwriting.

2020-02-10 Thread Takashi Yano
- In push_to_pcon_screenbuffer(), open() and ioctl() are called. Since push_to_pcon_screenbuffer() is called in read() and write(), errno which is set in read() and write() code may be overwritten in open() or ioctl() call. This patch prevent this situation. --- winsup/cygwin/fhandler_tty.cc

Re: [PATCH v2] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

2020-02-10 Thread Corinna Vinschen
On Feb 8 18:13, Thomas Wolff wrote: > On 22.01.2020 11:06, Corinna Vinschen wrote: > > On Jan 21 22:25, Takashi Yano wrote: > > > - For programs which does not work properly with pseudo console, > > >disable_pcon in environment CYGWIN is introduced. If disable_pcon > > >is set, pseudo cons

Re: [PATCH] Cygwin: pty: Fix state mismatch caused in mintty.

2020-02-10 Thread Corinna Vinschen
On Feb 9 23:47, Takashi Yano wrote: > - PTY has a bug reported in: > https://cygwin.com/ml/cygwin/2020-02/msg00067.html. > This is the result of state mismatch between real pseudo console > attaching state and state variable. This patch fixes the issue. > --- > winsup/cygwin/fhandler_tty.cc

Re: [PATCH] Cygwin: pty: Inherit typeahead data between two input pipes.

2020-02-10 Thread Corinna Vinschen
On Feb 9 23:46, Takashi Yano wrote: > - PTY has a problem that the key input, which is typed during > windows native app is running, disappear when it returns to shell. > (Problem 3 in https://cygwin.com/ml/cygwin/2020-02/msg7.html) > This is beacuse pty has two input pipes, one is for c

Re: [PATCH 0/4] Remove debug codes and organize with some fixes.

2020-02-10 Thread Corinna Vinschen
On Feb 9 23:45, Takashi Yano wrote: > Takashi Yano (4): > Cygwin: pty: Define mask_switch_to_pcon_in() in fhandler_tty.cc. > Cygwin: pty: Avoid screen distortion on slave read. > Cygwin: pty: Remove debug codes and organize related codes. > Cygwin: pty: Add missing member initialization fo