[PATCH v2] Cygwin: pty: Revise code waiting for forwarding by master_fwd_thread.

2020-01-20 Thread Takashi Yano
- Though this rarely happens, sometimes the first printing of non- cygwin process does not displayed correctly. To fix this issue, the code for waiting for forwarding by master_fwd_thread is revised. --- winsup/cygwin/fhandler_tty.cc | 15 +++ winsup/cygwin/tty.cc | 1 +

Re: [PATCH] Cygwin: pty: Revise code waiting for forwarding by master_fwd_thread.

2020-01-20 Thread Takashi Yano
On Mon, 20 Jan 2020 11:39:39 +0100 Corinna Vinschen wrote: > Are these 40 ms an experimental value or is that based on knowledge > of implementation details? It is experimental value which I measured in several environment. > The real question is, isn't there any > other, more reliable indicator

Re: [PATCH v4 0/4] Support opening a symlink with O_PATH | O_NOFOLLOW

2020-01-20 Thread Corinna Vinschen
On Jan 20 14:57, Ken Brown wrote: > On 1/20/2020 4:56 AM, Corinna Vinschen wrote: > > On Jan 17 16:10, Ken Brown wrote: > >> Currently, opening a symlink with O_NOFOLLOW fails with ELOOP. > >> Following Linux, the first patch in this series allows the call to > >> succeed if O_PATH is also specifie

Re: [PATCH] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

2020-01-20 Thread Ken Brown
[Adding the cgdb maintainer to the CC.] On 1/20/2020 9:18 AM, Jon Turney wrote: > On 20/01/2020 12:41, Takashi Yano wrote: >> Hi Corinna, >> >> On Mon, 20 Jan 2020 11:06:46 +0100 >> Corinna Vinschen wrote: >>> On Jan 20 11:50, Takashi Yano wrote: - For programs which does not work properly wi

Re: [PATCH v4 0/4] Support opening a symlink with O_PATH | O_NOFOLLOW

2020-01-20 Thread Ken Brown
On 1/20/2020 4:56 AM, Corinna Vinschen wrote: > On Jan 17 16:10, Ken Brown wrote: >> Currently, opening a symlink with O_NOFOLLOW fails with ELOOP. >> Following Linux, the first patch in this series allows the call to >> succeed if O_PATH is also specified. >> >> According to the Linux man page for

Re: [PATCH] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

2020-01-20 Thread Jon Turney
On 20/01/2020 12:41, Takashi Yano wrote: Hi Corinna, On Mon, 20 Jan 2020 11:06:46 +0100 Corinna Vinschen wrote: On Jan 20 11:50, Takashi Yano wrote: - For programs which does not work properly with pseudo console, disable_pcon in environment CYGWIN is introduced. If disable_pcon is set,

Re: [PATCH] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

2020-01-20 Thread Takashi Yano
Hi Corinna, On Mon, 20 Jan 2020 11:06:46 +0100 Corinna Vinschen wrote: > On Jan 20 11:50, Takashi Yano wrote: > > - For programs which does not work properly with pseudo console, > > disable_pcon in environment CYGWIN is introduced. If disable_pcon > > is set, pseudo console support is disable

Re: [PATCH] Cygwin: pty: Revise code waiting for forwarding by master_fwd_thread.

2020-01-20 Thread Corinna Vinschen
Hi Takashi, On Jan 20 11:50, Takashi Yano wrote: > - Though this rarely happens, sometimes the first printing of non- > cygwin process does not displayed correctly. To fix this issue, > the code for waiting for forwarding by master_fwd_thread is revised. > --- > [...] > +void > +fhandler_pty_s

Re: [PATCH] Cygwin: pty: Introduce disable_pcon in environment CYGWIN.

2020-01-20 Thread Corinna Vinschen
On Jan 20 11:50, Takashi Yano wrote: > - For programs which does not work properly with pseudo console, > disable_pcon in environment CYGWIN is introduced. If disable_pcon > is set, pseudo console support is disabled. Oh well, do we really need that? Anyway, this patch also requires an additi

Re: [PATCH v4 0/4] Support opening a symlink with O_PATH | O_NOFOLLOW

2020-01-20 Thread Corinna Vinschen
On Jan 17 16:10, Ken Brown wrote: > Currently, opening a symlink with O_NOFOLLOW fails with ELOOP. > Following Linux, the first patch in this series allows the call to > succeed if O_PATH is also specified. > > According to the Linux man page for open(2), "the call returns a file > descriptor refe

Re: [PATCH] Cygwin: allow opening an AF_LOCAL/AF_UNIX socket with O_PATH

2020-01-20 Thread Corinna Vinschen
On Jan 19 20:25, Ken Brown wrote: > On 1/17/2020 4:51 AM, Corinna Vinschen wrote: > > On Jan 17 10:48, Corinna Vinschen wrote: > >> On Jan 16 18:34, Ken Brown wrote: > >>> If that flag is not set, or if an attempt is made to open a different > >>> type of socket, the errno is now EOPNOTSUPP instead