RE: [PATCH] Cygwin: pty: Fix ESC[?3h and ESC[?3l handling again.

2019-12-19 Thread Lavrentiev, Anton (NIH/NLM/NCBI) [C] via cygwin-patches
Just noticed that in the patch below and couldn't help it, sorry.. Things like char* p0; and later: isdigit(*p0)) or isalpha(*p0) are usually not a good (correct) way of coding, because of possible sign extension of *p0 which you normally wouldn't want to have (remember the ctype calls/macr

Re: [PATCH] Cygwin: pty: Fix ESC[?3h and ESC[?3l handling again.

2019-12-19 Thread Corinna Vinschen
On Dec 19 20:03, Takashi Yano wrote: > - Even with commit fe512b2b12a2cea8393d14f038dc3914b1bf3f60, pty > still has a problem in ESC[?3h and ESC[?3l handling if invalid > sequence such as ESC[?$ is sent. This patch fixes the issue. > --- > winsup/cygwin/fhandler_tty.cc | 2 +- > 1 file changed

[PATCH] Cygwin: pty: Fix ESC[?3h and ESC[?3l handling again.

2019-12-19 Thread Takashi Yano
- Even with commit fe512b2b12a2cea8393d14f038dc3914b1bf3f60, pty still has a problem in ESC[?3h and ESC[?3l handling if invalid sequence such as ESC[?$ is sent. This patch fixes the issue. --- winsup/cygwin/fhandler_tty.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/win