[PATCH v2] cygcheck: expand common_apps list

2019-06-03 Thread Yaakov Selkowitz
An increasing number of tools are being included in Windows which have the same names as those included in Cygwin packages. Indicating which one is first in PATH can be helpful in diagnosing behavioural discrepencies between them. Also, fix the alphabetization of ssh. --- winsup/utils/cygcheck.c

Re: [PATCH] cygcheck: expand common_apps list

2019-06-03 Thread Brian Inglis
On 2019-06-03 13:35, Corinna Vinschen wrote: > On May 23 13:05, Yaakov Selkowitz wrote: >> An increasing number of tools are being included in Windows which have the >> same names as those included in Cygwin packages. Indicating which one is >> first in PATH can be helpful in diagnosing behavioura

Re: [PATCH] mkdir: always check-for-existence

2019-06-03 Thread Ben
When creating a directory which already exists, NtCreateFile will correctly return 'STATUS_OBJECT_NAME_COLLISION'. However when creating a directory and all its parents a normal use would be to start with mkdir(‘/cygdrive/c’) which translates to ‘C:\’ for which it'll instead return ‘STATUS_ACCE

Re: [PATCH] cygcheck: expand common_apps list

2019-06-03 Thread Corinna Vinschen
Hi Yaakov, On May 23 13:05, Yaakov Selkowitz wrote: > An increasing number of tools are being included in Windows which have the > same names as those included in Cygwin packages. Indicating which one is > first in PATH can be helpful in diagnosing behavioural discrepencies > between them. > > A

Re: [PATCH] mkdir: alway check-for-existence

2019-06-03 Thread Corinna Vinschen
Hi Ben, I'm fine with the patch, and it's short enough not to require an entry in the CONTRIBUTORS file, but the commit msg needs some rephrasing: On Jun 3 20:31, Ben wrote: > When using either CreateDirectory or NtCreateFile when creating a directory > that already exists, these functions retur

[PATCH] mkdir: alway check-for-existence

2019-06-03 Thread Ben
When using either CreateDirectory or NtCreateFile when creating a directory that already exists, these functions return: ERROR_ALREADY_EXISTS However when using these function to create a directory (and all its parents) a normal use would be to start with mkdir(‘/c’) which translates to ‘C:\’ f

Re: [PATCH 1/2] Cygwin: fork: Always pause child after fixups.

2019-06-03 Thread Corinna Vinschen
On Apr 30 09:09, Michael Haubenwallner wrote: > Pause the child process after performing fork fixups even if there were > no dynamically loaded dlls with extra data/bss transfers to wait for. > This allows the parent process to cancel the current fork call even if > the child process was successful

Re: [PATCH] Cygwin: dll_list: stat_real_file_once with ntname

2019-06-03 Thread Corinna Vinschen
On May 3 16:14, Michael Haubenwallner wrote: > NtQueryVirtualMemory for MemorySectionName may return some old path even > if the process was just started, for when some directory in between was > renamed - maybe because the NT file cache is hot for the old path still. > This was seen during gcc bo

Re: [PATCH] Cygwin: dll_list: no recursive use of nt_max_path_buf

2019-06-03 Thread Corinna Vinschen
On May 13 16:36, Michael Haubenwallner wrote: > Querying the ntlength and existence of the /var/run/cygfork directory in > the very first Cygwin process should not use nt_max_path_buf, as that > one is used by dll_list::alloc already. > --- > winsup/cygwin/forkable.cc | 13 + > 1 file

Re: [rebase PATCH] Introduce --merge-files (-M) flag (WAS: Introduce --no-rebase flag)

2019-06-03 Thread Corinna Vinschen
On Jun 3 18:30, Corinna Vinschen wrote: > On May 6 10:31, Michael Haubenwallner wrote: > > > > On 5/4/19 4:33 PM, Brian Inglis wrote: > > > On 2019-05-03 09:32, Michael Haubenwallner wrote: > > >> On 4/12/19 8:03 PM, Corinna Vinschen wrote: > > >>> On Apr 12 15:52, Michael Haubenwallner wrote: >

Re: [PATCH draft 0/6] Remove the fhandler_base_overlapped class

2019-06-03 Thread Corinna Vinschen
On May 30 12:56, Ken Brown wrote: > On 5/26/2019 11:10 AM, Ken Brown wrote: > > fhandler_pipe is currently the only class derived from > > fhandler_base_overlapped. This patch series rewrites parts of > > fhandler_pipe so that it can be derived from fhandler_base instead. > > We can then simplify

Re: [PATCH] cygcheck: expand common_apps list

2019-06-03 Thread Corinna Vinschen
On May 27 00:50, Yaakov Selkowitz wrote: > On Sun, 2019-05-26 at 00:49 -0600, Brian Inglis wrote: > > To a degree, depends on installed Cygwin packages and Windows features, but > > I > > also have in both Cygwin /{,{,usr/}s}bin and > > /Windows/{,System32{,/OpenSSH}/: > > > > {"certutil

Re: [rebase PATCH] Introduce --merge-files (-M) flag (WAS: Introduce --no-rebase flag)

2019-06-03 Thread Corinna Vinschen
On May 6 10:31, Michael Haubenwallner wrote: > > On 5/4/19 4:33 PM, Brian Inglis wrote: > > On 2019-05-03 09:32, Michael Haubenwallner wrote: > >> On 4/12/19 8:03 PM, Corinna Vinschen wrote: > >>> On Apr 12 15:52, Michael Haubenwallner wrote: > The --no-rebase flag is to update the database