Re: [PATCH 1/2] posix_fadvise() *returns* error codes but does not set errno

2017-11-02 Thread Corinna Vinschen
On Nov 2 16:45, Erik M. Bray wrote: > Also updates the fhandler_*::fadvise implementations to adhere to the same > semantics. Both patches pushed. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT

[PATCH 1/2] posix_fadvise() *returns* error codes but does not set errno

2017-11-02 Thread Erik M. Bray
Also updates the fhandler_*::fadvise implementations to adhere to the same semantics. --- winsup/cygwin/fhandler_disk_file.cc | 11 +++ winsup/cygwin/pipe.cc | 3 +-- winsup/cygwin/syscalls.cc | 2 +- 3 files changed, 5 insertions(+), 11 deletions(-) diff --git a

[PATCH 2/2] posix_fallocate() *returns* error codes but does not set errno

2017-11-02 Thread Erik M. Bray
Also updates the fhandler_*::ftruncate implementations to adhere to the same semantics. The error handling semantics of those syscalls that use fhandler_*::ftruncate are moved to the implementations of those syscalls ( in particular ftruncate() and friends still set errno and return -1 on error bu

Re: [PATCH 2/2] posix_fallocate() *returns* error codes but does not set errno

2017-11-02 Thread Erik Bray
On Thu, Nov 2, 2017 at 4:06 PM, Corinna Vinschen wrote: > Hi Erik, > > On Nov 2 15:15, Erik M. Bray wrote: >> diff --git a/winsup/cygwin/fhandler_disk_file.cc >> b/winsup/cygwin/fhandler_disk_file.cc >> index f46e355..9d5ec30 100644 >> --- a/winsup/cygwin/fhandler_disk_file.cc >> +++ b/winsup/cyg

Re: [PATCH] posix_fadvise() *returns* error codes but does not set errno

2017-11-02 Thread Erik Bray
On Thu, Nov 2, 2017 at 3:58 PM, Corinna Vinschen wrote: > Hi Eric, > > On Nov 2 14:26, Erik M. Bray wrote: >> Also updates the fhandler_*::fadvise implementations to adhere to the same >> semantics. > > Good catch. I have just some style nits. > >> --- >> winsup/cygwin/fhandler.cc |

Re: [PATCH] posix_fadvise() *returns* error codes but does not set errno

2017-11-02 Thread Corinna Vinschen
On Nov 2 15:58, Corinna Vinschen wrote: > Hi Eric, s/Eric/Erik/ Sorry, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat signature.asc Description: PGP signature

Re: [PATCH 2/2] posix_fallocate() *returns* error codes but does not set errno

2017-11-02 Thread Corinna Vinschen
Hi Erik, On Nov 2 15:15, Erik M. Bray wrote: > diff --git a/winsup/cygwin/fhandler_disk_file.cc > b/winsup/cygwin/fhandler_disk_file.cc > index f46e355..9d5ec30 100644 > --- a/winsup/cygwin/fhandler_disk_file.cc > +++ b/winsup/cygwin/fhandler_disk_file.cc > @@ -1116,11 +1116,11 @@ fhandler_disk_

Re: [PATCH] posix_fadvise() *returns* error codes but does not set errno

2017-11-02 Thread Corinna Vinschen
Hi Eric, On Nov 2 14:26, Erik M. Bray wrote: > Also updates the fhandler_*::fadvise implementations to adhere to the same > semantics. Good catch. I have just some style nits. > --- > winsup/cygwin/fhandler.cc | 3 +-- > winsup/cygwin/fhandler_disk_file.cc | 16 ++-- >

[PATCH 2/2] posix_fallocate() *returns* error codes but does not set errno

2017-11-02 Thread Erik M. Bray
Also updates the fhandler_*::ftruncate implementations to adhere to the same semantics. The error handling semantics of those syscalls that use fhandler_*::ftruncate are moved to the implementations of those syscalls ( in particular ftruncate() and friends still set errno and return -1 on error bu

[PATCH] posix_fadvise() *returns* error codes but does not set errno

2017-11-02 Thread Erik M. Bray
Also updates the fhandler_*::fadvise implementations to adhere to the same semantics. --- winsup/cygwin/fhandler.cc | 3 +-- winsup/cygwin/fhandler_disk_file.cc | 16 ++-- winsup/cygwin/pipe.cc | 3 +-- winsup/cygwin/syscalls.cc | 2 +- 4 files chan