Re: renameat2

2017-08-19 Thread Corinna Vinschen
On Aug 19 13:24, Ken Brown wrote: > On 8/19/2017 12:28 PM, Corinna Vinschen wrote: > > Doc changes coming? :) > > Attached. Pushed. I also generated new developer snapshots. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: renameat2

2017-08-19 Thread Corinna Vinschen
On Aug 19 13:13, Ken Brown wrote: > On 8/19/2017 12:37 PM, Corinna Vinschen wrote: > > Oh, one more thing. This is a question to Yaakov, too. > > > > diff --git a/newlib/libc/include/stdio.h b/newlib/libc/include/stdio.h > > index 5d8cb1092..331a1cf07 100644 > > --- a/newlib/libc/include/stdio.h

Re: renameat2

2017-08-19 Thread Ken Brown
On 8/19/2017 12:28 PM, Corinna Vinschen wrote: Doc changes coming? :) Attached. Ken From 0704541f1d29e0d9aa0af6e549f8ca0114a44a7c Mon Sep 17 00:00:00 2001 From: Ken Brown Date: Sat, 19 Aug 2017 13:15:04 -0400 Subject: [PATCH] Document renameat2 --- winsup/cygwin/release/2.9.0 | 2 ++ winsu

Re: renameat2

2017-08-19 Thread Ken Brown
On 8/19/2017 12:37 PM, Corinna Vinschen wrote: > Oh, one more thing. This is a question to Yaakov, too. > > diff --git a/newlib/libc/include/stdio.h b/newlib/libc/include/stdio.h > index 5d8cb1092..331a1cf07 100644 > --- a/newlib/libc/include/stdio.h > +++ b/newlib/libc/include/stdio.h > @@ -384,

Re: renameat2

2017-08-19 Thread Corinna Vinschen
On Aug 19 18:28, Corinna Vinschen wrote: > On Aug 19 10:29, Ken Brown wrote: > > Hi Corinna, > > > > On 8/19/2017 5:57 AM, Corinna Vinschen wrote: > > > Hi Ken, > > > > > > On Aug 18 18:24, Ken Brown wrote: > > > The patch is ok as is, just let me know what you think of the above > > > minor twea

Re: renameat2

2017-08-19 Thread Corinna Vinschen
On Aug 19 10:29, Ken Brown wrote: > Hi Corinna, > > On 8/19/2017 5:57 AM, Corinna Vinschen wrote: > > Hi Ken, > > > > On Aug 18 18:24, Ken Brown wrote: > > The patch is ok as is, just let me know what you think of the above > > minor tweak (and send the revised patch if you agree). > > Yes, I ag

Re: renameat2

2017-08-19 Thread Ken Brown
Hi Corinna, On 8/19/2017 5:57 AM, Corinna Vinschen wrote: Hi Ken, On Aug 18 18:24, Ken Brown wrote: Thanks for the improvements! A revised patch is attached. As you'll see, I still found a few places where I thought I needed to explicitly set the errno to EEXIST. Let me know if any of these

Re: renameat2

2017-08-19 Thread Corinna Vinschen
Hi Ken, On Aug 18 18:24, Ken Brown wrote: > Hi Corinna, > > On 8/18/2017 11:15 AM, Corinna Vinschen wrote: > > On Aug 18 09:21, Ken Brown wrote: > > But there's light. NtSetInformationFile(FileRenameInformation) already > > supports RENAME_NOREPLACE :) > > > > Have a look at line 2494 (prior to