Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Peter Foley
On Sun, Mar 20, 2016 at 5:55 AM, Corinna Vinschen wrote: > There's an assign.txt document you (and potentiall your employer) can > sign and send as PDF. It's usually rather painless. > > > Thanks, > Corinna Copyright assignment form signed and emailed. Thanks, Peter Foley

Re: [PATCH] Re: Cygwin select() issues and improvements

2016-03-20 Thread Corinna Vinschen
Hi John, On Mar 19 18:43, john hood wrote: > From c805552cdc9e673ef2330388ddb8b7a0da741766 Mon Sep 17 00:00:00 2001 > From: John Hood > Date: Thu, 28 Jan 2016 17:08:39 -0500 > Subject: [PATCH 1/5] Use high-resolution timebases for select(). > > * cygwait.h: Add cygwait_us() methods. >

Re: Cygwin select() issues and improvements

2016-03-20 Thread Corinna Vinschen
Sidenote from the past: On Feb 15 13:57, Corinna Vinschen wrote: > On Feb 14 03:09, john hood wrote: > > Windows scheduling in general seems to be rather poor for Cygwin > > processes, and there are scheduling differences between processes run in > > Windows console (which are seen as interactive

Re: [PATCH 11/11] respect datarootdir

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > Recent versions of autoconf define datadir/infodir in terms of > datarootdir. Add it. > > winsup/ChangeLog > * Makefile.in: define datarootdir Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Main

Re: [PATCH 09/11] Add c++14 sized deallocation operator

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > When compiling with -std=c++14 (the default for gcc 6.0+), the sized > deallocation operator must be defined to prevent undefined symbols when > linking. > > winsup/cygwin/ChangeLog: > cxx.cc (operator delete(void *p, size_t)): Define. > > Signed-off-by: Pete

Re: [PATCH 10/11] Fix strict aliasing

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > Fix a strict aliasing error detected by gcc 6.0+ > > winsup/cygwin/ChangeLog > * pinfo.cc (winpids::enum_process): Fix strict aliasing. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer

Re: [PATCH 08/11] Fix typoed comparison

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > winsup/cygwin/ChangeLog > * thread.cc (semaphore::open): Fix mistaken conditional. Applied. THanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwin AT cygwin DOT com Red Hat sig

Re: [PATCH 07/11] The address of an class always evaluates to true

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > winsup/cygwin/pinfo.cc:465:14: error: the compiler can assume that the > address of 'tc' will always evaluate to 'true' [-Werror=address] > > winsup/cygwin/ChangeLog > * pinfo.cc (_pinfo::set_ctty): remove always true check. Applied. Thanks, Corinna -- Co

Re: [PATCH 05/11] A pointer to a pointer is nonnull.

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > GCC 6.0+ can assert that this argument is nonnull. > Remove the unnecessary check to fix a warning. > > winsup/cygwin/ChangeLog > malloc_wrapper.cc (posix_memalign): Remove always true nonnull check. Eh, what?!? How on earth can gcc assert memptr is always n

Re: [PATCH 04/11] Remove misleading indentation

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > GCC 6.0+ warns on misleading indentation, so fix it. > > winsup/cygserver/ChangeLog > * sysv_msg.cc (msgsnd): Fix misleading indentation. > * sysv_msg.cc (msgrcv): Ditto. > * sysv_sem.cc (semop): Ditto. > winsup/cygwing/ChangeLog > * syscalls.cc (getpriority):

Re: [PATCH 02/11] Remove dead code from fhandler_console.

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > This if is unconditionally false, so remove it. > > winsup/cygwin/fhandler_console.cc: In member function 'bool > dev_console::fillin(HANDLE)': > winsup/cygwin/fhandler_console.cc:740:22: error: self-comparison always > evaluates to false [-Werror=tautologic

Re: [PATCH 03/11] Add necessary braces to if statements

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > The missing braces cause only the first expression to be guarded by the > else clause. > > winsup/cygwin/ChangeLog > * fhandler_disk_file.cc (facl): Add missing braces to if statement. > * mount.cc (dos_drive_mappings): Add missing braces to if statement. App

Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Corinna Vinschen
On Mar 19 13:45, Peter Foley wrote: > initial_sp has been unused since commit fbf23e3 back in 2000. > Keep the value, so as to avoid changing the offset of magic_biscuit. > > winsup/cygwin/lib/_cygwin_crt0_common.cc:140:52: > error: calling 'void* __builtin_frame_address(unsigned int)' with a > no

Re: [PATCH 01/11] Remove unused and unsafe call to __builtin_frame_address

2016-03-20 Thread Corinna Vinschen
Hi Peter, thanks for the patch series. With the exception of patch 6 all of them are short enough to go in as trivial patches. However, for patch 6 we'd need a copyright assignment from you. Please have a look at the "Before you get started" section on https://cygwin.com/contrib.html There's