Re: [PATCH] mkglobals: Fix EOL detection

2015-08-17 Thread Corinna Vinschen
On Aug 17 10:41, Orgad Shaneh wrote: > When globals.cc has CRLF line endings, winsup.h is not removed, and > compilation fails for duplicate definitions. Applied. Thanks, Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to Cygwin Maintainer cygwi

Re: [PATCH] mkglobals: Fix EOL detection

2015-08-17 Thread Orgad Shaneh
On Mon, Aug 17, 2015 at 11:15 AM, Corinna Vinschen wrote: > On Aug 17 11:02, Orgad Shaneh wrote: >> On Mon, Aug 17, 2015 at 10:59 AM, Corinna Vinschen >> wrote: >> > On Aug 17 10:41, Orgad Shaneh wrote: >> >> When globals.cc has CRLF line endings, winsup.h is not removed, and >> >> compilation fa

Re: [PATCH] mkglobals: Fix EOL detection

2015-08-17 Thread Corinna Vinschen
On Aug 17 11:02, Orgad Shaneh wrote: > On Mon, Aug 17, 2015 at 10:59 AM, Corinna Vinschen > wrote: > > On Aug 17 10:41, Orgad Shaneh wrote: > >> When globals.cc has CRLF line endings, winsup.h is not removed, and > >> compilation fails for duplicate definitions. > > > > Why on earth should globals

Re: [PATCH] mkglobals: Fix EOL detection

2015-08-17 Thread Orgad Shaneh
On Mon, Aug 17, 2015 at 10:59 AM, Corinna Vinschen wrote: > On Aug 17 10:41, Orgad Shaneh wrote: >> When globals.cc has CRLF line endings, winsup.h is not removed, and >> compilation fails for duplicate definitions. > > Why on earth should globals.h get CRLF line endings? It's stored > with LF li

Re: [PATCH] mkglobals: Fix EOL detection

2015-08-17 Thread Corinna Vinschen
On Aug 17 10:41, Orgad Shaneh wrote: > When globals.cc has CRLF line endings, winsup.h is not removed, and > compilation fails for duplicate definitions. Why on earth should globals.h get CRLF line endings? It's stored with LF line endings in git. There's no reason to convert the file. Corinna

[PATCH] mkglobals: Fix EOL detection

2015-08-17 Thread Orgad Shaneh
When globals.cc has CRLF line endings, winsup.h is not removed, and compilation fails for duplicate definitions. --- winsup/cygwin/mkglobals_h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/winsup/cygwin/mkglobals_h b/winsup/cygwin/mkglobals_h index ea4a582..2d185f2 100755 ---