Re: making scanf byte-clean(er)

2010-01-10 Thread Corinna Vinschen
On Jan 10 19:39, Andy Koppe wrote: > Attached is a patch for making the scanf format string (more) > byte-transparent. It actually couldn't deal with non-ASCII chars at > all, even valid ones, due to comparing an 'unsigned char' with a > (signed) 'char'. And when encountering an invalid byte, it wo

making scanf byte-clean(er)

2010-01-10 Thread Andy Koppe
Attached is a patch for making the scanf format string (more) byte-transparent. It actually couldn't deal with non-ASCII chars at all, even valid ones, due to comparing an 'unsigned char' with a (signed) 'char'. And when encountering an invalid byte, it would go backwards in the format string. Fina

Re: [PATCH] Fix misc aliasing warnings.

2010-01-10 Thread Christopher Faylor
On Sun, Jan 10, 2010 at 12:12:40PM +0100, Corinna Vinschen wrote: >Still, it looks bad since it seems so superfluous. I don't think we >should rely so heavily on the compiler optimization. Ditto. cgf

Re: [PATCH] Fix misc aliasing warnings.

2010-01-10 Thread Corinna Vinschen
On Jan 9 19:47, Dave Korn wrote: > Corinna Vinschen wrote: > > > Concerning fstat_helper, I don't like to slip another layer into these > > calls to pamper an anal-retentive compiler. I would rather like to fix > > this by removing the FILETIME type from the affected places and use > > LARGE_INT