Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Brian Dessent
Corinna Vinschen wrote: > The problem is that the cwd is stored as UNICODE_STRING with a > statically allocated buffer in the user parameter block. The > MaximumLength is set to 520. SetCurrentDirectory refuses to take paths > longer than that. In theory it would be possible to define a longer

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 08:55:09PM +0100, Corinna Vinschen wrote: >On Mar 9 11:03, Brian Dessent wrote: >> Christopher Faylor wrote: >> >> > I guess I misunderstood. I thought that the current working directory >> > could be derived through some complicated combination of Nt*() calls. >> >> I c

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Corinna Vinschen
On Mar 9 11:03, Brian Dessent wrote: > Christopher Faylor wrote: > > > I guess I misunderstood. I thought that the current working directory > > could be derived through some complicated combination of Nt*() calls. > > I could be wrong here but the way I understood it, there is no concept > of

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Brian Dessent
Christopher Faylor wrote: > I guess I misunderstood. I thought that the current working directory > could be derived through some complicated combination of Nt*() calls. I could be wrong here but the way I understood it, there is no concept of a working directory at the NT level, that is somethi

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 04:14:40PM +0100, Corinna Vinschen wrote: >On Mar 9 10:38, Christopher Faylor wrote: >> On Sun, Mar 09, 2008 at 10:28:06AM +0100, Corinna Vinschen wrote: >> >Bash as well as tcsh, as well as zsh (and probbaly pdksh, too) create an >> >environment variable $PWD. Maybe Cygwi

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Corinna Vinschen
On Mar 9 10:38, Christopher Faylor wrote: > On Sun, Mar 09, 2008 at 10:28:06AM +0100, Corinna Vinschen wrote: > >Bash as well as tcsh, as well as zsh (and probbaly pdksh, too) create an > >environment variable $PWD. Maybe Cygwin should create $PWD for native > >apps if it's not already available

Re: [patch] utils/path.cc fixes and testsuite

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 12:55:13AM -0800, Brian Dessent wrote: >Corinna Vinschen wrote: > >> Doesn't that install testsuite.exe at `make install' time? > >Ack, how about the attached? > >Brian >2008-03-09 Brian Dessent <[EMAIL PROTECTED]> > > * Makefile.in (install): Don't install the tests

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Christopher Faylor
On Sun, Mar 09, 2008 at 10:28:06AM +0100, Corinna Vinschen wrote: >Hi Brian, > >Thanks for your patch. I have a few nits, sorry. > >On Mar 8 20:13, Brian Dessent wrote: >> Index: cygcheck.cc >> === >> RCS file: /cvs/src/src/winsup/ut

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Corinna Vinschen
On Mar 9 05:02, Brian Dessent wrote: > Corinna Vinschen wrote: > > > Now that you mention it... did you see the comment in path.cc, line 3112ff? > > There's a good chance that Windows shortcuts are not capable of long path > > names. I didn't test it so far, but it would be certainly better for

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Brian Dessent
Corinna Vinschen wrote: > Now that you mention it... did you see the comment in path.cc, line 3112ff? > There's a good chance that Windows shortcuts are not capable of long path > names. I didn't test it so far, but it would be certainly better for > readlink to use the POSIX path in the symlink

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Corinna Vinschen
On Mar 9 03:32, Brian Dessent wrote: > Corinna Vinschen wrote: > > > > > I'm wondering if you would like to tweak the readlink functions, too. > > > > Cygwin shortcuts can now have the path name appended to the actual > > > > shortcut data. This hack was necessary to support pathnames longer tha

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Brian Dessent
Corinna Vinschen wrote: > > > I'm wondering if you would like to tweak the readlink functions, too. > > > Cygwin shortcuts can now have the path name appended to the actual > > > shortcut data. This hack was necessary to support pathnames longer than > > > 2000 chars. See the comment and code in

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Corinna Vinschen
On Mar 9 01:40, Brian Dessent wrote: > Corinna Vinschen wrote: > > > Given that Cygwin changes to support long path names, I don't really > > like to see new code still using MAX_PATH and Win32 Ansi functions > > in the utils dir. > > Regardless of this patch, path.cc:rel_vconcat() currently use

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Brian Dessent
Corinna Vinschen wrote: > Given that Cygwin changes to support long path names, I don't really > like to see new code still using MAX_PATH and Win32 Ansi functions > in the utils dir. Regardless of this patch, path.cc:rel_vconcat() currently uses GetCurrentDirectory() to resolve relative paths.

Re: [patch] cygcheck.cc update for cygpath()

2008-03-09 Thread Corinna Vinschen
Hi Brian, Thanks for your patch. I have a few nits, sorry. On Mar 8 20:13, Brian Dessent wrote: > Index: cygcheck.cc > === > RCS file: /cvs/src/src/winsup/utils/cygcheck.cc,v > retrieving revision 1.97 > diff -u -p -r1.97 cygcheck.

Re: [patch] utils/path.cc fixes and testsuite

2008-03-09 Thread Corinna Vinschen
On Mar 9 00:55, Brian Dessent wrote: > Corinna Vinschen wrote: > > > Doesn't that install testsuite.exe at `make install' time? > > Ack, how about the attached? Fine with me. Thanks. Corinna

Re: [patch] utils/path.cc fixes and testsuite

2008-03-09 Thread Brian Dessent
Corinna Vinschen wrote: > Doesn't that install testsuite.exe at `make install' time? Ack, how about the attached? Brian2008-03-09 Brian Dessent <[EMAIL PROTECTED]> * Makefile.in (install): Don't install the testsuite. Index: Makefile.in ===

Re: [patch] utils/path.cc fixes and testsuite

2008-03-09 Thread Corinna Vinschen
On Mar 8 22:24, Christopher Faylor wrote: > On Sat, Mar 08, 2008 at 07:10:03PM -0800, Brian Dessent wrote: > >Index: Makefile.in > >=== > >RCS file: /cvs/src/src/winsup/utils/Makefile.in,v > >retrieving revision 1.69 > >diff -u -p -r1