Re: stdin pipe rename in 3.2.0

2021-03-20 Thread Takashi Yano via Cygwin
On Fri, 19 Mar 2021 13:58:40 +0100 Corinna Vinschen wrote: > > extern "C" long > > _get_osfhandle (int fd) > > { > > long res; > > > > cygheap_fdget cfd (fd); > > if (cfd >= 0) > > { > > if (fd == 1 || fd == 2) > > res = (long) cfd->get_output_handle_cyg (); > > else

Re: stdin pipe rename in 3.2.0

2021-03-19 Thread Corinna Vinschen via Cygwin
On Mar 19 21:05, Takashi Yano via Cygwin wrote: > On Fri, 19 Mar 2021 19:08:07 +0900 > Takashi Yano wrote: > > Corinna, is it possble to apply the patch for 3.2.0 release? That's what release testing is for :) > By the way, duaring testing https://github.com/k-takata/ptycheck, > I noticed _get_os

Re: stdin pipe rename in 3.2.0

2021-03-19 Thread Takashi Yano via Cygwin
On Fri, 19 Mar 2021 19:08:07 +0900 Takashi Yano wrote: > Corinna, is it possble to apply the patch for 3.2.0 release? By the way, duaring testing https://github.com/k-takata/ptycheck, I noticed _get_osfhandle() does not work properly for stdout and stderr. Shouldn't this extern "C" long _get_osfh

Re: stdin pipe rename in 3.2.0

2021-03-19 Thread Brian Inglis
On 2021-03-19 01:53, Christoph Reiter via Cygwin wrote: On Fri, Mar 19, 2021 at 4:47 AM Brian Inglis wrote: On 2021-03-18 14:28, Christoph Reiter via Cygwin wrote: If these are being renamed should they not now use neutral terminology based on terms such as primary and secondary, and the primary

Re: stdin pipe rename in 3.2.0

2021-03-19 Thread Christoph Reiter via Cygwin
On Fri, Mar 19, 2021 at 11:09 AM Takashi Yano via Cygwin wrote: > > On Thu, 18 Mar 2021 21:28:40 +0100 > Christoph Reiter wrote: > > I noticed that the stdin pipe was renamed from > > > > "\msys-dd50a72ab4668b33-pty1-from-master" to > > "\msys-dd50a72ab4668b33-pty0-to-slave" in > > https://cygwin.

Re: stdin pipe rename in 3.2.0

2021-03-19 Thread Takashi Yano via Cygwin
On Fri, 19 Mar 2021 19:08:07 +0900 Takashi Yano wrote: > This is not only consistent but also very confusing. I mean "This is not only inconsistent but ..." -- Takashi Yano -- Problem reports: https://cygwin.com/problems.html FAQ: https://cygwin.com/faq/ Documentation:

Re: stdin pipe rename in 3.2.0

2021-03-19 Thread Takashi Yano via Cygwin
On Thu, 18 Mar 2021 21:28:40 +0100 Christoph Reiter wrote: > I noticed that the stdin pipe was renamed from > > "\msys-dd50a72ab4668b33-pty1-from-master" to > "\msys-dd50a72ab4668b33-pty0-to-slave" in > https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=bb42852062073439 Actually, this is not

Re: stdin pipe rename in 3.2.0

2021-03-19 Thread Christoph Reiter via Cygwin
On Fri, Mar 19, 2021 at 4:47 AM Brian Inglis wrote: > > On 2021-03-18 14:28, Christoph Reiter via Cygwin wrote: > If these are being renamed should they not now use neutral terminology based > on > terms such as primary and secondary, and the primary/default repo branches on > a > term such as m

Re: stdin pipe rename in 3.2.0

2021-03-18 Thread Brian Inglis
On 2021-03-18 14:28, Christoph Reiter via Cygwin wrote: I noticed that the stdin pipe was renamed from "\msys-dd50a72ab4668b33-pty1-from-master" to "\msys-dd50a72ab4668b33-pty0-to-slave" in https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=bb42852062073439 This trips up https://github.com/k-

stdin pipe rename in 3.2.0

2021-03-18 Thread Christoph Reiter via Cygwin
Hey, I noticed that the stdin pipe was renamed from "\msys-dd50a72ab4668b33-pty1-from-master" to "\msys-dd50a72ab4668b33-pty0-to-slave" in https://cygwin.com/git/?p=newlib-cygwin.git;a=commit;h=bb42852062073439 This trips up https://github.com/k-takata/ptycheck to detect the cygpty which is used