Re: python-cython C++ support patch

2021-01-31 Thread Masamichi Hosoda
>> python38-cython-0.29.21-3 works fine with following test code. >> >> ```hello.pyx >> print('Hello World!') >> ``` >> >> ```setup.py >> from distutils.core import setup >> from Cython.Build import cythonize >> >> setup( >> ext_modules=cythonize( >> "hello.pyx", >> langua

Re: python-cython C++ support patch

2021-01-30 Thread Marco Atzeri via Cygwin
On 31.01.2021 04:53, Masamichi Hosoda wrote: python38-cython-0.29.21-3 works fine with following test code. ```hello.pyx print('Hello World!') ``` ```setup.py from distutils.core import setup from Cython.Build import cythonize setup( ext_modules=cythonize( "hello.pyx",

Re: python-cython C++ support patch

2021-01-30 Thread Masamichi Hosoda
>> PyMODINIT_FUNC unfortunately dos not work and my changes try >> to overcome it, see similar on >> >> https://sourceware.org/pipermail/cygwin/2021-January/247211.html >> >> but your portion is for additional C++ case >> than I am adding in asimilar way >> >> Regards >> Marco > > a test package

Re: python-cython C++ support patch

2021-01-30 Thread Marco Atzeri via Cygwin
On 30.01.2021 14:58, Marco Atzeri wrote: PyMODINIT_FUNC unfortunately dos not work and my changes try to overcome it, see similar on https://sourceware.org/pipermail/cygwin/2021-January/247211.html but your portion is for additional C++ case than I am adding in asimilar way Regards Marco a

Re: python-cython C++ support patch

2021-01-30 Thread Marco Atzeri via Cygwin
On 30.01.2021 14:28, Masamichi Hosoda wrote: have you considered that you just need to define CYTHON_NO_PYINIT_EXPORT ? the portion of the code below your change has already the ifdef __cplusplus semantic Have you proposed it upstream ? It does not seem a change restricted to Cygwin Any way I

Re: python-cython C++ support patch

2021-01-30 Thread Masamichi Hosoda
> have you considered that you just need to define > CYTHON_NO_PYINIT_EXPORT ? > > the portion of the code below your change has already the > ifdef __cplusplus semantic > > Have you proposed it upstream ? It does not seem > a change restricted to Cygwin > > Any way I see no "wrongness" to add it o

Re: python-cython C++ support patch

2021-01-29 Thread Marco Atzeri via Cygwin
On 29.01.2021 15:18, Marco Atzeri wrote: On 29.01.2021 11:31, Masamichi Hosoda wrote: Hi, I've found that modules built by python-cython with C++ could not be loaded. If I understand correctly, the following patch fixes it. Would you like to apply this patch to the package? ``` --- a/Cython-

Re: python-cython C++ support patch

2021-01-29 Thread Marco Atzeri via Cygwin
On 29.01.2021 11:31, Masamichi Hosoda wrote: Hi, I've found that modules built by python-cython with C++ could not be loaded. If I understand correctly, the following patch fixes it. Would you like to apply this patch to the package? ``` --- a/Cython-0.29.21/Cython/Utility/ModuleSetupCode.c +++

python-cython C++ support patch

2021-01-29 Thread Masamichi Hosoda
Hi, I've found that modules built by python-cython with C++ could not be loaded. If I understand correctly, the following patch fixes it. Would you like to apply this patch to the package? ``` --- a/Cython-0.29.21/Cython/Utility/ModuleSetupCode.c +++ b/Cython-0.29.21/Cython/Utility/ModuleSetupCod