Re: Broken autoconf mmap test

2011-03-23 Thread Corinna Vinschen
On Mar 23 11:51, Eric Blake wrote: > On 03/23/2011 11:46 AM, Eric Blake wrote: > > On 03/23/2011 11:40 AM, Ken Brown wrote: > >>> Usually it shouldn't. While you can write into a mmaped area beyond > >>> EOF up to the end of the last page, it doesn't make a lot of sense. > >>> The data will never

Re: Broken autoconf mmap test

2011-03-23 Thread Eric Blake
On 03/23/2011 11:46 AM, Eric Blake wrote: > On 03/23/2011 11:40 AM, Ken Brown wrote: >>> Usually it shouldn't. While you can write into a mmaped area beyond >>> EOF up to the end of the last page, it doesn't make a lot of sense. >>> The data will never show up in the mapped file. Hmm, rereading P

Re: Broken autoconf mmap test

2011-03-23 Thread Eric Blake
On 03/23/2011 11:40 AM, Ken Brown wrote: >> Usually it shouldn't. While you can write into a mmaped area beyond >> EOF up to the end of the last page, it doesn't make a lot of sense. >> The data will never show up in the mapped file. >> >> I have no idea if there are applications out there which r

Re: Broken autoconf mmap test

2011-03-23 Thread Ken Brown
On 3/23/2011 11:44 AM, Corinna Vinschen wrote: On Mar 23 10:08, Ken Brown wrote: On 3/23/2011 9:26 AM, Corinna Vinschen wrote: Btw., I just experimented with another flag which has not been exposed to the Win32 API, and which is not officially documented. It's called AT_EXTENDABLE_FILE and all

Re: Broken autoconf mmap test

2011-03-23 Thread Corinna Vinschen
On Mar 23 10:08, Ken Brown wrote: > On 3/23/2011 9:26 AM, Corinna Vinschen wrote: > >Btw., I just experimented with another flag which has not been exposed > >to the Win32 API, and which is not officially documented. It's called > >AT_EXTENDABLE_FILE and allows to specify a view which is bigger th

Re: Broken autoconf mmap test

2011-03-23 Thread Ken Brown
On 3/23/2011 9:26 AM, Corinna Vinschen wrote: On Mar 23 07:08, Ken Brown wrote: On 3/23/2011 5:19 AM, Corinna Vinschen wrote: On Mar 22 17:53, Ken Brown wrote: In case it's relevant, my system is 64-bit Windows 7, with the most recent cygwin snapshot: It is relevant, but it has nothing to do

Re: Broken autoconf mmap test

2011-03-23 Thread Corinna Vinschen
On Mar 23 07:08, Ken Brown wrote: > On 3/23/2011 5:19 AM, Corinna Vinschen wrote: > >On Mar 22 17:53, Ken Brown wrote: > >>In case it's relevant, my system is 64-bit Windows 7, with the most > >>recent cygwin snapshot: > > > >It is relevant, but it has nothing to do with Windows 7. Actually, the >

Re: Broken autoconf mmap test

2011-03-23 Thread Ken Brown
On 3/23/2011 5:19 AM, Corinna Vinschen wrote: On Mar 22 17:53, Ken Brown wrote: On 3/22/2011 4:59 PM, Eric Blake wrote: On 03/20/2011 02:51 PM, Ken Brown wrote: What's the status of the broken autoconf mmap test, which always fails on Cygwin even though Cygwin has a working mmap? Autoconf 2.

Re: Broken autoconf mmap test

2011-03-23 Thread Corinna Vinschen
On Mar 22 17:53, Ken Brown wrote: > On 3/22/2011 4:59 PM, Eric Blake wrote: > >On 03/20/2011 02:51 PM, Ken Brown wrote: > >>What's the status of the broken autoconf mmap test, which always fails > >>on Cygwin even though Cygwin has a working mmap? > > > >Autoconf 2.65 and newer do not have the bug.

Re: Broken autoconf mmap test

2011-03-22 Thread Ken Brown
On 3/22/2011 4:59 PM, Eric Blake wrote: On 03/20/2011 02:51 PM, Ken Brown wrote: What's the status of the broken autoconf mmap test, which always fails on Cygwin even though Cygwin has a working mmap? Autoconf 2.65 and newer do not have the bug. But packages still exist where configure was ge

Re: Broken autoconf mmap test

2011-03-22 Thread Eric Blake
On 03/20/2011 02:51 PM, Ken Brown wrote: > What's the status of the broken autoconf mmap test, which always fails > on Cygwin even though Cygwin has a working mmap? Autoconf 2.65 and newer do not have the bug. But packages still exist where configure was generated with < 2.65, so these packages s

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-10 Thread Corinna Vinschen
On Nov 9 21:14, Eric Blake wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > According to Corinna Vinschen on 11/9/2009 7:05 AM: > > This part of the testcase > > > > data2 = (char *) malloc (2 * pagesize); > > if (!data2) > > return 1; > > data2 += (pagesize - ((long int) d

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 [please limit replies about the patch itself to autoconf-patches] According to Corinna Vinschen on 11/9/2009 7:05 AM: > This part of the testcase > > data2 = (char *) malloc (2 * pagesize); > if (!data2) > return 1; > data2 += (pagesize - (

Re: Broken autoconf mmap test

2009-11-09 Thread Charles Wilson
Corinna Vinschen wrote: > I had hoped that you, as the autoconf maintainer, would put this > upstream... Well, I would have done so...but you guys beat me to it. I go off-net for a day or so, and lookit what happens...I think I need to go off-net more often! -- Chuck -- Problem reports: h

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 11/9/2009 7:05 AM: > This part of the testcase > > data2 = (char *) malloc (2 * pagesize); > if (!data2) > return 1; > data2 += (pagesize - ((long int) data2 & (pagesize - 1))) & (pagesize - 1); > if (data2

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Corinna Vinschen
On Nov 9 05:50, Eric Blake wrote: > According to Corinna Vinschen on 11/9/2009 4:59 AM: > > MAP_FIXED > > [...] > > If the specified address cannot be used, mmap() will fail. Because > > requiring a fixed address for a mapping is less portable, the use of > > this option is discouraged. >

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Eric Blake
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 According to Corinna Vinschen on 11/9/2009 4:59 AM: >>> I just found that the latest autoconf *still* has this broken test >>> for mmap, which basically calls >>> >>> data2 = malloc (size); >>> mmap(data2, ...); >>> >>> Why has this test never been

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-09 Thread Corinna Vinschen
On Nov 8 14:07, Charles Wilson wrote: > Corinna Vinschen wrote: > > On Nov 8 14:56, Corinna Vinschen wrote: > >> Btw., the check for mmap in grep's configure file is broken. It tries > >> to mmap to a fixed address formerly allocated via malloc(). This doesn't > >> work on Windows. An autoconf

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-08 Thread Charles Wilson
Corinna Vinschen wrote: > On Nov 8 14:56, Corinna Vinschen wrote: >> Btw., the check for mmap in grep's configure file is broken. It tries >> to mmap to a fixed address formerly allocated via malloc(). This doesn't >> work on Windows. An autoconf run with a newer version of autoconf would >> be

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-08 Thread Christopher Faylor
On Sun, Nov 08, 2009 at 10:51:56AM -0500, Ralph Hempel wrote: >Corinna Vinschen wrote: >> On Nov 8 14:56, Corinna Vinschen wrote: >>> Btw., the check for mmap in grep's configure file is broken. It tries >>> to mmap to a fixed address formerly allocated via malloc(). This doesn't >>> work on Win

Re: Broken autoconf mmap test (was Re: 1.7] BUG - GREP slows to a crawl with large number of matches on a single file)

2009-11-08 Thread Ralph Hempel
Corinna Vinschen wrote: On Nov 8 14:56, Corinna Vinschen wrote: Btw., the check for mmap in grep's configure file is broken. It tries to mmap to a fixed address formerly allocated via malloc(). This doesn't work on Windows. An autoconf run with a newer version of autoconf would be nice. I