RE: Reformatting C/C++/Java code (RE: proposed sync() patch)

2004-04-15 Thread Hannu E K Nevalainen
> From: Robert Collins > On Thu, 2004-04-15 at 04:29, Hannu E K Nevalainen wrote: > > Assuming you do not use strange formatting/style - the > > output of indent will be perfectly acceptable, I presume. > > indent breaks nastily on C++. - it appears to work, but actually gets a > number of things

Re: Reformatting C/C++/Java code (RE: proposed sync() patch)

2004-04-14 Thread Robert Collins
On Thu, 2004-04-15 at 04:29, Hannu E K Nevalainen wrote: > Assuming you do not use strange formatting/style - the > output of indent will be perfectly acceptable, I presume. indent breaks nastily on C++. - it appears to work, but actually gets a number of things wrong. Just FYI. Rob -- GPG key

Reformatting C/C++/Java code (RE: proposed sync() patch)

2004-04-14 Thread Hannu E K Nevalainen
> From: Corinna Vinschen > On Apr 14 11:14, Dave Korn wrote: > > and GNU coding style would be > > > > +static int > > +sync_drive (char drive) > > > > which is probably the more appropriate here. > > GNU coding style is what we're trying to follow. > > Corinna i.e: $ indent -gnu read more

Re: proposed sync() patch

2004-04-14 Thread Corinna Vinschen
On Apr 14 11:14, Dave Korn wrote: > and GNU coding style would be > > +static int > +sync_drive (char drive) > > which is probably the more appropriate here. GNU coding style is what we're trying to follow. Corinna -- Corinna Vinschen Please, send mails regarding Cygwin to C

RE: proposed sync() patch

2004-04-14 Thread Dave Korn
> -Original Message- > From: cygwin-owner On Behalf Of Dmitry Karasik > Sent: 13 April 2004 23:05 > ChangeLog: > > 2004-13-04 Dmitry Karasik <[EMAIL PROTECTED]> > > * syscalls.cc: Implement sync() for letter-mapped drives Just a couple of style suggestions for your consideratio

Re: proposed sync() patch

2004-04-14 Thread Corinna Vinschen
This patch isn't a trivial patch so it requires a copyright assignment. See http://cygwin/com/contrib.html for details. Corinna P.S.: I'm still not convinced, though, that it's actually necessary to implement anything in sync. Also, why only drives with drive letters? What about drives which are