Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Christopher Faylor
On Tue, Apr 27, 2010 at 08:20:00AM -0600, Eric Blake wrote: >On 04/27/2010 08:06 AM, Corinna Vinschen wrote: >>> And while we're touching the file, we probably want to do similar >>> treatment for struct siginfo_t: si_tid, si_overrun, si_sigval, si_value, >>> si_status, si_utime, si_stime, and si_a

Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Eric Blake
On 04/27/2010 08:06 AM, Corinna Vinschen wrote: >> And while we're touching the file, we probably want to do similar >> treatment for struct siginfo_t: si_tid, si_overrun, si_sigval, si_value, >> si_status, si_utime, si_stime, and si_addr. > > Does "we" mean you're going to provide a patch? Yes.

Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Corinna Vinschen
On Apr 27 07:58, Eric Blake wrote: > On 04/27/2010 03:05 AM, Corinna Vinschen wrote: > > Like this? We are already using analog definitions in the socket header > > files. > > Yes, that looks right. > > > > > Index: include/cygwin/signal.h > > ===

Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Eric Blake
On 04/27/2010 03:05 AM, Corinna Vinschen wrote: > Like this? We are already using analog definitions in the socket header > files. Yes, that looks right. > > Index: include/cygwin/signal.h > === > RCS file: /cvs/src/src/winsup/cygw

Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-27 Thread Corinna Vinschen
On Apr 26 19:54, Dave Korn wrote: > On 26/04/2010 17:45, Eric Blake wrote: > > [this was originally raised on the libvirt list] > > > > On 04/25/2010 05:32 AM, Matthias Bolte wrote: > >> +struct sigaction action_stop; > >> > >> -struct sigaction action_stop = { > >> -.sa_handler

Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Dave Korn
On 26/04/2010 17:45, Eric Blake wrote: > [this was originally raised on the libvirt list] > > On 04/25/2010 05:32 AM, Matthias Bolte wrote: >> +struct sigaction action_stop; >> >> -struct sigaction action_stop = { >> -.sa_handler = stop >> -}; >> +memset(&action_stop, 0,

Re: Cygwin's GCC doesn't like this .sa_handler initialization for some reason

2010-04-26 Thread Eric Blake
[this was originally raised on the libvirt list] On 04/25/2010 05:32 AM, Matthias Bolte wrote: > +struct sigaction action_stop; > > -struct sigaction action_stop = { > -.sa_handler = stop > -}; > +memset(&action_stop, 0, sizeof action_stop); > + > +action_stop.sa_hand