Re: [PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-17 Thread Marc Hoersken via Cygwin
Hi Corinna, Am 17.07.2020 um 21:21 schrieb Corinna Vinschen: I don't agree here. The sole purpose for connect_errorcode is to set SOL_SOCKET/SO_ERROR in case a caller requests FD_CONNECT and FD_CONNECT is available. After being set once, SOL_SOCKET/SO_ERROR should not be rewritten, given the d

Re: [PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-17 Thread Marc Hoersken via Cygwin
Hi Corinna, Am 16.07.2020 um 11:25 schrieb Corinna Vinschen: Thanks for the patch. I pushed it. thanks for pushing it already. Please excuse my delayed response, family live kept me busy. But then I got second thoughts in terms of how to fix the issue. Yes, I also got second thoughts

[PATCH] Fix poll/select signal socket as write ready on connect failure

2020-07-15 Thread Marc Hoersken via Cygwin
Hello everyone, I identified an issue related to the way the events FD_CONNECT and FD_CLOSE returned by WSAEnumNetworkEvents are currently handled in winsup/cygwin/fhandler_socket_inet.cc. It seems like the code does not handle the fact that those events are returned only once for a socket a