Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-09 Thread Bruce Evans
On Tue, 8 Aug 2006, Yar Tikhiy wrote: On Mon, Aug 07, 2006 at 01:59:30PM +1000, Bruce Evans wrote: On Sun, 6 Aug 2006, Dag-Erling [iso-8859-1] Sm?rgrav wrote: MAXPATHLEN should be spelled PATH_MAX. Actually, MAXPATHLEN is better since it is honestly unportable. It works ... Just looked wha

Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-08 Thread Yar Tikhiy
On Mon, Aug 07, 2006 at 01:59:30PM +1000, Bruce Evans wrote: > On Sun, 6 Aug 2006, Dag-Erling [iso-8859-1] SmЬrgrav wrote: > > >Marcel Moolenaar <[EMAIL PROTECTED]> writes: > >> Log: > >> Fix (static) buffer overflow bug. The dest buffer is of size MAXPATHLEN, > >> so dest[MAXPATHLEN] falls out

Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-06 Thread Bruce Evans
On Sun, 6 Aug 2006, Dag-Erling [iso-8859-1] Sm?rgrav wrote: Marcel Moolenaar <[EMAIL PROTECTED]> writes: Log: Fix (static) buffer overflow bug. The dest buffer is of size MAXPATHLEN, so dest[MAXPATHLEN] falls outside the buffer. This bug corrupted arenas[0] defined in libc's malloc.c o

Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-06 Thread Dag-Erling Smørgrav
Marcel Moolenaar <[EMAIL PROTECTED]> writes: > Log: > Fix (static) buffer overflow bug. The dest buffer is of size MAXPATHLEN, > so dest[MAXPATHLEN] falls outside the buffer. This bug corrupted > arenas[0] defined in libc's malloc.c on PowerPC when kldxref is shared, > which triggered a

cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-05 Thread Warner Losh
imp 2006-08-05 18:22:11 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Use safe strlcpy rather than unsafe strncpy. After marcel's last fix, there was still one overflow possible. strlcpy is faster anyway because it doesn't unexpectedly z

Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-04 Thread Marcel Moolenaar
On Aug 4, 2006, at 4:27 PM, Maxim Sobolev wrote: Marcel Moolenaar wrote: On Aug 4, 2006, at 4:14 PM, Maxim Sobolev wrote: Thanks! I saw this crash as well, but did not have a gdb working to inspect the core file at that time. I have a native gdb 6.5 that allowed me to work on a live process

Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-04 Thread Maxim Sobolev
Marcel Moolenaar wrote: On Aug 4, 2006, at 4:14 PM, Maxim Sobolev wrote: Thanks! I saw this crash as well, but did not have a gdb working to inspect the core file at that time. I have a native gdb 6.5 that allowed me to work on a live process. Thanks in a big part to you, I might add :-) M

Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-04 Thread Marcel Moolenaar
On Aug 4, 2006, at 4:14 PM, Maxim Sobolev wrote: Thanks! I saw this crash as well, but did not have a gdb working to inspect the core file at that time. I have a native gdb 6.5 that allowed me to work on a live process. Thanks in a big part to you, I might add :-) -- Marcel Moolenaar

Re: cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-04 Thread Maxim Sobolev
Thanks! I saw this crash as well, but did not have a gdb working to inspect the core file at that time. -Maxim Marcel Moolenaar wrote: marcel 2006-08-04 21:28:43 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Fix (static) buffer overflow bug

cvs commit: src/usr.sbin/kldxref kldxref.c

2006-08-04 Thread Marcel Moolenaar
marcel 2006-08-04 21:28:43 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Fix (static) buffer overflow bug. The dest buffer is of size MAXPATHLEN, so dest[MAXPATHLEN] falls outside the buffer. This bug corrupted arenas[0] defined in libc's ma

cvs commit: src/usr.sbin/kldxref kldxref.c

2006-07-29 Thread Marcel Moolenaar
marcel 2006-07-29 19:39:04 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Change maketempfile() to return a FILE* so as to eliminate the fopen() that immediately follows the only call to it. maketempfile() uses mkstemp(), so the temporary file

cvs commit: src/usr.sbin/kldxref kldxref.c

2005-11-11 Thread Ruslan Ermilov
ru 2005-11-11 08:13:18 UTC FreeBSD src repository Modified files: usr.sbin/kldxref kldxref.c Log: Skip .symbols files. Revision ChangesPath 1.11 +4 -1 src/usr.sbin/kldxref/kldxref.c ___ cvs-all@freebsd.org