cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c

2007-04-04 Thread Maksim Yevmenkin
emax2007-04-04 22:26:42 UTC FreeBSD src repository Modified files:(Branch: RELENG_5) sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c Log: MFC: Try to silence Coverity by adding (void) in front of function call. Also add a comment, explaining why return value is no

cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c

2007-04-04 Thread Maksim Yevmenkin
emax2007-04-04 22:21:09 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c Log: MFC: Try to silence Coverity by adding (void) in front of function call. Also add a comment, explaining why return value is no

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-04-02 Thread Alfred Perlstein
* John Baldwin <[EMAIL PROTECTED]> [070402 05:30] wrote: > > There are several cases where Coverity gets something wrong (e.g. the > > use of TAILQ). I did mark those as invalid in Coverity (until either > > we get a new version of Coverity which understands this, or someone > > writes a mode

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-04-02 Thread Coleman Kane
On 4/2/07, Wes Peters <[EMAIL PROTECTED]> wrote: On Apr 2, 2007, at 5:21 AM, John Baldwin wrote: > On Monday 02 April 2007 03:32:38 am Alexander Leidinger wrote: >> Quoting Greg 'groggy' Lehey <[EMAIL PROTECTED]> (from Mon, 2 Apr 2007 >> 13:56:00 +0930): >> >>> On Thursday, 29 March 2007 at 13

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-04-02 Thread Wes Peters
On Apr 2, 2007, at 5:21 AM, John Baldwin wrote: On Monday 02 April 2007 03:32:38 am Alexander Leidinger wrote: Quoting Greg 'groggy' Lehey <[EMAIL PROTECTED]> (from Mon, 2 Apr 2007 13:56:00 +0930): On Thursday, 29 March 2007 at 13:36:31 +0200, Alexander Leidinger wrote: Quoting Andrew Thomp

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-04-02 Thread John Baldwin
On Monday 02 April 2007 03:32:38 am Alexander Leidinger wrote: > Quoting Greg 'groggy' Lehey <[EMAIL PROTECTED]> (from Mon, 2 Apr 2007 > 13:56:00 +0930): > > > On Thursday, 29 March 2007 at 13:36:31 +0200, Alexander Leidinger wrote: > >> Quoting Andrew Thompson <[EMAIL PROTECTED]> (from Thu, 29

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-04-02 Thread Alexander Leidinger
Quoting Greg 'groggy' Lehey <[EMAIL PROTECTED]> (from Mon, 2 Apr 2007 13:56:00 +0930): On Thursday, 29 March 2007 at 13:36:31 +0200, Alexander Leidinger wrote: Quoting Andrew Thompson <[EMAIL PROTECTED]> (from Thu, 29 Mar 2007 13:52:12 +1200): On Thu, Mar 29, 2007 at 10:58:34AM +0930, Greg

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-04-01 Thread Greg 'groggy' Lehey
On Thursday, 29 March 2007 at 13:36:31 +0200, Alexander Leidinger wrote: > Quoting Andrew Thompson <[EMAIL PROTECTED]> (from Thu, 29 Mar 2007 > 13:52:12 +1200): > >> On Thu, Mar 29, 2007 at 10:58:34AM +0930, Greg 'groggy' Lehey wrote: >>> On Wednesday, 28 March 2007 at 21:25:56 +, Maksim Yevmen

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-03-29 Thread Alexander Leidinger
Quoting Andrew Thompson <[EMAIL PROTECTED]> (from Thu, 29 Mar 2007 13:52:12 +1200): On Thu, Mar 29, 2007 at 10:58:34AM +0930, Greg 'groggy' Lehey wrote: On Wednesday, 28 March 2007 at 21:25:56 +, Maksim Yevmenkin wrote: > emax2007-03-28 21:25:56 UTC > > FreeBSD src repository >

Re: Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-03-28 Thread Andrew Thompson
On Thu, Mar 29, 2007 at 10:58:34AM +0930, Greg 'groggy' Lehey wrote: > On Wednesday, 28 March 2007 at 21:25:56 +, Maksim Yevmenkin wrote: > > emax2007-03-28 21:25:56 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c > >

Giving in to Coverity (was: cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c)

2007-03-28 Thread Greg 'groggy' Lehey
On Wednesday, 28 March 2007 at 21:25:56 +, Maksim Yevmenkin wrote: > emax2007-03-28 21:25:56 UTC > > FreeBSD src repository > > Modified files: > sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c > Log: > Try to silence Coverity by adding (void) in front of function call. > Als

cvs commit: src/sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c

2007-03-28 Thread Maksim Yevmenkin
emax2007-03-28 21:25:56 UTC FreeBSD src repository Modified files: sys/netgraph/bluetooth/l2cap ng_l2cap_cmds.c Log: Try to silence Coverity by adding (void) in front of function call. Also add a comment, explaining why return value is not being checked. Requested by: