Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-08 Thread Robert Watson
On Wed, 8 Oct 2008, John Baldwin wrote: In soreceive_dgram, when a 0-length buffer is passed into recv(2) and no data is ready, return 0 rather than blocking or returning EAGAIN. This is consistent with the behavior of soreceive_generic (soreceive) in earlier versions of FreeBSD, and res

Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-08 Thread John Baldwin
On Wednesday 08 October 2008 02:16:45 am Robert Watson wrote: > On Tue, 7 Oct 2008, John Baldwin wrote: > > > On Tuesday 07 October 2008 04:57:55 pm Robert Watson wrote: > >> rwatson 2008-10-07 20:57:55 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/kern

Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-07 Thread Robert Watson
On Tue, 7 Oct 2008, John Baldwin wrote: On Tuesday 07 October 2008 04:57:55 pm Robert Watson wrote: rwatson 2008-10-07 20:57:55 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 183675 on 2008-10-07 20:57:55Z by rwatson In soreceive_

Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-07 Thread John Baldwin
On Tuesday 07 October 2008 04:57:55 pm Robert Watson wrote: > rwatson 2008-10-07 20:57:55 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > SVN rev 183675 on 2008-10-07 20:57:55Z by rwatson > > In soreceive_dgram, when a 0-lengt

cvs commit: src/sys/kern uipc_socket.c

2008-10-07 Thread Robert Watson
rwatson 2008-10-07 20:57:55 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 183675 on 2008-10-07 20:57:55Z by rwatson In soreceive_dgram, when a 0-length buffer is passed into recv(2) and no data is ready, return 0 rather than blo

cvs commit: src/sys/kern uipc_socket.c

2008-10-07 Thread Robert Watson
rwatson 2008-10-07 09:57:03 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 183664 on 2008-10-07 09:57:03Z by rwatson Remove temporary debugging KASSERT's introduced to detect protocols improperly invoking sosend(), soreceive(), a

cvs commit: src/sys/kern uipc_socket.c

2008-10-05 Thread Robert Watson
rwatson 2008-10-05 21:05:20 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern uipc_socket.c Log: SVN rev 183633 on 2008-10-05 21:05:20Z by rwatson Merge r183512 from head to stable/7: Various cleanups for soreceive_dgram():

cvs commit: src/sys/kern uipc_socket.c

2008-10-03 Thread John Baldwin
jhb 2008-10-03 21:33:58 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern uipc_socket.c Log: SVN rev 183575 on 2008-10-03 21:33:58Z by jhb MFC: Update the function name in several assertions in soreceive_dgram(). Approved by:

cvs commit: src/sys/kern uipc_socket.c

2008-10-01 Thread John Baldwin
jhb 2008-10-01 19:14:05 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 183518 on 2008-10-01 19:14:05Z by jhb Wait until after dropping the receive socket buffer lock to allocate space to store the socket address stored in the

cvs commit: src/sys/kern uipc_socket.c

2008-10-01 Thread Robert Watson
rwatson 2008-10-01 13:26:52 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 183512 on 2008-10-01 13:26:52Z by rwatson Various cleanups for soreceive_dgram(): - Update or remove comments that were left over from the original

cvs commit: src/sys/kern uipc_socket.c

2008-09-30 Thread John Baldwin
jhb 2008-09-30 18:44:26 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 183503 on 2008-09-30 18:44:26Z by jhb Update the function name in several assertions in soreceive_dgram(). Approved by:rwatson MFC after: 3

cvs commit: src/sys/kern uipc_socket.c

2008-09-02 Thread Robert Watson
rwatson 2008-09-02 16:55:21 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 182682 on 2008-09-02 16:55:21Z by rwatson Remove XXXRW in soreceive_dgram that proves unnecessary. Remove unused orig_resid variable in soreceive_dgram

cvs commit: src/sys/kern uipc_socket.c src/sys/netinet in_pcb.c src/sys/sys socket.h

2008-07-30 Thread Kip Macy
kmacy 2008-07-31 05:48:51 UTC FreeBSD src repository Modified files:(Branch: RELENG_7) sys/kern uipc_socket.c sys/netinet in_pcb.c sys/sys socket.h Log: SVN rev 181046 on 2008-07-31 05:48:51Z by kmacy MFC accessor functio

cvs commit: src/sys/kern uipc_socket.c src/sys/netinet in_pcb.c src/sys/sys socket.h

2008-07-20 Thread Kip Macy
kmacy 2008-07-21 00:49:34 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/netinet in_pcb.c sys/sys socket.h Log: SVN rev 180641 on 2008-07-21 00:49:34Z by kmacy Add accessor functions for socket fields.

Re: cvs commit: src/sys/kern uipc_socket.c src/sys/netinet udp_usrreq.c src/sys/sys socketvar.h

2008-07-03 Thread Robert Watson
On Thu, 3 Jul 2008, Bjoern A. Zeeb wrote: Add soreceive_dgram(9), an optimized socket receive function for use by datagram-only protocols, such as UDP. This version removes use of sblock(), which is not required due to an inability to interlace data improperly with datagrams, as well as av

Re: cvs commit: src/sys/kern uipc_socket.c src/sys/netinet udp_usrreq.c src/sys/sys socketvar.h

2008-07-03 Thread Bjoern A. Zeeb
On Wed, 2 Jul 2008, Robert Watson wrote: rwatson 2008-07-02 23:23:27 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/netinet udp_usrreq.c sys/sys socketvar.h Log: SVN rev 180198 on 2008-07-02 23:23:27Z by rwatson Add so

cvs commit: src/sys/kern uipc_socket.c

2008-07-02 Thread Robert Watson
rwatson 2008-07-03 06:47:45 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 180211 on 2008-07-03 06:47:45Z by rwatson Update copyright date in light of soreceive_dgram(9). Revision ChangesPath 1.312 +1 -1 src/sy

cvs commit: src/sys/kern uipc_socket.c src/sys/netinet udp_usrreq.c src/sys/sys socketvar.h

2008-07-02 Thread Robert Watson
rwatson 2008-07-02 23:23:27 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/netinet udp_usrreq.c sys/sys socketvar.h Log: SVN rev 180198 on 2008-07-02 23:23:27Z by rwatson Add soreceive_dgram(9), an optimized

Re: cvs commit: src/sys/kern uipc_socket.c src/sys/sys protosw.h socket.h

2008-04-14 Thread Robert Watson
On Mon, 14 Apr 2008, Randall Stewart wrote: Add pru_flush routine so a transport can flush itself during Shutdown MFC after: 1 week I'm not sure this is an MFCable change because: (a) The new function pointer is inserted in the middle of the data protosw data structure, changing

cvs commit: src/sys/kern uipc_socket.c src/sys/sys protosw.h socket.h

2008-04-14 Thread Randall Stewart
rrs 2008-04-14 18:06:04 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/sys protosw.h socket.h Log: Add pru_flush routine so a transport can flush itself during Shutdown MFC after: 1 week Revision Changes

Re: cvs commit: src/sys/kern uipc_socket.c

2007-08-23 Thread Frank Behrens
JINMEI Tatuya <[EMAIL PROTECTED]> wrote on 23 Aug 2007 18:17: > jinmei 2007-08-23 18:17:08 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/kern uipc_socket.c > Log: > MFC: > Fix a kernel panic based on receiving an ICMPv6 Packet

cvs commit: src/sys/kern uipc_socket.c

2007-08-23 Thread JINMEI Tatuya
jinmei 2007-08-23 18:17:08 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern uipc_socket.c Log: MFC: Fix a kernel panic based on receiving an ICMPv6 Packet too Big message. (MFC was planned but has been missed) PR:

cvs commit: src/sys/kern uipc_socket.c

2007-05-08 Thread Pyun YongHyeon
yongari 2007-05-08 12:34:14 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Add missing socket buffer unlock before returning to userland. Reviewed by:rwatson Revision ChangesPath 1.299 +1 -1 src/sys/kern/uipc_socke

cvs commit: src/sys/kern uipc_socket.c

2007-03-22 Thread Gleb Smirnoff
glebius 2007-03-22 13:21:24 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Move the dom_dispose and pru_detach calls in sofree() earlier. Only after calling pru_detach we can be absolutely sure, that we don't have any references to the sock

cvs commit: src/sys/kern uipc_socket.c

2007-03-12 Thread John Baldwin
jhb 2007-03-12 19:27:37 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: - Use m_gethdr(), m_get(), and m_clget() instead of the macros in sosend_copyin(). - Use M_WAITOK instead of M_TRYWAIT in sosend_copyin(). - Don't check for NULL

cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c src/sys/sys socketvar.h

2007-03-12 Thread Ruslan Ermilov
ru 2007-03-12 12:13:53 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern uipc_socket.c uipc_socket2.c sys/sys socketvar.h Log: MFC: Don't block on the socket zone limit during the socket() syscall which can lock up

cvs commit: src/sys/kern uipc_socket.c

2007-02-26 Thread Ruslan Ermilov
ru 2007-02-26 10:45:21 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Don't block on the socket zone limit during the socket() call which can easily lock up a system otherwise; instead, return ENOBUFS as documented in a manpage, thus r

cvs commit: src/sys/kern uipc_socket.c

2007-02-15 Thread Robert Watson
rwatson 2007-02-15 10:11:00 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Rename somaxconn_sysctl() to sysctl_somaxconn() so that I will be able to claim that sofoo() functions all accept a socket as their first argument. Revision Chan

cvs commit: src/sys/kern uipc_socket.c

2007-02-02 Thread Bruce M Simpson
bms 2007-02-03 04:01:22 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern uipc_socket.c Log: MFC: Drop all received data mbufs from a socket's queue if the MT_SONAME mbuf is dropped, to preserve the invariant in the PR_ADDR case.

cvs commit: src/sys/kern uipc_socket.c

2007-02-02 Thread Bruce M Simpson
bms 2007-02-03 03:57:45 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Diff reduction with RELENG_6, style(9): Remove unnecessary brace; && should be on end of line. No functional changes. Revision ChangesPath 1.291 +2 -

cvs commit: src/sys/kern uipc_socket.c src/sys/sys socketvar.h

2007-02-01 Thread Andre Oppermann
andre 2007-02-01 17:53:41 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/sys socketvar.h Log: Generic socket buffer auto sizing support, header defines, flag inheritance. MFC after: 1 month Revision Changes

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread Daniel O'Connor
On Tuesday 23 January 2007 01:29, Andre Oppermann wrote: > > Is there any progress in fixing this bug? > > Just fixed. The regression test passes and I hope KDE too. I just tested it - yes it fixes the problem with unlocking the KDE screensaver. Thanks! -- Daniel O'Connor software and network

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread John Baldwin
On Monday 22 January 2007 10:01, Andre Oppermann wrote: > John Baldwin wrote: > > Also, you've introduced another regression in that if the m_get2m() fails it > > should be returning ENOBUFS and not EFAULT to userland. The comments in > > sosend_*() about 'EFAULT being the only possible error' ar

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread Andre Oppermann
John Baldwin wrote: On Thursday 02 November 2006 12:45, Andre Oppermann wrote: andre 2006-11-02 17:45:28 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Use the improved m_uiotombuf() function instead of home grown sosend_copyin() to do

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread Andre Oppermann
Andrey Chernov wrote: On Fri, Jan 12, 2007 at 12:06:46PM -0500, John Baldwin wrote: On Thursday 02 November 2006 12:45, Andre Oppermann wrote: andre 2006-11-02 17:45:28 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Use the improved m_ui

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-21 Thread Andrey Chernov
On Fri, Jan 12, 2007 at 12:06:46PM -0500, John Baldwin wrote: > On Thursday 02 November 2006 12:45, Andre Oppermann wrote: > > andre 2006-11-02 17:45:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern uipc_socket.c > > Log: > > Use the improv

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-12 Thread John Baldwin
On Thursday 02 November 2006 12:45, Andre Oppermann wrote: > andre 2006-11-02 17:45:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > Use the improved m_uiotombuf() function instead of home grown > sosend_copyin() > to do the

cvs commit: src/sys/kern uipc_socket.c

2006-11-22 Thread Mohan Srinivasan
mohans 2006-11-22 23:54:29 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Fix a race in soclose() where connections could be queued to the listening socket after the pass that cleans those queues. This results in these connections being or

cvs commit: src/sys/kern uipc_socket.c

2006-11-22 Thread Mohan Srinivasan
mohans 2006-11-22 23:06:27 UTC FreeBSD src repository Modified files:(Branch: RELENG_6_2) sys/kern uipc_socket.c Log: Fix a race in soclose() where connections could be queued to the listening socket after the pass that cleans those queues. This results i

cvs commit: src/sys/kern uipc_socket.c

2006-11-22 Thread Mohan Srinivasan
mohans 2006-11-22 22:21:57 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern uipc_socket.c Log: Fix a race in soclose() where connections could be queued to the listening socket after the pass that cleans those queues. This results in

cvs commit: src/sys/kern uipc_socket.c

2006-11-02 Thread Andre Oppermann
andre 2006-11-02 17:45:28 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Use the improved m_uiotombuf() function instead of home grown sosend_copyin() to do the userland to kernel copying in sosend_generic() and sosend_dgram(). sosend_

cvs commit: src/sys/kern uipc_socket.c

2006-09-22 Thread Bruce M Simpson
bms 2006-09-22 15:34:17 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Fix a case where socket I/O atomicity is violated due to not dropping the entire record when a non-data mbuf is removed in the soreceive() path. This only triggers a

cvs commit: src/sys/kern uipc_socket.c

2006-09-12 Thread Pawel Jakub Dawidek
pjd 2006-09-13 06:58:40 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Fix a lock leak in an error case. Reported by:netchild Reviewed by:rwatson Revision ChangesPath 1.282 +1 -1 src/sys/kern/uipc_socket.

cvs commit: src/sys/kern uipc_socket.c

2006-09-10 Thread Andre Oppermann
andre 2006-09-10 17:08:06 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: New sockets created by incoming connections into listen sockets should inherit all settings and options except listen specific options. Add the missing send/recei

cvs commit: src/sys/kern uipc_socket.c

2006-08-18 Thread George V. Neville-Neil
gnn 2006-08-18 14:05:13 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Fix a kernel panic based on receiving an ICMPv6 Packet too Big message. PR: 99779 Submitted by: Jinmei Tatuya Reviewed by:clement, rwatson M

cvs commit: src/sys/kern uipc_socket.c

2006-08-11 Thread Robert Watson
rwatson 2006-08-11 23:03:10 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Before performing a sodealloc() when pru_attach() fails, assert that the socket refcount remains 1, and then drop to 0 before freeing the socket. PR:

cvs commit: src/sys/kern uipc_socket.c

2006-08-02 Thread Robert Watson
rwatson 2006-08-02 18:37:44 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Move destroying kqueue state from above pru_detach to below it in sofree(), as a number of protocols expect to be able to call soisdisconnected() during detach. Tha

cvs commit: src/sys/kern uipc_socket.c

2006-08-01 Thread Robert Watson
rwatson 2006-08-02 00:45:27 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Move updated of 'numopensockets' from bottom of sodealloc() to the top, eliminating a second set of identical mutex operations at the bottom. This allows brief excee

cvs commit: src/sys/kern uipc_socket.c

2006-07-23 Thread Robert Watson
rwatson 2006-07-23 20:36:04 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Update various uipc_socket.c comments, and reformat others. Revision ChangesPath 1.274 +153 -139 src/sys/kern/uipc_socket.c

cvs commit: src/sys/kern uipc_socket.c uipc_usrreq.c src/sys/net raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_usrreq.c src/sys/netgraph ng_socket.c src/sys/netgrap

2006-07-21 Thread Robert Watson
rwatson 2006-07-21 17:11:15 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c uipc_usrreq.c sys/net raw_usrreq.c rtsock.c sys/netatalk ddp_usrreq.c sys/netatm atm_aal5.c atm_usrreq.c sys/netgraph ng

cvs commit: src/sys/kern uipc_socket.c

2006-07-16 Thread Robert Watson
rwatson 2006-07-16 23:09:40 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Change comment on soabort() to more accurately describe how/when soabort() is used. Remove trailing white space. Revision ChangesPath 1.272 +12 -12

cvs commit: src/sys/kern uipc_socket.c

2006-07-11 Thread Robert Watson
rwatson 2006-07-11 21:56:58 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: When pru_attach() fails, call sodealloc() on the socket rather than using sorele() and the full tear-down path. Since protocol state allocation failed, this is not

cvs commit: src/sys/kern uipc_socket.c

2006-06-28 Thread Robert Watson
rwatson 2006-06-28 15:01:08 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern uipc_socket.c Log: Merge uipc_socket.c:1.267 from HEAD to RELENG_6: Rearrange code in soalloc() so that it's less indented by returning early if uma_za

cvs commit: src/sys/kern uipc_socket.c

2006-06-18 Thread Robert Watson
rwatson 2006-06-18 19:02:49 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: When retrieving SO_ERROR via getsockopt(), hold the socket lock around the retrieval and replacement with 0. MFC after: 1 week Revision ChangesPath

cvs commit: src/sys/kern uipc_socket.c

2006-06-17 Thread George V. Neville-Neil
gnn 2006-06-17 17:47:06 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern uipc_socket.c Log: MFC a forgotten fix Make sure that there actually is a next packet before setting nextrecord to that field. PR: 83885 Submitted b

cvs commit: src/sys/kern uipc_socket.c

2006-06-08 Thread Robert Watson
rwatson 2006-06-08 22:33:18 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Rearrange code in soalloc() so that it's less indented by returning early if uma_zalloc() from the socket zone fails. No functional change. MFC after: 1 w

cvs commit: src/sys/kern uipc_socket.c

2006-04-23 Thread Robert Watson
rwatson 2006-04-23 18:15:55 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Assert that sockets passed into soabort() not be SQ_COMP or SQ_INCOMP, since that removal should have been done a layer up. MFC after: 3 months Revision

cvs commit: src/sys/kern uipc_socket.c

2006-04-23 Thread Robert Watson
rwatson 2006-04-23 15:37:24 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Add missing 'not' to SQ_COMP comment. MFC after: 3 months Revision ChangesPath 1.265 +1 -1 src/sys/kern/uipc_socket.c

cvs commit: src/sys/kern uipc_socket.c

2006-04-23 Thread Robert Watson
rwatson 2006-04-23 15:33:38 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Move handling of SQ_COMP exception case in sofree() to the top of the function along with the remainder of the reference checking code. Move comment from body to he

Re: cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_socket.c atm_usrreq.c atm

2006-04-09 Thread Robert Watson
On Sun, 9 Apr 2006, Pawel Jakub Dawidek wrote: +> -static int +> +static void +> ngd_detach(struct socket *so) +> { +> struct ngpcb *const pcbp = sotongpcb(so); +> +> - if (pcbp == NULL) +> - return (EINVAL); +> + KASSERT(pcbp == NULL, ("ngd_detach: pcbp == NULL")); From what I see

Re: cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_socket.c atm_usrreq.c atm

2006-04-09 Thread Pawel Jakub Dawidek
On Sat, Apr 01, 2006 at 03:42:02PM +, Robert Watson wrote: +> rwatson 2006-04-01 15:42:02 UTC +> +> FreeBSD src repository +> +> Modified files: +> sys/kern uipc_socket.c uipc_socket2.c +> uipc_usrreq.c +> sys/net raw_cb.c ra

cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_socket.c atm_usrreq.c atm_var

2006-04-01 Thread Robert Watson
rwatson 2006-04-01 15:42:02 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c sys/net raw_cb.c raw_usrreq.c rtsock.c sys/netatalk ddp_usrreq.c sys/netatm at

cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c src/sys/net raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_proto.c atm_usrreq.c atm_var.h src/sys

2006-04-01 Thread Robert Watson
rwatson 2006-04-01 15:15:05 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c sys/net raw_usrreq.c rtsock.c sys/netatalk ddp_usrreq.c sys/netatm atm_aal5.c

cvs commit: src/sys/kern uipc_socket.c

2006-04-01 Thread Robert Watson
rwatson 2006-04-01 10:45:52 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Assert so->so_pcb is NULL in sodealloc() -- the protocol state should not be present at this point. We will eventually remove this assert because the socket layer s

cvs commit: src/sys/kern uipc_socket.c

2006-04-01 Thread Robert Watson
rwatson 2006-04-01 10:43:02 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Add a somewhat sizable comment documenting the semantics of various kernel socket calls relating to the creation and destruction of sockets. This will eventually fo

cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c src/sys/netinet tcp_syncache.c src/sys/sys socketvar.h

2006-03-15 Thread Robert Watson
rwatson 2006-03-16 07:03:15 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c uipc_socket2.c sys/netinet tcp_syncache.c sys/sys socketvar.h Log: Change soabort() from returning int to returning void, since all consumer

Re: cvs commit: src/sys/kern uipc_socket.c

2006-03-15 Thread Alfred Perlstein
1) apologies for top posting 2) cool, thanks for the explanation, I wasn't aware that this was a cleanup step and was hoping it wasn't another ad-hoc reference counting "fix". This looks good. * Robert Watson <[EMAIL PROTECTED]> [060315 05:48] wrote: > > Socket and PCB reference counting is curr

Re: cvs commit: src/sys/kern uipc_socket.c

2006-03-15 Thread Robert Watson
On Wed, 15 Mar 2006, Alfred Perlstein wrote: Modified files: sys/kern uipc_socket.c Log: As with socket consumer references (so_count), make sofree() return without GC'ing the socket if a strong protocol reference to the socket is present (SS_PROTOREF). This stuff is

Re: cvs commit: src/sys/kern uipc_socket.c

2006-03-15 Thread Alfred Perlstein
* Robert Watson <[EMAIL PROTECTED]> [060315 04:45] wrote: > rwatson 2006-03-15 12:45:35 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > As with socket consumer references (so_count), make sofree() return > without GC'ing the sock

cvs commit: src/sys/kern uipc_socket.c

2006-03-15 Thread Robert Watson
rwatson 2006-03-15 12:45:35 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: As with socket consumer references (so_count), make sofree() return without GC'ing the socket if a strong protocol reference to the socket is present (SS_PROTOREF).

cvs commit: src/sys/kern uipc_socket.c

2006-02-12 Thread Robert Watson
rwatson 2006-02-12 15:00:28 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Improve consistency of return() style. MFC after: 3 days Revision ChangesPath 1.257 +8 -8 src/sys/kern/uipc_socket.c _

cvs commit: src/sys/kern uipc_socket.c

2005-12-28 Thread Paul Saab
ps 2005-12-28 18:05:13 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern uipc_socket.c Log: MFC: rev 1.250 Allow 32bit get/setsockopt with SO_SNDTIMEO or SO_RECVTIMEO to work. Revision ChangesPath 1.242.2.4 +29 -3 s

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Mike Silbersack
On Mon, 5 Dec 2005, Robert Watson wrote: The NFS server could could probably profitably, and fairly easily, be taught how to do zero-copy from the buffer/page cache, btw. Should be able to steal code from sendfile(), although I've not looked in any detail. Possibly also the NFS client. Ro

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Robert Watson
On Mon, 5 Dec 2005, Mike Silbersack wrote: On Mon, 5 Dec 2005, Robert Watson wrote: (3) Enhance m_uiotombuf() so that it can either be trivially wrapped by sosend_copyin(), or replace it. At the very least, this means adding zero-copy support to m_uiotombuf(), but I've not looked at th

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Mike Silbersack
On Mon, 5 Dec 2005, Robert Watson wrote: (3) Enhance m_uiotombuf() so that it can either be trivially wrapped by sosend_copyin(), or replace it. At the very least, this means adding zero-copy support to m_uiotombuf(), but I've not looked at this much. Sounds good, I just wanted to make

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Robert Watson
On Sun, 4 Dec 2005, Mike Silbersack wrote: On Mon, 28 Nov 2005, Robert Watson wrote: Break out functionality in sosend() responsible for building mbuf chains and copying in mbufs from the body of the send logic, creating a new function sosend_copyin(). This changes makes sosend() almost r

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-04 Thread Mike Silbersack
On Mon, 28 Nov 2005, Robert Watson wrote: Break out functionality in sosend() responsible for building mbuf chains and copying in mbufs from the body of the send logic, creating a new function sosend_copyin(). This changes makes sosend() almost readable, and will allow the same logic to be

Foot shooting (was: cvs commit: src/sys/kern uipc_socket.c)

2005-12-04 Thread Greg 'groggy' Lehey
On Wednesday, 30 November 2005 at 9:47:27 +, Robert Watson wrote: > > On Wed, 30 Nov 2005, Dag-Erling Smørgrav wrote: > >> Robert Watson <[EMAIL PROTECTED]> writes: >>> Thanks for fixing this -- I ran this patch in testing for ages, but >>> must have done some "clean up" or other such 99.85% h

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Wilko Bulte
On Wed, Nov 30, 2005 at 09:47:27AM +, Robert Watson wrote.. > > On Wed, 30 Nov 2005, Dag-Erling Smørgrav wrote: > > >Robert Watson <[EMAIL PROTECTED]> writes: > >>Thanks for fixing this -- I ran this patch in testing for ages, but > >>must have done some "clean up" or other such 99.85% harmle

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread John Baldwin
On Wednesday 30 November 2005 04:20 am, Robert Watson wrote: > On Tue, 29 Nov 2005, John Baldwin wrote: > > Fix snderr() to not leak the socket buffer lock if an error occurs in > > sosend(). Robert accidentally changed the snderr() macro to jump to the > > out label which assumes the lock is a

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Robert Watson
On Wed, 30 Nov 2005, Dag-Erling Smørgrav wrote: Robert Watson <[EMAIL PROTECTED]> writes: Thanks for fixing this -- I ran this patch in testing for ages, but must have done some "clean up" or other such 99.85% harmless activity :-(. And how many years have you been drinking from glasses...?

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Dag-Erling Smørgrav
Robert Watson <[EMAIL PROTECTED]> writes: > Thanks for fixing this -- I ran this patch in testing for ages, but > must have done some "clean up" or other such 99.85% harmless activity > :-(. And how many years have you been drinking from glasses...? *ducks* *runs* DES -- Dag-Erling Smørgrav - [

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Robert Watson
On Tue, 29 Nov 2005, John Baldwin wrote: Fix snderr() to not leak the socket buffer lock if an error occurs in sosend(). Robert accidentally changed the snderr() macro to jump to the out label which assumes the lock is already released rather than the release label which drops the lock in

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-29 Thread John Baldwin
On Tuesday 29 November 2005 06:07 pm, John Baldwin wrote: > jhb 2005-11-29 23:07:14 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > Fix snderr() to not leak the socket buffer lock if an error occurs in > sosend(). Robert accide

cvs commit: src/sys/kern uipc_socket.c

2005-11-29 Thread John Baldwin
jhb 2005-11-29 23:07:14 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Fix snderr() to not leak the socket buffer lock if an error occurs in sosend(). Robert accidentally changed the snderr() macro to jump to the out label which assume

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-29 Thread John Baldwin
On Tuesday 29 November 2005 02:47 pm, Bjoern A. Zeeb wrote: > On Mon, 28 Nov 2005, Robert Watson wrote: > > rwatson 2005-11-28 18:09:03 UTC > > > > FreeBSD src repository > > > > Modified files: > >sys/kern uipc_socket.c > > Log: > > Break out functionality in sosend() respo

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-29 Thread Bjoern A. Zeeb
On Mon, 28 Nov 2005, Robert Watson wrote: rwatson 2005-11-28 18:09:03 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Break out functionality in sosend() responsible for building mbuf chains and copying in mbufs from the body of the send logic, cr

cvs commit: src/sys/kern uipc_socket.c

2005-11-28 Thread Robert Watson
rwatson 2005-11-28 21:45:36 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Move zero copy statistics structure before sosend_copyin(). MFC after: 1 month Reported by:tinderbox, sam Revision ChangesPath 1.254 +15

cvs commit: src/sys/kern uipc_socket.c

2005-11-28 Thread Robert Watson
rwatson 2005-11-28 18:09:03 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Break out functionality in sosend() responsible for building mbuf chains and copying in mbufs from the body of the send logic, creating a new function sosend_copyin(