cvs commit: src/sys/dev/pccbb pccbb.c

2008-08-10 Thread Warner Losh
imp 2008-08-10 09:55:14 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: SVN rev 181523 on 2008-08-10 09:55:14Z by imp Read the config space of the child, not the bridge, to determine when the child is out of reset... Revision Changes

cvs commit: src/sys/dev/pccbb pccbb.c

2008-08-09 Thread Warner Losh
imp 2008-08-09 17:29:36 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: SVN rev 181472 on 2008-08-09 17:29:36Z by imp fix typo Submitted by: N.J. Mann Revision ChangesPath 1.171 +1 -1 src/sys/dev/pccbb/pccbb.c

cvs commit: src/sys/dev/pccbb pccbb.c

2008-08-09 Thread Warner Losh
imp 2008-08-09 15:55:10 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: SVN rev 181470 on 2008-08-09 15:55:10Z by imp It turns out that checking the first DWORD register is more reliable on a variety of cards. Adjust the comments according

cvs commit: src/sys/dev/pccbb pccbb.c

2008-08-09 Thread Warner Losh
imp 2008-08-09 07:41:18 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: SVN rev 181458 on 2008-08-09 07:41:18Z by imp After some intial testing, there are even slower cards than the ones that I have. Wait up to 1.1s for the card to become

cvs commit: src/sys/dev/pccbb pccbb.c

2008-08-08 Thread Warner Losh
imp 2008-08-09 04:08:36 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: SVN rev 181453 on 2008-08-09 04:08:36Z by imp Rather than waiting a fixed amount of time, which might not be enough and also holds things up, check every 20ms to see if

cvs commit: src/sys/dev/pccbb pccbb.c

2008-08-08 Thread Warner Losh
imp 2008-08-09 03:37:12 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: SVN rev 181451 on 2008-08-09 03:37:12Z by imp While most bridges can bring a card out of reset in 20ms, there are some bridge + card combinations that take longer for r

cvs commit: src/sys/dev/pccbb pccbb.c pccbb_pci.c pccbbvar.h

2007-06-03 Thread Warner Losh
imp 2007-06-04 05:59:44 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c pccbb_pci.c pccbbvar.h Log: Migrate from setting a CARD_OK flag in a shared word, to setting its own entry in the softc. This should allow more of cbb_pci_intr() to migrate to

cvs commit: src/sys/dev/pccbb pccbb.c

2007-06-03 Thread Warner Losh
imp 2007-06-04 03:13:24 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Don't register cb_func_filt if the client driver doesn't have a filter. ditto for the isr. Reviewed/Suggested by: simokawa-san Revision ChangesPath 1.163

cvs commit: src/sys/dev/pccbb pccbb.c

2007-06-02 Thread Warner Losh
imp 2007-06-03 05:42:05 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Minor filter tweaks: o If we don't have a filter, also check to make sure the card is there before calling the scheduled ISR. This is necessary to help old drivers whos

cvs commit: src/sys/dev/pccbb pccbb.c pccbbvar.h src/sys/dev/pccard pccard.c pccardvarp.h

2007-05-31 Thread Paolo Pisati
piso2007-05-31 19:29:20 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbbvar.h pccbb.c sys/dev/pccard pccard.c pccardvarp.h Log: Make the interrupt handler wrapper capable of correctly support filter+ithread handler. Discussed and reviewed

cvs commit: src/sys/dev/pccbb pccbb.c

2007-05-16 Thread Warner Losh
imp 2007-05-16 19:53:49 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: o Don't hold lock over bus_teardown_intr when we're waiting for the thread to die, since that can cause deadlock with the ISR (in theory). o Minor cleanup o comment ni

cvs commit: src/sys/dev/pccbb pccbb.c

2007-05-16 Thread Warner Losh
imp 2007-05-16 18:44:56 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Better message on cbb resource alloc failure Revision ChangesPath 1.159 +1 -1 src/sys/dev/pccbb/pccbb.c ___ cv

cvs commit: src/sys/dev/pccbb pccbb.c

2007-03-04 Thread Warner Losh
imp 2007-03-05 05:40:24 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Use different wait channel name for second of two sleeps. Minor commentary addition. Revision ChangesPath 1.158 +2 -2 src/sys/dev/pccbb/pccbb.c ___

cvs commit: src/sys/dev/pccbb pccbb.c

2007-03-04 Thread Warner Losh
imp 2007-03-04 19:33:12 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Reduce the number of retries to 10 from 20 for not_a_card retry test. Add some comments to explain how 10 was picked. 20 was completely arbitrary, at least 10 has some re

cvs commit: src/sys/dev/pccbb pccbb.c

2007-02-27 Thread John Baldwin
jhb 2007-02-27 17:27:23 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Use pause() instead of tsleep()'s on the softc pointer that have no corresponding wakeups. Also, at least some of the comments nearby indicate that these are fixed-length

cvs commit: src/sys/dev/pccbb pccbb.c

2007-02-15 Thread Warner Losh
imp 2007-02-16 05:37:00 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Two changes: (1) change debounce period from 1s to 250ms. This appears to be fine and speeds things up a little. (2) In the middle of cbb_pcic_power_disable_socket

cvs commit: src/sys/dev/pccbb pccbb.c

2007-02-14 Thread Warner Losh
imp 2007-02-15 07:13:38 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Fix three bugs: o When detaching all children, try really hard to get all the children list before giving up. This is based on an observation by hans petter selasky

cvs commit: src/sys/dev/pccbb pccbb.c pccbb_pci.c pccbbreg.h

2006-08-12 Thread Warner Losh
imp 2006-08-12 09:06:55 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c pccbb_pci.c pccbbreg.h Log: Batch of changes: o when turning off the socket for a 16-bit card, write 0 to INTR register rather than just tying to just clear the rest bit. th

cvs commit: src/sys/dev/pccbb pccbb.c

2006-06-03 Thread Warner Losh
imp 2006-06-03 21:05:36 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Since we turn off the interrupts, we don't need to disestablish our ISR. Revision ChangesPath 1.150 +0 -13 src/sys/dev/pccbb/pccbb.c

cvs commit: src/sys/dev/pccbb pccbb.c pccbb_pci.c pccbbvar.h

2006-06-03 Thread Warner Losh
imp 2006-06-03 19:16:45 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c pccbb_pci.c pccbbvar.h Log: Move shutdown, and pci specific methods into pccbb_pci.c. Many more are needed still. Revision ChangesPath 1.149 +1 -66 src/sys/d

cvs commit: src/sys/dev/pccbb pccbb.c pccbb_pci.c

2006-06-03 Thread Warner Losh
imp 2006-06-03 19:07:16 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c pccbb_pci.c Log: The interrupt routine is pci specific. Move it into pccbb_pci.c. Revision ChangesPath 1.148 +0 -69 src/sys/dev/pccbb/pccbb.c 1.20 +71 -

cvs commit: src/sys/dev/pccbb pccbb.c

2006-06-03 Thread Warner Losh
imp 2006-06-03 18:57:28 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Succeed for writing bus value... nobody that calls must care :-( Revision ChangesPath 1.147 +1 -1 src/sys/dev/pccbb/pccbb.c _

cvs commit: src/sys/dev/pccbb pccbb.c

2006-06-01 Thread Warner Losh
imp 2006-06-02 06:33:35 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Zero out the devices when they are deleted. We can access the pointer after the bus detaches which can lead to core dumps. This is quite rare. Revision ChangesPa

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-05-25 Thread Gleb Smirnoff
On Thu, May 25, 2006 at 08:08:25AM -0600, M. Warner Losh wrote: M> The problem is elsewhere in the system if it is the use of tsleep. M> Get me a laptop that has otherwise working suspend/resume and I'll fix M> this. I can follow your instructions and provide any help. I can give you a shell and a

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-05-25 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Scott Long <[EMAIL PROTECTED]> writes: : Gleb Smirnoff wrote: : > On Wed, May 24, 2006 at 05:26:16PM +, Warner Losh wrote: : > W> imp 2006-05-24 17:26:16 UTC : > W> : > W> FreeBSD src repository : > W> : > W> Modified files: : > W> s

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-05-25 Thread Scott Long
Gleb Smirnoff wrote: On Wed, May 24, 2006 at 05:26:16PM +, Warner Losh wrote: W> imp 2006-05-24 17:26:16 UTC W> W> FreeBSD src repository W> W> Modified files: W> sys/dev/pccbbpccbb.c W> Log: W> Suspend the children before we turn off card events in hardware.

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-05-25 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Gleb Smirnoff <[EMAIL PROTECTED]> writes: : On Wed, May 24, 2006 at 05:26:16PM +, Warner Losh wrote: : W> imp 2006-05-24 17:26:16 UTC : W> : W> FreeBSD src repository : W> : W> Modified files: : W> sys/dev/pccbbpccbb.c : W>

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-05-25 Thread Gleb Smirnoff
On Wed, May 24, 2006 at 05:26:16PM +, Warner Losh wrote: W> imp 2006-05-24 17:26:16 UTC W> W> FreeBSD src repository W> W> Modified files: W> sys/dev/pccbbpccbb.c W> Log: W> Suspend the children before we turn off card events in hardware. This W> was done, I be

cvs commit: src/sys/dev/pccbb pccbb.c

2006-05-24 Thread Warner Losh
imp 2006-05-24 17:26:16 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Suspend the children before we turn off card events in hardware. This was done, I believe, to work around some cards having issues in the suspend case. I think that this

cvs commit: src/sys/dev/pccbb pccbb.c

2006-05-24 Thread Warner Losh
imp 2006-05-24 17:22:53 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Fix a race when detaching the cbb worker thread. There were a couple of cases where we didn't take out the lock before setting or clearing a bit. This apparently can lea

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-17 Thread Christian Brueffer
On Sun, Apr 16, 2006 at 11:16:45PM +, Warner Losh wrote: > imp 2006-04-16 23:16:45 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pccbbpccbb.c > Log: > Add missing ~. We want all the INVALID bits to be 0... Let's see if this > helps people with t

cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-16 Thread Warner Losh
imp 2006-04-16 23:16:45 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Add missing ~. We want all the INVALID bits to be 0... Let's see if this helps people with their interrupt storm problem on card eject. Revision ChangesPath 1.

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-13 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Sam Leffler <[EMAIL PROTECTED]> writes: : M. Warner Losh wrote: : > In message: <[EMAIL PROTECTED]> : > Christian Brueffer <[EMAIL PROTECTED]> writes: : > : On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: : > : > imp 2006-

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-13 Thread Sam Leffler
M. Warner Losh wrote: In message: <[EMAIL PROTECTED]> Christian Brueffer <[EMAIL PROTECTED]> writes: : On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: : > imp 2006-03-30 04:25:45 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/pccb

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-13 Thread Wesley Morgan
On Thu, 13 Apr 2006, Christian Brueffer wrote: On Wed, Apr 12, 2006 at 10:33:42PM -0400, Niki Denev wrote: M. Warner Losh wrote: In message: <[EMAIL PROTECTED]> Christian Brueffer <[EMAIL PROTECTED]> writes: : On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: : > imp

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-13 Thread Christian Brueffer
On Wed, Apr 12, 2006 at 10:33:42PM -0400, Niki Denev wrote: > M. Warner Losh wrote: > > In message: <[EMAIL PROTECTED]> > > Christian Brueffer <[EMAIL PROTECTED]> writes: > > : On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: > > : > imp 2006-03-30 04:25:45 UTC > > :

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-12 Thread Christian Brueffer
On Wed, Apr 12, 2006 at 04:22:41PM -0700, Sam Leffler wrote: > M. Warner Losh wrote: > >In message: <[EMAIL PROTECTED]> > >Christian Brueffer <[EMAIL PROTECTED]> writes: > >: On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: > >: > imp 2006-03-30 04:25:45 UTC > >: >

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-12 Thread Niki Denev
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 M. Warner Losh wrote: > In message: <[EMAIL PROTECTED]> > Christian Brueffer <[EMAIL PROTECTED]> writes: > : On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: > : > imp 2006-03-30 04:25:45 UTC > : > > : > FreeBSD src r

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-12 Thread Sam Leffler
M. Warner Losh wrote: In message: <[EMAIL PROTECTED]> Christian Brueffer <[EMAIL PROTECTED]> writes: : On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: : > imp 2006-03-30 04:25:45 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/pccb

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-12 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Christian Brueffer <[EMAIL PROTECTED]> writes: : On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: : > imp 2006-03-30 04:25:45 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/pccbbpccbb.c : >

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-12 Thread Christian Brueffer
On Wed, Apr 12, 2006 at 11:28:43PM +0200, Christian Brueffer wrote: > On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: > > imp 2006-03-30 04:25:45 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/pccbbpccbb.c > > Log: > > On some lapt

Re: cvs commit: src/sys/dev/pccbb pccbb.c

2006-04-12 Thread Christian Brueffer
On Thu, Mar 30, 2006 at 04:25:45AM +, Warner Losh wrote: > imp 2006-03-30 04:25:45 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pccbbpccbb.c > Log: > On some laptops, under very high loads, the socket event register read > in the ISR doesn't read

cvs commit: src/sys/dev/pccbb pccbb.c

2006-03-29 Thread Warner Losh
imp 2006-03-30 04:25:45 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: On some laptops, under very high loads, the socket event register read in the ISR doesn't read the actual socket event register, but instead reads garbage (usually 0xf

cvs commit: src/sys/dev/pccbb pccbb.c

2006-03-23 Thread Warner Losh
imp 2006-03-24 07:52:00 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: For each of the voltages that a card might support, make sure that the socket also supports the voltage. Some XV cards have appeared on the scene (or cards that report th

cvs commit: src/sys/dev/pccbb pccbb.c

2006-02-07 Thread Warner Losh
imp 2006-02-07 18:38:51 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Detach the children before we delete them. This is a little cleaner than just deleting them. Also add comments about why we do this. Given the current behavior of delete

cvs commit: src/sys/dev/pccbb pccbb.c

2006-02-04 Thread Warner Losh
imp 2006-02-04 21:56:14 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Now that TUNABLE_ULONG is in the tree, and has been for a while, use it. This also avoids typepunning. Revision ChangesPath 1.138 +3 -3 src/sys/dev/pccb

cvs commit: src/sys/dev/pccbb pccbb.c

2005-12-31 Thread Warner Losh
imp 2005-12-31 20:04:39 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Remove extra debugging that crept in with the integration from p4. Revision ChangesPath 1.137 +1 -1 src/sys/dev/pccbb/pccbb.c

cvs commit: src/sys/dev/pccbb pccbb.c

2005-12-29 Thread Warner Losh
imp 2005-12-29 23:38:45 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Simplify the opening of the resources for cardbus cards. Before we'd try very hard to be perfect. However, these attempts broke down when there were large numbers of res

cvs commit: src/sys/dev/pccbb pccbb.c

2005-12-27 Thread Warner Losh
imp 2005-12-27 19:18:11 UTC FreeBSD src repository Modified files: sys/dev/pccbbpccbb.c Log: Ensure that we're aligned at leas tto the size of the resource being requested. When cbb_debug is on, print the windows that we're mapping. Revision ChangesPath