Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-21 Thread Alexander Leidinger
Quoting [EMAIL PROTECTED] (from Sun, 20 May 2007 22:39:01 -0700 (PDT)): Sounds like more wonderful roadblocks from the GCC team. GCC is a great app, but it would be nice if it could be used as a tool for software development. It is a fine toolchain despite some of these issues. It doe

Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-21 Thread Bruce Evans
On Mon, 21 May 2007 [EMAIL PROTECTED] wrote: On Mon, 21 May 2007, Bruce Evans wrote: But the non-bug is still in the function and should be fixed and documented there, not in all callers. I can't parse this. "Non-bug": it's a warning about a problem which you say doesn't exist. "fixed": n

cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-21 Thread Matt Jacob
mjacob 2007-05-21 09:26:47 UTC FreeBSD src repository Modified files: sys/dev/hptmvioctl.c Log: Perhaps a better fix- make the called function do the (possible never reached) initialization. Do a token amount of style cleanup. Poked by: bde Revision Changes

Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-21 Thread mjacob
On Mon, 21 May 2007, Bruce Evans wrote: On Sun, 20 May 2007 [EMAIL PROTECTED] wrote: mjacob 2007-05-20 16:49:10 UTC FreeBSD src repository Modified files: sys/dev/hptmvioctl.c Log: Make gcc 4.2 happy by initiatlizing controller && channel prior to a call to a function

Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-21 Thread Bruce Evans
On Sun, 20 May 2007 [EMAIL PROTECTED] wrote: mjacob 2007-05-20 16:49:10 UTC FreeBSD src repository Modified files: sys/dev/hptmvioctl.c Log: Make gcc 4.2 happy by initiatlizing controller && channel prior to a call to a function which *might* then initialize them. MFC af

Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-20 Thread mjacob
Sounds like more wonderful roadblocks from the GCC team. GCC is a great app, but it would be nice if it could be used as a tool for software development. It is a fine toolchain despite some of these issues. It does concern me greatly though that the majority of software development is now

Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-20 Thread Scott Long
[EMAIL PROTECTED] wrote: mjacob 2007-05-20 16:49:10 UTC FreeBSD src repository Modified files: sys/dev/hptmvioctl.c Log: Make gcc 4.2 happy by initiatlizing controller && channel prior to a call to a function which *might* then initialize them. MFC after: 3 days Is

Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-20 Thread mjacob
mjacob 2007-05-20 16:49:10 UTC FreeBSD src repository Modified files: sys/dev/hptmvioctl.c Log: Make gcc 4.2 happy by initiatlizing controller && channel prior to a call to a function which *might* then initialize them. MFC after: 3 days Isn't the bug that the funct

Re: cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-20 Thread Bruce Evans
On Sun, 20 May 2007, Matt Jacob wrote: mjacob 2007-05-20 16:49:10 UTC FreeBSD src repository Modified files: sys/dev/hptmvioctl.c Log: Make gcc 4.2 happy by initiatlizing controller && channel prior to a call to a function which *might* then initialize them. MFC after:

cvs commit: src/sys/dev/hptmv ioctl.c

2007-05-20 Thread Matt Jacob
mjacob 2007-05-20 16:49:10 UTC FreeBSD src repository Modified files: sys/dev/hptmvioctl.c Log: Make gcc 4.2 happy by initiatlizing controller && channel prior to a call to a function which *might* then initialize them. MFC after: 3 days Revision Change