Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-19 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= wr ites: >No, it just happens that CDs are the only currently existing case. >Another case (which we don't have in our current code base) is a volume >manager which allows on-line resizing of a volume [...] GEOM actually has a s

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-19 Thread Dag-Erling Smørgrav
"Poul-Henning Kamp" <[EMAIL PROTECTED]> writes: > Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes: > > There is another closely related problem which also needs fixing and > > which also requires GEOM to distinguish between device and media: > > GEOM's behaviour when the media changes while the devi

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-19 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= wr ites: >"Poul-Henning Kamp" <[EMAIL PROTECTED]> writes: >> In message <[EMAIL PROTECTED]>, Scott Long writes: >> > But then why not have g_access be able to communicate the ability to >> > access the device independent from the

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-19 Thread Dag-Erling Smørgrav
"Poul-Henning Kamp" <[EMAIL PROTECTED]> writes: > In message <[EMAIL PROTECTED]>, Scott Long writes: > > But then why not have g_access be able to communicate the ability to > > access the device independent from the ability to access the media? > > Seems like both of these questions are "access" q

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-17 Thread Søren Schmidt
Poul-Henning Kamp wrote: The only suggested change is that the printfs in geom gets supressed for this one particular errno. Nothing else changes as far as I know. Exactly. -Søren ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mai

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Søren Schmidt
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Poul-Henning Kamp wrote: Well, there are two questions: media present (yes/no) and drive capable of telling if media present without just trying to read it (yes/no). This risk reopening the old r

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Ok, back on track. What you want to do is make g_access largely >irrelevant, and have the _real_ access check done in g_start. Fine. Only for drive mechanisms that require out of band ioctls issued over the inband channel in order to enable a

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: Poul-Henning Kamp wrote: Well, there are two questions: media present (yes/no) and drive capable of telling if media present without just trying to read it (yes/no). This risk reopening the old religious war if driv

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Poul-Henning Kamp wrote: >>> Well, there are two questions: media present (yes/no) and drive capable >>> of telling if media present without just trying to read it (yes/no). >> >> This risk reopening the old religious war if drivers should poll

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Nate Lawson writes: Well, there are two questions: media present (yes/no) and drive capable of telling if media present without just trying to read it (yes/no). This risk reopening the old religious war if drivers should poll their dri

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Nate Lawson writes: >Well, there are two questions: media present (yes/no) and drive capable >of telling if media present without just trying to read it (yes/no). This risk reopening the old religious war if drivers should poll their drives to be up to date on med

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Nate Lawson
Poul-Henning Kamp wrote: > In message <[EMAIL PROTECTED]>, Scott Long writes: > >>> What I've sortof talked phk into is that if I return the "right" error >>> code in the "start" function, it will back off and not retry nor chatter. >>> We still need the "access" function to return OK if HW prese

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Scott Long
M. Warner Losh wrote: In message: <[EMAIL PROTECTED]> Scott Long <[EMAIL PROTECTED]> writes: : SXren Schmidt wrote: : > sos 2007-10-26 08:59:24 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/ata atapi-cd.c atapi-cd.h : > Log: : >

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >> What I've sortof talked phk into is that if I return the "right" error >> code in the "start" function, it will back off and not retry nor chatter. >> We still need the "access" function to return OK if HW present or we >> cannot send ioctl c

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Scott Long
SXren Schmidt wrote: sos 2007-10-26 08:59:24 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cd.c atapi-cd.h Log: Update the way we get the mode pages on probe. Revision ChangesPath 1.194 +22 -25src/sys/dev/ata/atapi-cd.c 1.47

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >Poul-Henning Kamp wrote: >> In message <[EMAIL PROTECTED]>, Scott Long writes: >> The simplest way to do this, is probably to overload ENOENT or some other currently undefined errno for this effect. >>> But then why not have g_access be

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Nate Lawson
Søren Schmidt wrote: > Scott Long wrote: >> SXren Schmidt wrote: >>> sos 2007-10-26 08:59:24 UTC >>> >>> FreeBSD src repository >>> >>> Modified files: >>> sys/dev/ata atapi-cd.c atapi-cd.h Log: >>> Update the way we get the mode pages on probe. >>> Revision Chang

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Søren Schmidt
Nate Lawson wrote: Søren Schmidt wrote: Scott Long wrote: SXren Schmidt wrote: sos 2007-10-26 08:59:24 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cd.c atapi-cd.h Log: Update the way we get the mode pages on probe. Revision Ch

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Scott Long writes: >> The simplest way to do this, is probably to overload ENOENT or some >> other currently undefined errno for this effect. > >But then why not have g_access be able to communicate the ability to >access the device independent from the ability to

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: The simplest way to do this, is probably to overload ENOENT or some other currently undefined errno for this effect. But then why not have g_access be able to communicate the ability to access the device independent fr

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Scott Long
Poul-Henning Kamp wrote: In message <[EMAIL PROTECTED]>, Scott Long writes: What I've sortof talked phk into is that if I return the "right" error code in the "start" function, it will back off and not retry nor chatter. We still need the "access" function to return OK if HW present or we cann

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Scott Long <[EMAIL PROTECTED]> writes: : SXren Schmidt wrote: : > sos 2007-10-26 08:59:24 UTC : > : > FreeBSD src repository : > : > Modified files: : > sys/dev/ata atapi-cd.c atapi-cd.h : > Log: : > Update the way we get t

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Scott Long
Søren Schmidt wrote: Nate Lawson wrote: Søren Schmidt wrote: Scott Long wrote: SXren Schmidt wrote: sos 2007-10-26 08:59:24 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cd.c atapi-cd.h Log: Update the way we get the mode pages on pr

Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-11-16 Thread Søren Schmidt
Scott Long wrote: SXren Schmidt wrote: sos 2007-10-26 08:59:24 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cd.c atapi-cd.h Log: Update the way we get the mode pages on probe. Revision ChangesPath 1.194 +22 -25src/sys/dev/ata/atap

cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h

2007-10-26 Thread S�ren Schmidt
sos 2007-10-26 08:59:24 UTC FreeBSD src repository Modified files: sys/dev/ata atapi-cd.c atapi-cd.h Log: Update the way we get the mode pages on probe. Revision ChangesPath 1.194 +22 -25src/sys/dev/ata/atapi-cd.c 1.47 +1 -0 src/sys/de