Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pst

2007-05-01 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Daniel Eischen <[EMAIL PROTECTED]> writes: : On Tue, 1 May 2007, Andrey A. Chernov wrote: : : > ache2007-05-01 16:02:44 UTC : > : > FreeBSD src repository : > : > Modified files: : >lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c :

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c...

2007-05-01 Thread Andrey Chernov
On Tue, May 01, 2007 at 01:53:17PM -0400, Garance A Drosehn wrote: > But I expect the fixes to *other* programs (such as usr.bin/env) > could be committed without causing any trouble for anyone. If > that's true, then we might as well leave those changes in. Yes, they could, they are backward-

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pst

2007-05-01 Thread Andrey Chernov
On Tue, May 01, 2007 at 01:12:12PM -0400, Daniel Eischen wrote: > > Not because I admit they are technically wrong and not because of bug > > reports (I receive nothing). But because I surprisingly meets so > > strong opposition and resistance so lost any desire to continue that. > > Uh, pleas

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pst

2007-05-01 Thread Ceri Davies
On Tue, May 01, 2007 at 04:02:44PM +, Andrey A. Chernov wrote: > ache2007-05-01 16:02:44 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c > sys/sys param.h > usr.bin/limits limits.c >

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c...

2007-05-01 Thread Garance A Drosehn
At 1:12 PM -0400 5/1/07, Daniel Eischen wrote: On Tue, 1 May 2007, Andrey A. Chernov wrote: Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c sys/sys param.h usr.bin/limits limits.c usr.bin/env env.c usr.sbin/sysinstall main.c

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c

2007-05-01 Thread Daniel Eischen
On Tue, 1 May 2007, Andrey A. Chernov wrote: ache2007-05-01 16:02:44 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c sys/sys param.h usr.bin/limits limits.c usr.bin/env env.c usr.sbin/sysin

cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c src/sys/sys param.h src/usr.bin/limits limits.c src/usr.bin/env env.c src/usr.sbin/sysinstall main.c variable.c src/usr.sbin/pstat p

2007-05-01 Thread Andrey A. Chernov
ache2007-05-01 16:02:44 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c sys/sys param.h usr.bin/limits limits.c usr.bin/env env.c usr.sbin/sysinstall main.c variable.c usr.sbi

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Garance A Drosehn
At 10:48 PM +0400 4/30/07, Andrey Chernov wrote: To the matter: env incorrectly calls setenv("name=...", ...) which is POSIX violation: I can fix the 'env' command, if you want... (not sure I can get to it tonight, but I'll see) Ah. I see you've already fixed it... -- Garance Alistair Drose

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Garance A Drosehn
At 10:48 PM +0400 4/30/07, Andrey Chernov wrote: On Mon, Apr 30, 2007 at 08:36:24PM +0200, Henrik Brix Andersen wrote: > This is the output of the same test on my RELENG_6 box: $ env -vi foo=bar env #env clearing environ #env setenv:foo=bar #env executing: env #envarg[0]= 'env'

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Andrey Chernov
On Mon, Apr 30, 2007 at 09:22:45PM +0200, Henrik Brix Andersen wrote: > On Mon, Apr 30, 2007 at 11:12:53PM +0400, Andrey Chernov wrote: > > In case you mean some ports, they should be fixed, and I'll help. Such > > fixes are backward compatible, so will works for older FreeBSD versions > > too. >

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Henrik Brix Andersen
On Mon, Apr 30, 2007 at 11:12:53PM +0400, Andrey Chernov wrote: > In case you mean some ports, they should be fixed, and I'll help. Such > fixes are backward compatible, so will works for older FreeBSD versions > too. If the changes needed are backwards compatible wouldn't it have been better to

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Andrey Chernov
On Mon, Apr 30, 2007 at 08:58:44PM +0200, Henrik Brix Andersen wrote: > > To the matter: env incorrectly calls setenv("name=...", ...) which is > > POSIX violation: > > Ok, so we can fix all in-tree occurrences that violate the above, but > what about 3rd party software that relies on setenv("name

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Henrik Brix Andersen
On Mon, Apr 30, 2007 at 10:48:54PM +0400, Andrey Chernov wrote: > Thanx for the report, but please be patient a bit, work in the progress > and fix already planned soon. I see. > To the matter: env incorrectly calls setenv("name=...", ...) which is > POSIX violation: Ok, so we can fix all in-tre

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Andrey Chernov
On Mon, Apr 30, 2007 at 08:36:24PM +0200, Henrik Brix Andersen wrote: > Todays changes to *env() appears to have broken stuff (my -CURRENT box > fails to build many ports after these changes, due to missing > environment variables in the build environment). > > Here is a simple test-case: > > $ e

Re: cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Henrik Brix Andersen
Hi, On Mon, Apr 30, 2007 at 04:56:18PM +, Andrey A. Chernov wrote: > ache2007-04-30 16:56:18 UTC > > FreeBSD src repository > > Modified files: > lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c > Log: > Make putenv() fully conforms to Open Group specs Issue 6 >

cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-30 Thread Andrey A. Chernov
ache2007-04-30 16:56:18 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c Log: Make putenv() fully conforms to Open Group specs Issue 6 (also IEEE Std 1003.1-2001) The specs explicitly says that altering passed string

cvs commit: src/lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c

2007-04-29 Thread Andrey A. Chernov
ache2007-04-30 02:25:02 UTC FreeBSD src repository Modified files: lib/libc/stdlib getenv.3 getenv.c putenv.c setenv.c Log: Make setenv, putenv, getenv and unsetenv conforming to Open Group specs Issue 6 (also IEEE Std 1003.1-2001) in following areas: args, return, e