Re: cvs commit: src/lib/libc/i386/gen _setjmp.S setjmp.S

2008-06-28 Thread Bruce Evans
On Sat, 28 Jun 2008, David Schultz wrote: On Sun, Jun 29, 2008, Bruce Evans wrote: On Sat, 28 Jun 2008, David Schultz wrote: Don't clobber the FPU exception flags in longjmp. C99 requires them to remain unchanged. ...but got cut off somehow. This is wrong. It breaks longjmp() from all COM

Re: cvs commit: src/lib/libc/i386/gen _setjmp.S setjmp.S

2008-06-28 Thread David Schultz
On Sun, Jun 29, 2008, Bruce Evans wrote: > On Sat, 28 Jun 2008, David Schultz wrote: > > Don't clobber the FPU exception flags in longjmp. C99 requires them > > to remain unchanged. > > > >...but got cut off somehow. > > This is wrong. It breaks longjmp() from all COMPAT_[3-4] signal > handlers

Re: cvs commit: src/lib/libc/i386/gen _setjmp.S setjmp.S

2008-06-28 Thread Bruce Evans
On Sat, 28 Jun 2008, David Schultz wrote: On Sat, Jun 28, 2008, David Schultz wrote: das 2008-06-28 17:58:06 UTC FreeBSD src repository Modified files: lib/libc/i386/gen_setjmp.S setjmp.S Log: SVN rev 180081 on 2008-06-28 17:58:06Z by das We should also save and res

Re: cvs commit: src/lib/libc/i386/gen _setjmp.S setjmp.S

2008-06-28 Thread David Schultz
On Sat, Jun 28, 2008, David Schultz wrote: > das 2008-06-28 17:58:06 UTC > > FreeBSD src repository > > Modified files: > lib/libc/i386/gen_setjmp.S setjmp.S > Log: > SVN rev 180081 on 2008-06-28 17:58:06Z by das > > We should also save and restore the MXCSR as on am

cvs commit: src/lib/libc/i386/gen _setjmp.S setjmp.S

2008-06-28 Thread David Schultz
das 2008-06-28 17:58:06 UTC FreeBSD src repository Modified files: lib/libc/i386/gen_setjmp.S setjmp.S Log: SVN rev 180081 on 2008-06-28 17:58:06Z by das We should also save and restore the MXCSR as on amd64, but detecting whether the CPU supports SSE or not here i