Hi Andre,
On Tue, Jul 31, 2007 at 04:48:08PM +0200, Andre Oppermann wrote:
> Gleb Smirnoff wrote:
>> On Sat, Jul 28, 2007 at 12:20:40PM +, Andre Oppermann wrote:
>> A> andre 2007-07-28 12:20:39 UTC
>> A> A> FreeBSD src repository
>> A> A> Modified files:
>> A> sys/netinet
Gleb Smirnoff wrote:
On Sat, Jul 28, 2007 at 12:20:40PM +, Andre Oppermann wrote:
A> andre 2007-07-28 12:20:39 UTC
A>
A> FreeBSD src repository
A>
A> Modified files:
A> sys/netinet tcp_input.c tcp_subr.c tcp_var.h
A> Log:
A> Provide a sysctl to toggle reporting
On Sat, Jul 28, 2007 at 12:20:40PM +, Andre Oppermann wrote:
A> andre 2007-07-28 12:20:39 UTC
A>
A> FreeBSD src repository
A>
A> Modified files:
A> sys/netinet tcp_input.c tcp_subr.c tcp_var.h
A> Log:
A> Provide a sysctl to toggle reporting of TCP debug logging:
A>
In message: <[EMAIL PROTECTED]>
Dag-Erling_Smørgrav <[EMAIL PROTECTED]> writes:
: Warner Losh <[EMAIL PROTECTED]> writes:
: > Thank you for your opinion. However, make universe is not worthless.
: > If doing one, and checking the output for errors, isn't sufficient to
: > get tinderbox
Dag-Erling Smørgrav wrote:
Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes:
The attached patch unbreaks the build.
With additional hunk to fix usr.bin/netstat/ipx.c, which relied on the
brokenness of .
Hi,
may I suggest to declare the array as
static const char * const tcpstates[].
M
On Mon, Jul 30, 2007 at 02:01:41AM -0700, [EMAIL PROTECTED] wrote:
> I've asked RE to let me check in a change and hopefully we can move on
> and then I'll try and figure out the latest ports version of tinderbox
> and see if it actually does what I need quicker.
The tinderbox in ports is a port
Andre Oppermann <[EMAIL PROTECTED]> writes:
> Please don't forget to undo the #ifdef and change of the log function
> in tcp_input.c.
You mean revert 1.365? Sure, see updated patch.
DES
--
Dag-Erling Smørgrav - [EMAIL PROTECTED]
Index: sys/netinet/tcp_fsm.h
Dag-Erling Smørgrav wrote:
Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes:
The attached patch unbreaks the build.
With additional hunk to fix usr.bin/netstat/ipx.c, which relied on the
brokenness of .
Please don't forget to undo the #ifdef and change of the log function
in tcp_input.c.
DES
Dag-Erling Smørgrav <[EMAIL PROTECTED]> writes:
> The attached patch unbreaks the build.
With additional hunk to fix usr.bin/netstat/ipx.c, which relied on the
brokenness of .
DES
--
Dag-Erling Smørgrav - [EMAIL PROTECTED]
Index: sys/netinet/tcp_fsm.h
===
Warner Losh <[EMAIL PROTECTED]> writes:
> Thank you for your opinion. However, make universe is not worthless.
> If doing one, and checking the output for errors, isn't sufficient to
> get tinderbox to not whine, then tinderbox is broken.
Thank you for *your* opinion, but the tinderbox is not at
On Mon, 30 Jul 2007, Warner Losh wrote:
[EMAIL PROTECTED] writes:
All of these statements seem to cancel each other out or are
incorrec. I consider the subject closed as it is compiling a universe
run right now.
Famous last words.
As I've said far too many times before, 'make universe' is
> [EMAIL PROTECTED] writes:
> > All of these statements seem to cancel each other out or are
> > incorrec. I consider the subject closed as it is compiling a universe
> > run right now.
>
> Famous last words.
>
> As I've said far too many times before, 'make universe' is worthless.
>
> Now will
I believe I have it fixed and was just waiting for the different
compiles to finish. I realize that I've inconvenienced you all by being
slow in correcting this- and I do apologize. Except to DES.
___
cvs-all@freebsd.org mailing list
http://lists.fr
In message <[EMAIL PROTECTED]>, =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= writes:
>[EMAIL PROTECTED] writes:
>> All of these statements seem to cancel each other out or are
>> incorrec. I consider the subject closed as it is compiling a universe
>> run right now.
>
>Famous last words.
>
>As I've said fa
[EMAIL PROTECTED] writes:
> All of these statements seem to cancel each other out or are
> incorrec. I consider the subject closed as it is compiling a universe
> run right now.
Famous last words.
As I've said far too many times before, 'make universe' is worthless.
Now will you please fix this
solution for now.
No, that's what's actually wrong. tcpstates has to be static to honor the
intent of the original author. If you want to do something extern then the
actual tcpstates should go into tcp_debug.c. However, this is slightly less
flexible in that the way it is now each source fil
On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote:
Hi,
On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote:
On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote:
Here's what probably works. I'll do the test compiles.
If I am not wrong it will not.
The follwoing two files have comments at the beginning to expla
On Sun, 29 Jul 2007, Bjoern A. Zeeb wrote:
On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote:
Here's what probably works. I'll do the test compiles.
If I am not wrong it will not.
The follwoing two files have comments at the beginning to explain the
changes.
I don't like the extern char *tc
On Sun, 29 Jul 2007, [EMAIL PROTECTED] wrote:
Here's what probably works. I'll do the test compiles.
If I am not wrong it will not.
The follwoing two files have comments at the beginning to explain the changes.
I don't like the extern char *tcpstates[] but it seems to be the best
solution for
Here's what probably works. I'll do the test compiles.
Index: netinet/tcp_input.c
===
RCS file: /home/ncvs/src/sys/netinet/tcp_input.c,v
retrieving revision 1.366
diff -u -r1.366 tcp_input.c
--- netinet/tcp_input.c 29 Jul 2007 01:3
Sorry- I was a tired and cranky idiot. I have this fixed now, and will
do a real universe run *and* ask re.
The problem here is that the code is definitely ancient wanky- there's a
const char *[] array in tcp_fsm.h that's compiled in iff TCPSTATES is
defined. Various files include tcp_fsm.h
I know. I'm going to look at it more today.
On Sun, 29 Jul 2007, Maxim Konovalov wrote:
Thanks for fixing this. The whole tcpstates stuff is hackish.
We need a better fix as the state reporting in the log message
should not depend on TCPDEBUG.
tb still fails at tcpstates.
--
Maxim Konovalo
I'm not sure I *did* fix this- the tinderbox stuff is still falling
opver.
On Sun, 29 Jul 2007, Andre Oppermann wrote:
Matt Jacob wrote:
mjacob 2007-07-29 01:31:33 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_usrreq.c Log:
Fix compilatio
> Thanks for fixing this. The whole tcpstates stuff is hackish.
> We need a better fix as the state reporting in the log message
> should not depend on TCPDEBUG.
>
tb still fails at tcpstates.
--
Maxim Konovalov
___
cvs-all@freebsd.org mailing list
htt
Matt Jacob wrote:
mjacob 2007-07-29 01:31:33 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_usrreq.c
Log:
Fix compilation problems- tcpstates is only available if TCPDEBUG
is set.
Approved by:re (in spirit)
Thanks for fixing this.
On Sun, 6 May 2007, Andre Oppermann wrote:
Robert Watson wrote:
On Sun, 6 May 2007, Andre Oppermann wrote:
andre 2007-05-06 15:16:06 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c
Log:
Remove the defunct remains of the TCPS_TIME_WAIT cases from
t
Robert Watson wrote:
On Sun, 6 May 2007, Andre Oppermann wrote:
andre 2007-05-06 15:16:06 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c
Log:
Remove the defunct remains of the TCPS_TIME_WAIT cases from
tcp_do_segment
and change it to a void functi
On Sun, 6 May 2007, Andre Oppermann wrote:
andre 2007-05-06 15:16:06 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c
Log:
Remove the defunct remains of the TCPS_TIME_WAIT cases from tcp_do_segment
and change it to a void function.
We use a compresse
Please note, it broke build world.
Andre Oppermann wrote:
andre 2007-04-11 09:45:16 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_output.c tcp_sack.c
tcp_subr.c tcp_syncache.c tcp_timer.c
tcp_ti
On Wed, Mar 28, 2007 at 12:58:14PM +, Andre Oppermann wrote:
> andre 2007-03-28 12:58:14 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/netinet tcp_input.c
> Log:
> When blackholing do a 'dropunlock' in the new world order to prevent the
> INP_INFO_LOCK
On Thu, 1 Feb 2007, Andre Oppermann wrote:
andre 2007-02-01 18:32:14 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c
tcp_var.h
Log:
Auto sizing TCP socket buffers.
Normally the socket buffers are stati
Andre Oppermann wrote:
andre 2007-02-01 18:32:14 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c tcp_output.c tcp_usrreq.c
tcp_var.h
Log:
Auto sizing TCP socket buffers.
Normally the socket buffers are static (either
On Mon, 25 Sep 2006, John-Mark Gurney wrote:
:Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400:
:> On Tue, 26 Sep 2006, John-Mark Gurney wrote:
:>
:> :jmg 2006-09-26 01:21:47 UTC
:> :
:> : FreeBSD src repository
:> :
:> : Modified files:
:> :sys/netinet
John-Mark Gurney wrote:
jmg 2006-09-26 01:21:47 UTC
FreeBSD src repository
Modified files:
sys/netinet tcp_input.c
Log:
fix calculating to_tsecr... This prevents the rtt calculations from
going all wonky...
*blushes*, looks for pointy hat.
--
Andre
Andrew R. Reiter wrote this message on Mon, Sep 25, 2006 at 21:53 -0400:
> On Tue, 26 Sep 2006, John-Mark Gurney wrote:
>
> :jmg 2006-09-26 01:21:47 UTC
> :
> : FreeBSD src repository
> :
> : Modified files:
> :sys/netinet tcp_input.c
> : Log:
> : fix calculating to_tsecr
On Tue, 26 Sep 2006, John-Mark Gurney wrote:
:jmg 2006-09-26 01:21:47 UTC
:
: FreeBSD src repository
:
: Modified files:
:sys/netinet tcp_input.c
: Log:
: fix calculating to_tsecr... This prevents the rtt calculations from
: going all wonky...
:
: Revision Changes
On Wednesday 13 September 2006 09:08, Andre Oppermann wrote:
> andre 2006-09-13 13:08:27 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/netinet tcp_input.c tcp_output.c tcp_syncache.c
> tcp_var.h
> Log:
> Rewrite of TCP syncookies to
Maxim Konovalov wrote:
On Sun, 18 Jun 2006, 09:18+0100, Robert Watson wrote:
On Sun, 18 Jun 2006, Maxim Konovalov wrote:
On Sun, 18 Jun 2006, 01:37+0100, Robert Watson wrote:
On Sat, 17 Jun 2006, Andre Oppermann wrote:
Revision ChangesPath
1.299 +9 -6 src/sys/netinet/tcp_i
On Sun, 18 Jun 2006, 09:18+0100, Robert Watson wrote:
>
> On Sun, 18 Jun 2006, Maxim Konovalov wrote:
>
> > On Sun, 18 Jun 2006, 01:37+0100, Robert Watson wrote:
> >
> > > On Sat, 17 Jun 2006, Andre Oppermann wrote:
> > >
> > > > Revision ChangesPath
> > > > 1.299 +9 -6 src/sys/net
On Sun, 18 Jun 2006, Maxim Konovalov wrote:
On Sun, 18 Jun 2006, 01:37+0100, Robert Watson wrote:
On Sat, 17 Jun 2006, Andre Oppermann wrote:
Revision ChangesPath
1.299 +9 -6 src/sys/netinet/tcp_input.c
1.87 +286 -255 src/sys/netinet/tcp_syncache.c
1.130 +9 -6
On Sun, 18 Jun 2006, 01:37+0100, Robert Watson wrote:
>
> On Sat, 17 Jun 2006, Andre Oppermann wrote:
>
> > Revision ChangesPath
> > 1.299 +9 -6 src/sys/netinet/tcp_input.c
> > 1.87 +286 -255 src/sys/netinet/tcp_syncache.c
> > 1.130 +9 -6 src/sys/netinet/tcp_var.h
On Sat, 17 Jun 2006, Andre Oppermann wrote:
Revision ChangesPath
1.299 +9 -6 src/sys/netinet/tcp_input.c
1.87 +286 -255 src/sys/netinet/tcp_syncache.c
1.130 +9 -6 src/sys/netinet/tcp_var.h
This change appears to have broken world on all architectures by exposi
On Sun, 2 Apr 2006, Peter Jeremy wrote:
On Sat, 2006-Apr-01 16:36:37 +, Robert Watson wrote:
- Annotate the existence of a long-standing race in the TCP timer code,
in which timers are stopped but not drained when the socket is freed,
as waiting for drain may lead to deadlocks, or h
On Sat, 2006-Apr-01 16:36:37 +, Robert Watson wrote:
> - Annotate the existence of a long-standing race in the TCP timer code,
>in which timers are stopped but not drained when the socket is freed,
>as waiting for drain may lead to deadlocks, or have to occur in a
>context where wa
On 2/16/06, Andre Oppermann <[EMAIL PROTECTED]> wrote:
> andre 2006-02-16 19:38:07 UTC
>
> FreeBSD src repository
>
> Modified files:
> sys/netinet tcp_input.c tcp_subr.c tcp_timer.h
> tcp_var.h
> Log:
> Have TCP Inflight disable itself if the RTT
45 matches
Mail list logo
