Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-06 Thread Alexey Dokuchaev
On Wed, Dec 05, 2007 at 02:44:43AM +0600, Max Khon wrote: > Ho! > > Alexey Dokuchaev wrote: > > >>>John Birrell <[EMAIL PROTECTED]> writes: > Log: > Fix strict alias warnings. > >>>A much simpler solution (relative to the previous revision): > >>> > >>>@@ -131,10 +131,10 @@ > >>>

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-05 Thread John Baldwin
On Tuesday 04 December 2007 04:08:21 pm M. Warner Losh wrote: > In message: <[EMAIL PROTECTED]> > Max Laier <[EMAIL PROTECTED]> writes: > : On Tuesday 04 December 2007, Alexey Dokuchaev wrote: > : > On Mon, Dec 03, 2007 at 04:57:33PM -0500, John Baldwin wrote: > : > > On Monday 03 Decem

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-04 Thread Bruce Evans
On Tue, 4 Dec 2007, Max Laier wrote: On Tuesday 04 December 2007, Alexey Dokuchaev wrote: On Mon, Dec 03, 2007 at 04:57:33PM -0500, John Baldwin wrote: On Monday 03 December 2007 10:24:52 am Dag-Erling Sm??rgrav wrote: John Birrell <[EMAIL PROTECTED]> writes: Log: Fix strict alias warnin

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-04 Thread Max Khon
Ho! Alexey Dokuchaev wrote: John Birrell <[EMAIL PROTECTED]> writes: Log: Fix strict alias warnings. A much simpler solution (relative to the previous revision): @@ -131,10 +131,10 @@ sum += oddbyte; } /* "Pseudo-header" data */ - ptr = (u_short *) & (pip->

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-04 Thread M. Warner Losh
In message: <[EMAIL PROTECTED]> Max Laier <[EMAIL PROTECTED]> writes: : On Tuesday 04 December 2007, Alexey Dokuchaev wrote: : > On Mon, Dec 03, 2007 at 04:57:33PM -0500, John Baldwin wrote: : > > On Monday 03 December 2007 10:24:52 am Dag-Erling Sm??rgrav wrote: : > > > John Birrell <[

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-04 Thread Christoph Mallon
Eygene Ryabinkin wrote: Tue, Dec 04, 2007 at 05:25:35PM +, Alexey Dokuchaev wrote: *ptr++ would choke since pointer arith on (void *) is undefined AFAIK. I've been under impression that ++ on void * whould simply increase it by one. This behaviour is documented for GCC: http://www.mcs.vuw

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-04 Thread Eygene Ryabinkin
Tue, Dec 04, 2007 at 05:25:35PM +, Alexey Dokuchaev wrote: > > *ptr++ would choke since pointer arith on (void *) is undefined AFAIK. > > I've been under impression that ++ on void * whould simply increase it > by one. This behaviour is documented for GCC: http://www.mcs.vuw.ac.nz/cgi-bin/inf

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-04 Thread Max Laier
On Tuesday 04 December 2007, Alexey Dokuchaev wrote: > On Mon, Dec 03, 2007 at 04:57:33PM -0500, John Baldwin wrote: > > On Monday 03 December 2007 10:24:52 am Dag-Erling Sm??rgrav wrote: > > > John Birrell <[EMAIL PROTECTED]> writes: > > > > Log: > > > > Fix strict alias warnings. > > > > > >

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-04 Thread Alexey Dokuchaev
On Mon, Dec 03, 2007 at 04:57:33PM -0500, John Baldwin wrote: > On Monday 03 December 2007 10:24:52 am Dag-Erling Sm??rgrav wrote: > > John Birrell <[EMAIL PROTECTED]> writes: > > > Log: > > > Fix strict alias warnings. > > > > A much simpler solution (relative to the previous revision): > >

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-03 Thread John Baldwin
On Monday 03 December 2007 10:24:52 am Dag-Erling Smørgrav wrote: > John Birrell <[EMAIL PROTECTED]> writes: > > Log: > > Fix strict alias warnings. > > A much simpler solution (relative to the previous revision): > > @@ -131,10 +131,10 @@ > sum += oddbyte; > } > /* "

Re: cvs commit: src/sys/netinet/libalias alias_util.c

2007-12-03 Thread Dag-Erling Smørgrav
John Birrell <[EMAIL PROTECTED]> writes: > Log: > Fix strict alias warnings. A much simpler solution (relative to the previous revision): @@ -131,10 +131,10 @@ sum += oddbyte; } /* "Pseudo-header" data */ - ptr = (u_short *) & (pip->ip_dst); + ptr = (void