Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c

2008-02-07 Thread Gleb Smirnoff
On Wed, Feb 06, 2008 at 10:59:32PM -0500, Louis Mamakos wrote: L> I suppose the problem is that I had no expectation that a kernel module, L> would L> consume unbounded amounts of kernel resources. It is bounded. L> I certainly didn't expect L> that L> it would have a need to store "a lot

Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c

2008-02-06 Thread Louis Mamakos
On Feb 5, 2008, at 9:17 AM, Gleb Smirnoff wrote: On Sun, Feb 03, 2008 at 11:36:49AM -0500, Louis Mamakos wrote: L> > Gleb Smirnoff пишет: L> >> you should have asked me for review before committing! This is L> >> not a bug, this is a feature. This was quite clear from the comments, L> >> th

Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c

2008-02-05 Thread Gleb Smirnoff
On Sun, Feb 03, 2008 at 11:36:49AM -0500, Louis Mamakos wrote: L> > Gleb Smirnoff пишет: L> >> you should have asked me for review before committing! This is L> >> not a bug, this is a feature. This was quite clear from the comments, L> >> that you removed: L> >> - /* if export hook disconne

Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c

2008-02-03 Thread Louis Mamakos
On Feb 2, 2008, at 4:31 PM, Alexander Motin wrote: Gleb Smirnoff пишет: you should have asked me for review before committing! This is not a bug, this is a feature. This was quite clear from the comments, that you removed: - /* if export hook disconnected stop running expire(). */ This

Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c

2008-02-02 Thread Alexander Motin
Gleb Smirnoff пишет: you should have asked me for review before committing! This is not a bug, this is a feature. This was quite clear from the comments, that you removed: - /* if export hook disconnected stop running expire(). */ This is intended behavior. We must not lose informatio

Re: cvs commit: src/sys/netgraph/netflow ng_netflow.c

2008-02-02 Thread Gleb Smirnoff
Alexander, you should have asked me for review before committing! This is not a bug, this is a feature. This was quite clear from the comments, that you removed: - /* if export hook disconnected stop running expire(). */ This is intended behavior. We must not lose information unless