Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-08 Thread Robert Watson
On Wed, 8 Oct 2008, John Baldwin wrote: In soreceive_dgram, when a 0-length buffer is passed into recv(2) and no data is ready, return 0 rather than blocking or returning EAGAIN. This is consistent with the behavior of soreceive_generic (soreceive) in earlier versions of FreeBSD, and res

Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-08 Thread John Baldwin
On Wednesday 08 October 2008 02:16:45 am Robert Watson wrote: > On Tue, 7 Oct 2008, John Baldwin wrote: > > > On Tuesday 07 October 2008 04:57:55 pm Robert Watson wrote: > >> rwatson 2008-10-07 20:57:55 UTC > >> > >> FreeBSD src repository > >> > >> Modified files: > >> sys/kern

Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-07 Thread Robert Watson
On Tue, 7 Oct 2008, John Baldwin wrote: On Tuesday 07 October 2008 04:57:55 pm Robert Watson wrote: rwatson 2008-10-07 20:57:55 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: SVN rev 183675 on 2008-10-07 20:57:55Z by rwatson In soreceive_

Re: cvs commit: src/sys/kern uipc_socket.c

2008-10-07 Thread John Baldwin
On Tuesday 07 October 2008 04:57:55 pm Robert Watson wrote: > rwatson 2008-10-07 20:57:55 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > SVN rev 183675 on 2008-10-07 20:57:55Z by rwatson > > In soreceive_dgram, when a 0-lengt

Re: cvs commit: src/sys/kern uipc_socket.c src/sys/netinet udp_usrreq.c src/sys/sys socketvar.h

2008-07-03 Thread Robert Watson
On Thu, 3 Jul 2008, Bjoern A. Zeeb wrote: Add soreceive_dgram(9), an optimized socket receive function for use by datagram-only protocols, such as UDP. This version removes use of sblock(), which is not required due to an inability to interlace data improperly with datagrams, as well as av

Re: cvs commit: src/sys/kern uipc_socket.c src/sys/netinet udp_usrreq.c src/sys/sys socketvar.h

2008-07-03 Thread Bjoern A. Zeeb
On Wed, 2 Jul 2008, Robert Watson wrote: rwatson 2008-07-02 23:23:27 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c sys/netinet udp_usrreq.c sys/sys socketvar.h Log: SVN rev 180198 on 2008-07-02 23:23:27Z by rwatson Add so

Re: cvs commit: src/sys/kern uipc_socket.c src/sys/sys protosw.h socket.h

2008-04-14 Thread Robert Watson
On Mon, 14 Apr 2008, Randall Stewart wrote: Add pru_flush routine so a transport can flush itself during Shutdown MFC after: 1 week I'm not sure this is an MFCable change because: (a) The new function pointer is inserted in the middle of the data protosw data structure, changing

Re: cvs commit: src/sys/kern uipc_socket.c

2007-08-23 Thread Frank Behrens
JINMEI Tatuya <[EMAIL PROTECTED]> wrote on 23 Aug 2007 18:17: > jinmei 2007-08-23 18:17:08 UTC > > FreeBSD src repository > > Modified files:(Branch: RELENG_6) > sys/kern uipc_socket.c > Log: > MFC: > Fix a kernel panic based on receiving an ICMPv6 Packet

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread Daniel O'Connor
On Tuesday 23 January 2007 01:29, Andre Oppermann wrote: > > Is there any progress in fixing this bug? > > Just fixed. The regression test passes and I hope KDE too. I just tested it - yes it fixes the problem with unlocking the KDE screensaver. Thanks! -- Daniel O'Connor software and network

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread John Baldwin
On Monday 22 January 2007 10:01, Andre Oppermann wrote: > John Baldwin wrote: > > Also, you've introduced another regression in that if the m_get2m() fails it > > should be returning ENOBUFS and not EFAULT to userland. The comments in > > sosend_*() about 'EFAULT being the only possible error' ar

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread Andre Oppermann
John Baldwin wrote: On Thursday 02 November 2006 12:45, Andre Oppermann wrote: andre 2006-11-02 17:45:28 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Use the improved m_uiotombuf() function instead of home grown sosend_copyin() to do

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-22 Thread Andre Oppermann
Andrey Chernov wrote: On Fri, Jan 12, 2007 at 12:06:46PM -0500, John Baldwin wrote: On Thursday 02 November 2006 12:45, Andre Oppermann wrote: andre 2006-11-02 17:45:28 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Use the improved m_ui

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-21 Thread Andrey Chernov
On Fri, Jan 12, 2007 at 12:06:46PM -0500, John Baldwin wrote: > On Thursday 02 November 2006 12:45, Andre Oppermann wrote: > > andre 2006-11-02 17:45:28 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern uipc_socket.c > > Log: > > Use the improv

Re: cvs commit: src/sys/kern uipc_socket.c

2007-01-12 Thread John Baldwin
On Thursday 02 November 2006 12:45, Andre Oppermann wrote: > andre 2006-11-02 17:45:28 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > Use the improved m_uiotombuf() function instead of home grown > sosend_copyin() > to do the

Re: cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_socket.c atm_usrreq.c atm

2006-04-09 Thread Robert Watson
On Sun, 9 Apr 2006, Pawel Jakub Dawidek wrote: +> -static int +> +static void +> ngd_detach(struct socket *so) +> { +> struct ngpcb *const pcbp = sotongpcb(so); +> +> - if (pcbp == NULL) +> - return (EINVAL); +> + KASSERT(pcbp == NULL, ("ngd_detach: pcbp == NULL")); From what I see

Re: cvs commit: src/sys/kern uipc_socket.c uipc_socket2.c uipc_usrreq.c src/sys/net raw_cb.c raw_usrreq.c rtsock.c src/sys/netatalk ddp_usrreq.c src/sys/netatm atm_aal5.c atm_socket.c atm_usrreq.c atm

2006-04-09 Thread Pawel Jakub Dawidek
On Sat, Apr 01, 2006 at 03:42:02PM +, Robert Watson wrote: +> rwatson 2006-04-01 15:42:02 UTC +> +> FreeBSD src repository +> +> Modified files: +> sys/kern uipc_socket.c uipc_socket2.c +> uipc_usrreq.c +> sys/net raw_cb.c ra

Re: cvs commit: src/sys/kern uipc_socket.c

2006-03-15 Thread Alfred Perlstein
1) apologies for top posting 2) cool, thanks for the explanation, I wasn't aware that this was a cleanup step and was hoping it wasn't another ad-hoc reference counting "fix". This looks good. * Robert Watson <[EMAIL PROTECTED]> [060315 05:48] wrote: > > Socket and PCB reference counting is curr

Re: cvs commit: src/sys/kern uipc_socket.c

2006-03-15 Thread Robert Watson
On Wed, 15 Mar 2006, Alfred Perlstein wrote: Modified files: sys/kern uipc_socket.c Log: As with socket consumer references (so_count), make sofree() return without GC'ing the socket if a strong protocol reference to the socket is present (SS_PROTOREF). This stuff is

Re: cvs commit: src/sys/kern uipc_socket.c

2006-03-15 Thread Alfred Perlstein
* Robert Watson <[EMAIL PROTECTED]> [060315 04:45] wrote: > rwatson 2006-03-15 12:45:35 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > As with socket consumer references (so_count), make sofree() return > without GC'ing the sock

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Mike Silbersack
On Mon, 5 Dec 2005, Robert Watson wrote: The NFS server could could probably profitably, and fairly easily, be taught how to do zero-copy from the buffer/page cache, btw. Should be able to steal code from sendfile(), although I've not looked in any detail. Possibly also the NFS client. Ro

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Robert Watson
On Mon, 5 Dec 2005, Mike Silbersack wrote: On Mon, 5 Dec 2005, Robert Watson wrote: (3) Enhance m_uiotombuf() so that it can either be trivially wrapped by sosend_copyin(), or replace it. At the very least, this means adding zero-copy support to m_uiotombuf(), but I've not looked at th

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Mike Silbersack
On Mon, 5 Dec 2005, Robert Watson wrote: (3) Enhance m_uiotombuf() so that it can either be trivially wrapped by sosend_copyin(), or replace it. At the very least, this means adding zero-copy support to m_uiotombuf(), but I've not looked at this much. Sounds good, I just wanted to make

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-05 Thread Robert Watson
On Sun, 4 Dec 2005, Mike Silbersack wrote: On Mon, 28 Nov 2005, Robert Watson wrote: Break out functionality in sosend() responsible for building mbuf chains and copying in mbufs from the body of the send logic, creating a new function sosend_copyin(). This changes makes sosend() almost r

Re: cvs commit: src/sys/kern uipc_socket.c

2005-12-04 Thread Mike Silbersack
On Mon, 28 Nov 2005, Robert Watson wrote: Break out functionality in sosend() responsible for building mbuf chains and copying in mbufs from the body of the send logic, creating a new function sosend_copyin(). This changes makes sosend() almost readable, and will allow the same logic to be

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Wilko Bulte
On Wed, Nov 30, 2005 at 09:47:27AM +, Robert Watson wrote.. > > On Wed, 30 Nov 2005, Dag-Erling Smørgrav wrote: > > >Robert Watson <[EMAIL PROTECTED]> writes: > >>Thanks for fixing this -- I ran this patch in testing for ages, but > >>must have done some "clean up" or other such 99.85% harmle

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread John Baldwin
On Wednesday 30 November 2005 04:20 am, Robert Watson wrote: > On Tue, 29 Nov 2005, John Baldwin wrote: > > Fix snderr() to not leak the socket buffer lock if an error occurs in > > sosend(). Robert accidentally changed the snderr() macro to jump to the > > out label which assumes the lock is a

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Robert Watson
On Wed, 30 Nov 2005, Dag-Erling Smørgrav wrote: Robert Watson <[EMAIL PROTECTED]> writes: Thanks for fixing this -- I ran this patch in testing for ages, but must have done some "clean up" or other such 99.85% harmless activity :-(. And how many years have you been drinking from glasses...?

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Dag-Erling Smørgrav
Robert Watson <[EMAIL PROTECTED]> writes: > Thanks for fixing this -- I ran this patch in testing for ages, but > must have done some "clean up" or other such 99.85% harmless activity > :-(. And how many years have you been drinking from glasses...? *ducks* *runs* DES -- Dag-Erling Smørgrav - [

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-30 Thread Robert Watson
On Tue, 29 Nov 2005, John Baldwin wrote: Fix snderr() to not leak the socket buffer lock if an error occurs in sosend(). Robert accidentally changed the snderr() macro to jump to the out label which assumes the lock is already released rather than the release label which drops the lock in

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-29 Thread John Baldwin
On Tuesday 29 November 2005 06:07 pm, John Baldwin wrote: > jhb 2005-11-29 23:07:14 UTC > > FreeBSD src repository > > Modified files: > sys/kern uipc_socket.c > Log: > Fix snderr() to not leak the socket buffer lock if an error occurs in > sosend(). Robert accide

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-29 Thread John Baldwin
On Tuesday 29 November 2005 02:47 pm, Bjoern A. Zeeb wrote: > On Mon, 28 Nov 2005, Robert Watson wrote: > > rwatson 2005-11-28 18:09:03 UTC > > > > FreeBSD src repository > > > > Modified files: > >sys/kern uipc_socket.c > > Log: > > Break out functionality in sosend() respo

Re: cvs commit: src/sys/kern uipc_socket.c

2005-11-29 Thread Bjoern A. Zeeb
On Mon, 28 Nov 2005, Robert Watson wrote: rwatson 2005-11-28 18:09:03 UTC FreeBSD src repository Modified files: sys/kern uipc_socket.c Log: Break out functionality in sosend() responsible for building mbuf chains and copying in mbufs from the body of the send logic, cr