Re: cvs commit: src/sys/kern kern_synch.c

2006-12-07 Thread Poul-Henning Kamp
In message <[EMAIL PROTECTED]>, Alexey Dokuchaev writes: >On Thu, Nov 30, 2006 at 08:27:38AM +, Poul-Henning Kamp wrote: >> phk 2006-11-30 08:27:38 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/kern kern_synch.c >> Log: >> Only grab the sched_l

Re: cvs commit: src/sys/kern kern_synch.c

2006-12-07 Thread Alexey Dokuchaev
On Thu, Nov 30, 2006 at 08:27:38AM +, Poul-Henning Kamp wrote: > phk 2006-11-30 08:27:38 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_synch.c > Log: > Only grab the sched_lock if we actually need to modify the thread priority. > > Du

Re: cvs commit: src/sys/kern kern_synch.c

2006-02-22 Thread Dag-Erling Smørgrav
Jeff Roberson <[EMAIL PROTECTED]> writes: > The api used to be mtx_enter(). It's nice to have consistent > comments so we don't confuse new developers or non-native english > speakers. especially when "mtx_enter()" suggests the use of mutexes to protect code, while the policy in FreeBSD is to use

Re: cvs commit: src/sys/kern kern_synch.c

2006-02-22 Thread John Baldwin
On Wednesday 22 February 2006 15:58, Jeff Roberson wrote: > On Wed, 22 Feb 2006, Colin Percival wrote: > > > John Baldwin wrote: > >> Log: > >> Fixup some comments. Mutexes's are locked, not entered for several years > > > > What's the difference? I thought "lock a mutex", "enter a mutex", a

Re: cvs commit: src/sys/kern kern_synch.c

2006-02-22 Thread Jeff Roberson
On Wed, 22 Feb 2006, Colin Percival wrote: John Baldwin wrote: Log: Fixup some comments. Mutexes's are locked, not entered for several years What's the difference? I thought "lock a mutex", "enter a mutex", and "pick up a lock" were all interchangeable. The api used to be mtx_enter().

Re: cvs commit: src/sys/kern kern_synch.c

2006-02-22 Thread Colin Percival
John Baldwin wrote: > Log: > Fixup some comments. Mutexes's are locked, not entered for several years What's the difference? I thought "lock a mutex", "enter a mutex", and "pick up a lock" were all interchangeable. Colin Percival ___ cvs-all@freeb

Re: cvs commit: src/sys/kern kern_synch.c src/sys/sys systm.h

2005-12-29 Thread John Baldwin
On Thursday 29 December 2005 03:57 pm, John Baldwin wrote: > jhb 2005-12-29 20:57:45 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_synch.c > sys/sys systm.h > Log: > Add a new function msleep_spin() which is a slightly stripped d