Re: cvs commit: src/sys/kern kern_descrip.c kern_ktrace.c uipc_syscalls.c vfs_syscalls.c src/sys/sys ktrace.h src/usr.bin/kdump kdump.1 kdump.c mksubr src/usr.bin/ktrace ktrace.1 ktrace.h subr.c

2008-08-12 Thread Dag-Erling Smørgrav
Peter Jeremy <[EMAIL PROTECTED]> writes: > Are you going to MFC this? I've back-ported the code and it works > well. Working on it. DES -- Dag-Erling Smørgrav - [EMAIL PROTECTED] ___ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/li

Re: cvs commit: src/sys/kern kern_descrip.c kern_ktrace.c uipc_syscalls.c vfs_syscalls.c src/sys/sys ktrace.h src/usr.bin/kdump kdump.1 kdump.c mksubr src/usr.bin/ktrace ktrace.1 ktrace.h subr.c

2008-08-10 Thread Peter Jeremy
Hi Dag-Erling, On 2008-Feb-23 01:01:49 +, Dag-Erling Smorgrav <[EMAIL PROTECTED]> wrote: > Log: > This patch adds a new ktrace(2) record type, KTR_STRUCT, whose payload > consists of the null-terminated name and the contents of any structure > you wish to record. A new ktrstruct() functio

Re: cvs commit: src/sys/kern kern_descrip.c

2008-05-29 Thread Bruce Evans
On Thu, 29 May 2008, Ed Schouten wrote: * Robert Watson <[EMAIL PROTECTED]> wrote: This sounds like a good candidate for a regression test -- do we have a dup/dup2/F_DUPFD/F_DUP2FD test? If not, perhaps we should, in light of the opportunity for further bugs and regressions. It looks like we

Re: cvs commit: src/sys/kern kern_descrip.c

2008-05-29 Thread Antoine Brodin
On Thu, May 29, 2008 at 10:24 AM, Ed Schouten <[EMAIL PROTECTED]> wrote: > * Robert Watson <[EMAIL PROTECTED]> wrote: >> >> On Wed, 28 May 2008, Ed Schouten wrote: >> >>> Remove redundant checks from fcntl()'s F_DUPFD. >>> >>> Right now we perform some of the checks inside the fcntl()'s F_DUPFD >

Re: cvs commit: src/sys/kern kern_descrip.c

2008-05-29 Thread Ed Schouten
* Robert Watson <[EMAIL PROTECTED]> wrote: > > On Wed, 28 May 2008, Ed Schouten wrote: > >> Remove redundant checks from fcntl()'s F_DUPFD. >> >> Right now we perform some of the checks inside the fcntl()'s F_DUPFD >> operation twice. We first validate the `fd' argument. When finished, >> we va

Re: cvs commit: src/sys/kern kern_descrip.c

2008-05-29 Thread Robert Watson
On Wed, 28 May 2008, Ed Schouten wrote: Remove redundant checks from fcntl()'s F_DUPFD. Right now we perform some of the checks inside the fcntl()'s F_DUPFD operation twice. We first validate the `fd' argument. When finished, we validate the `arg' argument. These checks are also performed

Re: cvs commit: src/sys/kern kern_descrip.c src/sys/sys file.h

2008-05-28 Thread John Baldwin
On Sunday 25 May 2008 10:57:43 am Attilio Rao wrote: > attilio 2008-05-25 14:57:43 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_descrip.c > sys/sys file.h > Log: > Replace direct atomic operation for the file refcount witht the

Re: cvs commit: src/sys/kern kern_descrip.c

2008-04-26 Thread Kris Kennaway
On Fri, Apr 25, 2008 at 03:04:59PM +0200, Roman Divacky wrote: > On Thu, Apr 24, 2008 at 10:08:36PM +, Kris Kennaway wrote: > > kris2008-04-24 22:08:36 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_descrip.c > > Log: > > fdhold c

Re: cvs commit: src/sys/kern kern_descrip.c

2008-04-25 Thread Roman Divacky
On Thu, Apr 24, 2008 at 10:08:36PM +, Kris Kennaway wrote: > kris2008-04-24 22:08:36 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_descrip.c > Log: > fdhold can return NULL, so add the one remaining missing check for this > condition.

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-25 Thread Robert Watson
On Tue, 24 Jul 2007, Jeremie Le Hen wrote: On Mon, Jul 23, 2007 at 05:38:35PM -0700, Julian Elischer wrote: I think that is the wrong question.. the question is "why do we drop off after 8?" which I'm sure Jeff is already working on. Actually since the workbench has been run on an 8-core

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-24 Thread Jeff Roberson
On Tue, 24 Jul 2007, Jeremie Le Hen wrote: On Mon, Jul 23, 2007 at 05:38:35PM -0700, Julian Elischer wrote: I think that is the wrong question.. the question is "why do we drop off after 8?" which I'm sure Jeff is already working on. Actually since the workbench has been run on an 8-core a

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-24 Thread Julian Elischer
Jeremie Le Hen wrote: On Mon, Jul 23, 2007 at 05:38:35PM -0700, Julian Elischer wrote: I think that is the wrong question.. the question is "why do we drop off after 8?" which I'm sure Jeff is already working on. Actually since the workbench has been run on an 8-core amd64 and that both Lin

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-24 Thread Jeremie Le Hen
On Mon, Jul 23, 2007 at 05:38:35PM -0700, Julian Elischer wrote: > I think that is the wrong question.. > the question is "why do we drop off after 8?" > which I'm sure Jeff is already working on. Actually since the workbench has been run on an 8-core amd64 and that both Linux and FreeBSD drop

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-23 Thread Julian Elischer
Jeremie Le Hen wrote: Hi Jeff, On Tue, Jul 03, 2007 at 02:27:51PM -0700, Jeff Roberson wrote: For the curious, these last two patches make a substantial improvement to mysql write performance on my 8way opteron: http://people.freebsd.org/~jeff/mysqlwrite.png The green line is without and

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-23 Thread Jeff Roberson
On Mon, 23 Jul 2007, Attilio Rao wrote: 2007/7/23, Jeremie Le Hen <[EMAIL PROTECTED]>: Hi Jeff, On Tue, Jul 03, 2007 at 02:27:51PM -0700, Jeff Roberson wrote: > For the curious, these last two patches make a substantial improvement to > mysql write performance on my 8way opteron: > > htt

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-23 Thread Attilio Rao
2007/7/23, Jeremie Le Hen <[EMAIL PROTECTED]>: Hi Jeff, On Tue, Jul 03, 2007 at 02:27:51PM -0700, Jeff Roberson wrote: > For the curious, these last two patches make a substantial improvement to > mysql write performance on my 8way opteron: > > http://people.freebsd.org/~jeff/mysqlwrite.png >

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-23 Thread Jeremie Le Hen
Hi Jeff, On Tue, Jul 03, 2007 at 02:27:51PM -0700, Jeff Roberson wrote: > For the curious, these last two patches make a substantial improvement to > mysql write performance on my 8way opteron: > > http://people.freebsd.org/~jeff/mysqlwrite.png > > The green line is without and the blue lin

Re: cvs commit: src/sys/kern kern_descrip.c

2007-07-03 Thread Jeff Roberson
For the curious, these last two patches make a substantial improvement to mysql write performance on my 8way opteron: http://people.freebsd.org/~jeff/mysqlwrite.png The green line is without and the blue line is with. Thanks, Jeff On Tue, 3 Jul 2007, Jeff Roberson wrote: jeff2007-07

Re: cvs commit: src/sys/kern kern_descrip.c uipc_usrreq.c src/sys/sys file.h

2007-01-12 Thread Rong-en Fan
On 1/13/07, John Baldwin <[EMAIL PROTECTED]> wrote: jhb 2007-01-12 16:21:29 UTC FreeBSD src repository Modified files:(Branch: RELENG_6) sys/kern kern_descrip.c uipc_usrreq.c sys/sys file.h Log: MFC: Close a race between UNIX domain pcb g

Re: cvs commit: src/sys/kern kern_descrip.c

2006-03-19 Thread Gleb Smirnoff
On Sat, Mar 18, 2006 at 11:27:22PM +, Christian S.J. Peron wrote: C> csjp2006-03-18 23:27:22 UTC C> C> FreeBSD src repository C> C> Modified files: C> sys/kern kern_descrip.c C> Log: C> Back out fd optimization introduced in revision 1.280 as it appears to be

Re: cvs commit: src/sys/kern kern_descrip.c

2006-03-18 Thread Wojciech A. Koszek
On sob, mar 18, 2006 at 11:27:22 +, Christian S.J. Peron wrote: > csjp2006-03-18 23:27:22 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_descrip.c > Log: [..] > "0" in some cases. Further, this change also breaks some MAC interactions > wi

Re: cvs commit: src/sys/kern kern_descrip.c

2006-01-06 Thread Scott Long
John Baldwin wrote: On Friday 06 January 2006 11:34 am, Scott Long wrote: John Baldwin wrote: jhb 2006-01-06 16:30:30 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c Log: Return EBADF rather than EINVAL for FWRITE failure as per POSIX. MFC aft

Re: cvs commit: src/sys/kern kern_descrip.c

2006-01-06 Thread John Baldwin
On Friday 06 January 2006 11:34 am, Scott Long wrote: > John Baldwin wrote: > > jhb 2006-01-06 16:30:30 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/kern kern_descrip.c > > Log: > > Return EBADF rather than EINVAL for FWRITE failure as per POSIX

Re: cvs commit: src/sys/kern kern_descrip.c

2006-01-06 Thread Tom Rhodes
On Fri, 6 Jan 2006 16:30:30 + (UTC) John Baldwin <[EMAIL PROTECTED]> wrote: > jhb 2006-01-06 16:30:30 UTC > > FreeBSD src repository > > Modified files: > sys/kern kern_descrip.c > Log: > Return EBADF rather than EINVAL for FWRITE failure as per POSIX. Thank

Re: cvs commit: src/sys/kern kern_descrip.c

2006-01-06 Thread Scott Long
John Baldwin wrote: jhb 2006-01-06 16:30:30 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c Log: Return EBADF rather than EINVAL for FWRITE failure as per POSIX. MFC after: 1 week Revision ChangesPath 1.290 +2 -3

Re: cvs commit: src/sys/kern kern_descrip.c

2005-11-19 Thread Mike Silbersack
On Thu, 17 Nov 2005, Robert Watson wrote: Add a DDB "show files" command to list the current open file list, some state about each open file, and identify the first process in the process table that references the file. This is helpful in debugging leaks of file descriptors. Than

Re: cvs commit: src/sys/kern kern_descrip.c

2005-11-10 Thread Robert Watson
On Thu, 10 Nov 2005, Robert Watson wrote: rwatson 2005-11-10 11:35:59 UTC FreeBSD src repository Modified files: sys/kern kern_descrip.c Log: Expanet of details printed for each file descriptor to include it's Editor braino: should read "Expand the set". Not worth a