I built NgHTTP2 some days ago using MSVC 2010. I was amazed
of how easy it was. Not very Unix/Posix centric at all. But using the
first little merge of nghttp2 into libcurl, I stumbeled on the missing
'snprintf' in MSVCRT. Isn't this how we do it for other libcurl files?
I.e. use 'curl_msnprintf'
"m brandenberg" wrote:
So these and other issues make me want to use the system resolver
library. When it fails, there's a general system/network
configuration issue that doesn't become a support issue for us.
I tend to agree. The systems resolver seems alway to work best
for me. At least wh
I'm having some success with HTTP 2.0 using the NgHTTP2 test server
http://106.186.112.116/ . I don't suppose there are other HTTP 2.0 servers
I can test with?
The problem is some extra garbage in the start and end of output. Using this
command
curl --http2.0 http://106.186.112.116/
Gives thi
"Daniel Stenberg" wrote:
I have a few local commits that make it slightly better but recently I've hit
a little obstacle in nghttp2's API that I've been communicating with Tatsuhiro
about how to solve[1]. I hope to be able to get something done on that soon so
that I can get a first HTTP2 dow
"Daniel Stenberg" wrote:
On Thu, 26 Sep 2013, Tatsuhiro Tsujikawa wrote:
But SPDY will disappear when HTTP/2.0 is standardized, so there may be less
incentive to invest the time to support SPDY now, but YMMV.
Exactly. SPDY was pioneered by Google and it is now being offered on many
servers
lib/curl_setup_once.h assumes lwIP on Windows uses 'SetLastError()'
to set network errors. It doesn't; it uses 'errno'. Hence this little
patch:
--- g:/MingW32/src/inet/curl/Git-latest/lib/curl_setup_once.h 2013-02-23
19:58:58 +
+++ g:/MingW32/src/inet/curl/lib/curl_setup_once.h 2013-
Patch docs/examples/httpput.c for MSVC since it's missing :
--- Git-latest/docs/examples/httpput.c 2013-01-28 15:48:38 +
+++ docs/examples/httpput.c2013-10-09 11:54:26 +
@@ -22,7 +22,9 @@
#include
#include
#include
-#include
+#ifndef _MSC_VER
+# include
+#endif
#include
-
"Myria" wrote:
I noticed that Windows does not define HAVE_GMTIME_R or HAVE_LOCALTIME_R.
It is true that Visual Studio's C runtime library doesn't have gmtime_r, but
it has a somewhat-equivalent API, gmtime_s. gmtime_s's prototype is
different, reversing the order of the two parameters and r
"Dan Fandrich" wrote:
But I'm not sure is needed at all.
It's needed for close(2). But the only reason that's needed is because fstat
is used instead of stat(2); if you fix that, then you could remove that
include altogether.
Okay. I've tested the following with MSVC and MingW. htttput.c n
Something to add to http://curl.haxx.se/libcurl/using/apps.html
PeerBlock [1] lets you control who your computer "talks to" on the Internet.
By selecting appropriate lists of "known bad" computers, you can block
communication with advertising or spyware oriented servers...
The PeerBlock prog
"??" <506017...@qq.com> wrote:
headerlist = curl_slist_append(headerlist, "rm abc.c");
result = curl_easy_setopt(curl, CURLOPT_POSTQUOTE, headerlist);
Maybe the command should be "dele abc.c" under this SFTP-server.
--gv
-
"Steve Holme" wrote:
Whilst this has fixed the native VC12 builds [1] I seem to have broken the
mingw [2] auto builds :(
I'm guessing that these builds don't pull in the same header files as native
build do, so does anyone know what I need to include?
For those functions to work, -D_WIN32_
"Steve Holme" wrote:
Cheers Gisle... Can I simply change my current pre-processor check from:
#if !defined(VerifyVersionInfo)
To:
#if (_WIN32_WINNT < _WIN32_WINNT_WIN2K)
Or do I need something a little more complicated where I check that
_WIN32_WINNT and _WIN32_WINNT_WIN2K are defined as
Something is wrong in 'userp' for the HTTP2 recv_callback().
The session is created using bogus user-data; '&conn' and not
'conn'.
I noticed this since the socket-value in Curl_read_plain() was set to a
impossible high value. A patch:
--- orig/http2.c" 2014-01-29 15:19:25 +
+++ http2.c
Something is wrong in 'userp' for the HTTP2 recv_callback().
Another patch for http2.c; the number of elements in the
'nghttp2_session_callbacks' structure is now reduced by 2 in
version 0.3.0 (I'm not sure when the change happened, but
checking for ver 0.3.0 work for me).
The excess initial
"Fabian Frank" wrote:
Do we already want to introduce ifdefs for backwards compatibility at this point? HTTP2 and nghttp2 are moving
so fast and nothing is finalized yet, so it might make the code easier to maintain in the long run if we
just mandate an exact (or the latest) nghttp2 version un
"ansh kumar" wrote:
Okay I've removed \0 from the buffer size.
1) I want to know why I'm getting following error if I use
CURLOPT_INFILESIZE_LARGE option instead of CURLOPT_INFILESIZE :
MAIL FROM: SIZE=141949047089924518
Did you cast the CURLOPT_INFILESIZE_LARGE argument (the file_size)
to
wrote:
../lib/curl-strtoofft.o ../lib/curl-strdup.o ../lib/curl-rawstr.o
../lib/curl-nonblock.o -L/path/to/mingw32/lib ../lib/.libs/libcurl.a
-lgdi32 -lssl -lcrypto -lwldap32 -lz -lws2_32
/path/to/mingw32/lib/libcrypto.a(rand_win.o):rand_win.c:(.text+0x1070):
undefined reference to `_imp__Crea
wrote:
LIBOBJS =
LIBS = -lssl -lcrypto -lgdi32 -lssl -lcrypto -lwldap32 -lz -lws2_32
Why is '-lcrypto' given twice? That could be your problem.
../lib/curl-nonblock.o -L/path/to/mingw32/lib ../lib/.libs/libcurl.a
-lgdi32 -lssl -lcrypto -lwldap32 -lz -lws2_32
/path/to/mingw32/lib/libcrypto
"GitHub" wrote:
Changed paths:
M lib/Makefile.Watcom
M src/Makefile.Watcom
Log Message:
---
Rework Open Watcom make files to use standard Wmake features
Jiri, Daniel.
Can one of you please change my email-address in those headers?
To: gva...@yahoo.no. And since these files
"Steve Holme" wrote:
Would it better to change the header to our standard libcurl
licence/disclaimer/header just like in makefile.vc6?
I appreciate I may have just volunteered for the task if folk agree ;-)
I have attached something like that. Just went through the git-history
and pulled out
"Petr Ent" wrote:
I assumed that since command line curl accepted target path without
the filename, library would behave the same. Clearly I was wrong :).
Anyway, I think something like "In upload mode, CURLOPT_URL must
contain full path including filename" would help a lot.
A "full target pa
The debug messages printed inside PolarSSL always seems to end with a
newline. So 'infof()' should not add one. Besides the trace 'line' should be
'const'. Patch:
--- Git-latest/lib/vtls/polarssl.c 2014-03-19 23:24:29 +
+++ lib/vtlspolarssl.c" 2014-03-22 16:09:41 +
@@ -104,7 +104,7
I note that 'data->state.os_errno' is not set in many places. Only some
places around send(), bind() etc. What if 'curl_easy_getinfo
(..CURLINFO_OS_ERRNO..)'
is called to retrieve the OS-error when thing fails?
I do note the man-page says "connect failure". But things can fail before a
connect()
"Daniel Stenberg" wrote:
I get a different server but I did this:
./src/curl -v --http2 https://www.google.com
* Trying 173.194.32.20...
* Connected to www.google.com (173.194.32.20) port 443 (#0)
* NPN, negotiated HTTP2
* We have switched to HTTP2
* http2_send len=82
* before_frame_send()
"Daniel Stenberg" wrote:
I don't even know if PolarSSL supports those TLS extensions.
I don't think so.
You using a recent nghttp2? (I'm at v0.3.1-182-g8ccb6e4 right now, the current
git HEAD)
I built with NgHttp2 from today. But AFAICS, google is doing it right. The UTF-8
("ASCII garbage
"Gisle Vanem" wrote:
05C0: 3E 54 68 61 74 E2 80 99 73 20 61 6E 20 65 72 72 >ThatOCOs an err
05D0: 6F 72 2E 3C 2F 69 6E 73 3E 0A 20 20 3C 70 3E 59 or.. Y
05E0: 6F 75 72 20 63 6C 69 65 6E 74 20 68 61 73 20 69 our client has i
05F0: 73 73 75 65 64 20 61 20 6D 61 6C 6
Author: Steve Holme
Date: 2014-04-09 (Wed, 09 Apr 2014)
Changed paths:
M Makefile.am
A projects/Windows/VC9/.gitignore
A projects/Windows/VC9/curl.sln
Shouldn't these be put in 'packages/Win32/VC9' instead?
Or maybe 'packages/Win32/Visual-C/VC9'?
The term 'package' is used in e.
"Steve Holme" wrote:
really mind. I'd rather not move the directory into a Visual-C directory as
a) That will require an update to all the files, both the ones I've commited
as well as the ones I have pending, for the relative paths and b) Having
Visual-C\VC6 includes the name twice when you ex
"Priyanka Shah" wrote:
And this is the callback's implementation:
int sockopt_callback(void *clientp, curl_socket_t curlfd, curlsocktype
purpose)
{
if(clientp == NULL) {
printf("error");
return CURL_SOCKOPT_OK;
}
uint32_t data = *(uint32_t*)
"Daniel Stenberg" wrote:
I would say that in all cases where we use errno in libcurl to check for
success or failure, if we then fail we should store errno in
data->state.os_errno. Does that sound reasonable?
Yes, this OS-error (or errno) could be useful to the caller.
That of course leads
"Jon Torrey" wrote:
I thought by default I didn't need to define SSL as libcurl by default will
use Windows SSPI?
No way!
Anywho, I made the following change
On line 56 of Makefile.b32 I have :
DEFINES = -DNDEBUG -DWIN32 -DBUILDING_LIBCURL -DCURL_STATICLIB -USE_SSL
Everything builds fin
"Alona Rossen" wrote:
We use the following protocols:
BASIC
DIGEST
GSS_Negotiate
NTLM
Digest_IE
IFIS_Delegation
Does any of these involve ldap ?
No, but why is it a problem that OpenSSL libs are in the dependencies
twice? I assume ldap.so need SSL for secure ldap. Same for libsasl*.so.
-
"Jon Torrey" wrote:
Also - if anyone happens to have an INTEGRITY config file and could send me
it as an example that would be greatly appreciated.
You can probably get some ideas from the lwIP tcp/ip "hacks"
built into libcurl. The lwIP + Windows combo actually works with
some glue code for
Changed paths:
M lib/curl_sasl_sspi.c
Log Message:
---
sasl_sspi: Fixed SPN not being converted to wchar under Unicode builds
Now it seems only ldap.c is not UNICODE compatible. From MSVC
compile of ldap.c with -D_UNICODE:
ldap.c(219) : warning C4133: 'function' : incompatible t
"Steve Holme" wrote:
Hehehe - Slight slip of the keyboard there but in some respects relevant ;-)
However, I meant "comments are welcome".
I'm not sure, but maybe a simple:
#undef _UNICODE
#undef UNICODE
at the top of ldap.c should work. Otherwise things like 'struct hostname::name'
in ur
"Daniel Stenberg" wrote:
On Tue, 26 Aug 2014, dushyant kumar wrote:
I am trying to upload a file in a server using libcurl.
Program works fine for small files (upto 5-6 GB ), however for very big
files (more than 10 GB), it continues uploading even after the upload is
over (By looking int
"Tatsuhiro Tsujikawa" wrote:
totally agree with you. Should I include this change to the patch?
Some other trouble I'm fighting with. In include/nghttp2/nghttp2.h the
comment says:
* Callback functions for :type:`nghttp2_session`. The details of
* this structure are intentionally hidden
"Daniel Karunairatnam" wrote:
okay, so i opened one of those. but the librarian node isn't there. Which
configuration do i need to change it to to access the librarian node? The
instructions in the link you posted before require some changes there.
I have no idea. But CmakeFiles seems more up
Jan Ehrhardt wrote
Correction:
The same happens with WITH_SSH2=static. I am building against LIBSSH2
1.4.3. Curl 7.38.0 builded fine. Any idea what I am missing?
Nothing. I noted that too and commented on it here:
https://github.com/bagder/curl/commit/fa7d04fed4d4578fe29bdff0b5465f6e4a7da81a
Patrick Monnerat wrote:
Downloading a SMB file larger than 16K (CURL_MAX_WRITE_SIZE) with a
DEBUGBUILD curl gives:
Warning: Data size exceeds single call write limit!
and the corresponding data is lost.
I noted this too, but "curl -i smb://local-url" removes this warning.
I have no
Jeroen Ooms wrote:
#define MAKE_OPTION(a) {#a, CURLOPT_##a}
typedef struct {
char name[40];
int val;
} keyval;
keyval curl_options[] = {
MAKE_OPTION(MUTE),
MAKE_OPTION(ACCEPT_ENCODING),
... etc
};
But currently this fails when calling MAKE_OPTION with an undefined symbol.
Is th
Félix Robles wrote:
curl-tool_xattr.o ../lib/curl-strtoofft.o ../lib/curl-rawstr.o
../lib/curl-nonblock.o ../lib/curl-warnless.o
-L/usr/local/ssl/lib ../lib/.libs/libcurl.a -lgdi32 -lssl -lcrypto -lws2_32
'-lgdi32' must come after the libs using it. So:
-L/usr/local/ssl/lib ../lib/.libs/l
The combination BoringSSL and '-DUSE_WIN32_LDAP'
doesn't work since 'X509_NAME' etc. are defined in
as:
#define X509_NAME (LPCSTR) 7
...
Which causes the compilation of "x509.h" (from "urldata.h")
to fail (cpp output):
typedef struct X509_name_st
{
struct stack_st_X509_NAME_ENTRY *entries
Daniel Stenberg wrote:
Interestingly, even OpenSSL has X509_NAME as a typedef, but I figure it
is in a header not as commonly included so it hasn't hurt us in this case.
OpenSSL's "x509.h" already has these undefs:
#ifdef OPENSSL_SYS_WIN32
/* Under Win32 these are defined in wincrypt.h */
The folks at OpenSSL have been very busy cleaning up
it's API. So much that it broken vtls/openssl.c:
vtls/openssl.c(1670) : error C2037: left of 'ssl_version' specifies
undefined struct/union 'ssl_session_st'
for the statement:
switch(session->ssl_version) {
'struct ssl_session_st' is n
Josh Angstadt wrote:
Hi, I tried to use the write options as well, but when I used those I got an
error from the
> connection, speciifcally error code 23
23 == CURLE_WRITE_ERROR. Look at:
https://raw.githubusercontent.com/bagder/curl/master/docs/examples/getinmemory.c
for a bit complicate
Azat Manukyan wrote:
in both cases I haven't configured libcurl to any resolver.I supposed that
didn't need to configure any
resolver.firewall is turned of on windows.
DNS resolver is working on windows environment because i can ping to
given host, and system log viewer does not give any issues
CyaSSL was renamed to WolfSSL some time ago. Libcurl and
vtls/cyassl.c seems to suffer from this. I got the message:
* CyaSSL <3.3.0 cannot be configured to use TLS 1.0-1.2, TLS 1.0
is used exclusively
because of this:
#if (LIBCYASSL_VERSION_HEX >= 0x03003000) /* 3.3.0 */
My CyaSSL/versio
Ray Satiro via curl-library wrote:
There's supposed to be backwards compatibility with CyaSSL.
Seems I had some problem with the generated '';
it didn't include ''.
Maybe libcurl can test on 'USE_WOLFSSL' too in the event the
include-path disappears in the future?
I didn't have that proble
I need some help from an VisualStudio expert here. Steve?
I've just installed the new, free "Microsoft Visual Studio Community 2013"
and tried it by loading 'projects\Windows\VC12\curl-all.sln' and
'projects\Windows\VC12\lib\libcurl.sln' in it. I.e. "devenv libcurl.sln".
VS 2013 is "Version 12.0
"Eugeny Melamud" wrote:
I'm developing a dll that uses libcurl. I builded lib with vc6curlsrc.dsw
project (I found it into srcfolder of curl distributive).
Aheam, I think vc6curlsrc.dsw is for building the curl executable. You probably
need to build with vc6libcurl.dsw. But where is .\lib\v
"eli" wrote:
There are two PCs i work on, both have the same versions of Windows
and the same versions of Visual Studio. The first is desktop PC and
the second is laptop.
It would be nice to know which Windows that is?
Loaded '..\Debug\curllib.dll', Binary was not built with debug informa
"JonathonS" wrote:
stack below of the crash.
msvcr100d.dll!_free() + 0x10 bytes
xx.dll!destroy_async_data(Curl_async * async=0x003f2aa0) Line 326 + 0xe bytes C
What excactly is it trying to free? Who allocated the data? You must
make sure that the allocator and the code that does the free
"Alex Loukissas" wrote:
I have an app that links statically against libcurl, which itself (libcurl)
is built with openssl support. My app is cross-compiled on Linux with
mingw-64 and run on Win7-64. The problem I'm facing is the following:
Unless I use the CURLOPT_CAINFO option and hard-code a
"Dan Fandrich" wrote:
curl very much expects a BSD-style socket library. The best bet is to
write a shim library that calls the LWIP socket functions using the
standard names so that configure can find them.
lwIP already has this shim built-in.
Ref. src/include/lwip/sockets.h:
#if LWIP_COMP
"Dan Fandrich" wrote:
Do the shim include files mirror the POSIX socket include files? If so,
then adding something like CPPFLAGS=-Isrc/include/lwip/ to the configure
like ought to make configure & curl pick them up. If not, it's trickier.
I'm not sure about non-Windows; only that setup.h has
"Guenter" wrote:
If its not possible to check if initialisation is required or not then
its probably worth to talk to the lwip team and suggest an enhancement
to lwip_init() so that it does simply nothing if the stack is already
initialized.
I can only speak for Windows. We can probably ass
"Avi Manor" wrote:
Please don't post in html. It's messy to format a sensible reply in html.
While testing this example I have noticed that every call to my_fwrite comes
with size = 1.
This is the reason why the error is unnoticeable. However, it is not guaranteed to
get every call with size
"Dima Tisnek" wrote:
Granted this is hardly an outright bug in pycurl, however I would
rather like to track it down.
Agreed, I think the bug must be in libfaketime. Ask them.
stack head:
#0 0x in ?? ()
#1 0x77bd9a3d in clock_gettime ()
from /dima/libfaketime/src/
"Marc Hörsken" wrote:
this weekend I took the time to create a new SSL/TLS module für libcurl. It
is now possible to use the Windows SSPI Schannel API for SSL and TLS
connections.
I looked at briefly. I even built with your code easily w/o knowing anything
about SSPI. No problems building it.
"Marc Hörsken" wrote:
Yes, that is basically the whole purpose of this. Schannel is a
replacement for other SSL/TLS implementations, like OpenSSL.
I am currently building it using the previously mentioned Makefile.vc in
winbuild/ and can successfully do HTTPS without OpenSSL.
Can you please t
"Marc Hörsken" wrote:
I thought it was working for you, sorry for the misunderstanding.
I though so too, but was mistaken.
So, how exactly are you trying to build it? If you still want to do it.
I got the 'mback2k-curl-curl-7_25_0-67-g306621b.zip' from git here:
https://github.com/mback2
"Marc Hoersken" wrote:
Therefore I consider those things something which I or others can add
later on, because until these options are implemented in libcurl,
Windows will choose the best available cipher from the registry and
use certificates from the Windows Certification Store.
Speaking of
"Marc Hoersken" wrote:
functionality of SSL/TLS encryption behind the API. This is the whole
purpose of the general SSPI API and provider approach. It might be
hard to get some information out of it.
I think I see. I've played a little at enumerating and getting the
version of the security pa
"east2006 east2006" wrote:
1>libcurl.lib(content_encoding.obj) : error LNK2019: unresolved external
symbol _zlibVersion@0 referenced in function _Curl_unencode_gzip_write
1>.\Standalone-D\MelodoContent.exe : fatal error LNK1120: 5 unresolved
externals
I'm staticly compiling libcurl with zlib
"east2006 east2006" wrote:
Thank you, that solved it
When compiling libcurl with zlib (MSVC), I get this error:
libcurl.res : fatal error LNK1241: resource file zlib1d.lib(zlib1.res)
already specified
Well, zlib1.res must have been included twice. Why, I don't know.
Where and how was zlib1d
When running "curl --trace-ascii -", I see lots of such lines:
== Info: Re-using existing connection! (#0) with host (nil)
== Info: Connected to (nil) (194.103.154.240) port 443 (#0)
I mean, the "(nil)" looks ugly. So to give a nicer trace, when 'host.name' is
known, why not use that instead w
"Daniel Stenberg" wrote.
I mean, the "(nil)" looks ugly. So to give a nicer trace, when 'host.name'
is known, why not use that instead when 'host.dispname' is NULL?
I don't get to see this. How do you get it like this? What name resolver is
this libcurl built to use?
The standard AFAICS. I
"Marc Hoersken" wrote:
I like this idea. That way Curl_schannel_version would still return
something useful while avoiding the dependency on version.lib.
Do you also mean that '-DWIN_USE_SSPI' also needs to
drop the version.lib requirement? I mean, 'WIN_USE_SSPI'
without 'USE_SCHANNEL'.
I'm
I've learned that using realloc() should be kept to a minimum;
they could cause copying memory from old to new buffer, heap
fragmentation etc. So, I noticed that the number of realloc() calls in
libcurl has risen sharply with USE_SCHANNEL. A small test using:
curl -v https://www.google.com
res
From gcc/MingW:
In file included from ../../CyaSSL-2.2.0/cyassl/openssl/ssl.h:31:0,
from urldata.h:115,
from ldap.c:68:
../../CyaSSL-2.2.0/cyassl/ssl.h:422:5: error: expected identifier before '('
token
Reason being that OCSP_REQUEST+OCSP_RESPONSE are enum value
"Daniel Stenberg" wrote:
Okay, but can you give me an exact command line you use to get it? I've not
yet managed to repeat this problem and I would like to, so that I can perhaps
make a test case for it.
Sorry for the delay. I forgot about this. But this example shows the
"(nil)" part in th
"Igor Korot" wrote:
Here is my code:
[code]
struct curl_slist *post = NULL;
char *data;
sprintf( data, "---%x",
static_cast( time( NULL ) ) );
post = curl_slist_append( post, "Content-Type: multipart/form-data" );
post = curl_slist_append( post, "Expect: 1
"Guenter" wrote:
Another option we could do in our GIT would be to at least add *.c and
*.h to .gitattributes to so that they are also always forced to be
checked out in LF format; AFAIK all compilers can deal with this.
Haven't followed the thread so closely. The core problem is with the
GN
"Guenter" wrote:
Hello Gunter
What do you mean with "problems with '\r\n'" ?
Errors from 'sh' like:
line 12: $'\r': command not found
Did you actually run an autobuild from GIT with MSYS?
No. I'm not keen on using Msys more than absolutely neccesary.
Currently I dont believe that its
"Jan Ehrhardt" wrote:
I commented out the four lines starting with #ifdef WANT_IDN_PROTOTYPES
in idn_win32.src and added the line #include at the same
place. Result: the unresolved symbols are back again.
That's because WINVER isn't set high enough. Look closely in .
IdnToAscii etc. are ins
"Jan Ehrhardt" wrote:
The first error is the double declaration of 'connecting_state' in lines
273 and 317 of urldata.h. The next ones have to do with X509_NAME.
../../win32build/include/openssl\x509v3.h(192) : error C2059: syntax
error : '('
line 192 of x509v3.h (OpelSSL 1.0.1c) is:
X509_NAM
"Chris Ch" wrote:
I am trying to compile a simple program which uses libcurl with Mingw using
Msys. Here is my command and the output given:
Chris@Chris-HP ~
$ gcc -L/usr/local/lib/libcurl.a -o live live.c -DCURL_STATICLIB
-I/usr/local/include -lcurl
c:/mingw/bin/../lib/gcc/mingw32/4.7.0/../..
"Chris Ch" wrote:
Chris@Chris-HP ~
$ gcc -o live live.c -DCURL_STATICLIB -I/usr/local/include
/usr/local/lib/libcu
From your prompt, I thought you were not on Win32. How come
you have "/usr/local/lib" on MingW? Sure you don't use MSys?
In any case use:
gcc -o live live.c -DCURL_STATICLIB
"Jesse Nicholson" wrote:
Anyway so I downloaded latest release c-ares, zlib and curl... compiled
c-ares successfully (although I can only get it to spit out a static lib),
That's the problem.
zlib compiled without issue, then on to curl. Curl will compile the static
lib without issue, but a
"GitHub" i.e. Yang Tse wrote:
93 *.c source files renamed to use our standard naming scheme.
..
A lib/curl_amigaos.c
A lib/curl_asyn_ares.c
A lib/curl_asyn_thread.c
A lib/curl_axtls.c
A lib/curl_base64.c
A lib/curl_bundles.c
Okay, but now we can say goodbye to 8+3 unique n
"Yang Tse" wrote:
2) When debugging libcurl or apps that use it with debuggers that are
capable of showing the name of the source file it is much easier to
know if one is stepping in libcurl's code or elsewhere.
I think that's a good argument for renaming.
From your message http://curl.hax
"Steve Holme" wrote:
I'm still more in favour of going back to the old names and reverting the
change.
Me too.
--gv
---
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.ht
Yang, I think you forgot about patching tests/libtest.
Some files under tests\libtest, includes "setup.h". (e.g. in chkhostname.c).
Shouldn't that be '#include "curl_setup.h"'?
My bad. Saw on an old version in git.
--gv
---
List
Yang, I think you forgot about patching tests/libtest.
Some files under tests\libtest, includes "setup.h". (e.g. in chkhostname.c).
Shouldn't that be '#include "curl_setup.h"'?
--gv
---
List admin: http://cool.haxx.se/list/listinf
gcc on DOS hasn't really supported COFF-debug (-gcoff) on djgpp
for a long time. Eli Zaretskii wrote in:
http://newsgroups.derkeiler.com/Archive/Comp/comp.os.msdos.djgpp/2012-01/msg00070.html
"Sounds like the COFF debug info generation has bit-rotted in GCC.
Nothing new here, no other platform
lib/Makefile.m32 has this:
ifdef ARES
INCLUDES += -I"$(LIBCARES_PATH)"
CFLAGS += -DUSE_ARES
But lib/config-win32.h has this:
/* Define to enable c-ares asynchronous DNS lookups. */
/* #define USE_ARES 1 */
/* Define to enable threaded asynchronous DNS lookups. */
#define USE_THREADS
"Yang Tse" wrote:
config-platform.h in this case (config-win32.h) should be defining
USE_ARES and verifying that USE_THREADS_WIN32 is not defined when
"WITH_ARES" or "ENABLE_ARES" is defined.
It's been a long time since I was involved in the
asyn*.c / resolver stuff. Many other have contribut
I'm not sure it matters, but the comment in asyn-ares.c is
wrong:
/*
...
* Returns: CURLE_OK always!
*/
int Curl_resolver_getsock(struct connectdata *conn,
curl_socket_t *socks,
int numsocks)
{
..
int max = ares_getsock((ares_channel)conn->data-
"Daniel Stenberg" wrote:
It's funny that we haven't noticed bigger problems with this from users. It
might be that it is a fairly unusual limit to actual hit in real life.
Have you tried to just bump it? Anyone else?
No I haven't. Just caught this while reading and figuring out
the c-ares
"LRN" wrote:
compiled object files that go into libcurl. So the header tells
it to link to dllimport mprintf functions, while the object files
provide only normal mprintf functions for internal use.
Right, unless you put a -DCURL_STATICLIB in your CFLAGS.
And link with a static libcurl.a Thus
"Daniel Stenberg" wrote:
1 - you don't follow our code style, run lib/checksrc.pl and you'll find many
errors (tabs, spaces, line lengths)
And there's no need to typecast ret-vals from malloc(). libcurl
is written in C, not C++.
--gv
--
Just some ideas I have to reduce the number of files in
curl's root-dir:
1) Could ./Android.mk be moved to ./packages/Android like
we do for other platforms?
2) Not sure about ./MacOSX-Framework. I do not know OSX-building.
But a ./packages/OSX seems logical.
3) ./curl-style.el + ./sample.
"Pierre Joye" wrote:
However, I do not think we should allow non thread safe crt usage with
curl. Not a big matter as recent versions of the VC does not support
it anymore.
2003 (7.1) was the last version to support it:
What you mean by "recent versions"? My version is:
Microsoft (R) 32-bi
"Christian Hägele" wrote:
The reason for that is the Curl_sndbufset-function in connect.c. On windows the socket-sendbuffer is set to a value of
CURL_MAX_WRITE_SIZE + 32 (16416 bytes). There is a also a strange comment why this is done.
When the SO_SNDBUF is not explicitly set the socket-send
"Yang Tse" wrote:
The possibility of building by other means is no reason to drop this.
Sometimes the best way of debugging something is using the IDE, even
when it is possible to build using makefiles.
Also. MSVC6 IDE can generate makefiles from project files.
Not sure if later MSVC IDEs can
"Nick Zitzmann" wrote:
@@ -173,6 +175,12 @@ FOOTNOTES
*4 = requires FBopenssl
*5 = requires a krb4 library, such as the MIT one or similar.
*6 = requires c-ares
- *7 = requires OpenSSL or NSS, as GnuTLS only supports SSLv3 and TLSv1
+ *7 = requires OpenSSL, NSS, qssl, schannel, or Secur
This is AFAICS the only test program in this directory that doesn't
call curl_global_init(). This function is needed for Curl_gethostname()
to work on Windows at least.
Besides it does a case-sensitive string compare of 'argv[1]' and return
buffer from Curl_gethostname(). Aren't hostnames always
Running tests\libtest\libntlmconnect.exe reveals a 1 byte (!) leak in
./lib/curl_ntlm_msgs.c:
perl ..\memanalyze.pl c:memdebug.curl
Leak detected: memory still allocated: 1 bytes
At 9771e8, there's 1 bytes.
allocated by curl_ntlm_msgs.c:399
Snippet from curl_ntlm_msgs.c:
/* setup ntlm identit
1 - 100 of 223 matches
Mail list logo
