Re: [PATCH 4/6] Deprecate GSS-Negotiate related macros due to bad naming

2014-07-19 Thread Michael Osipov
Am 2014-07-19 00:17, schrieb Daniel Stenberg: On Thu, 17 Jul 2014, Michael Osipov wrote: case 'l': /* --negotiate */ if(toggle) { - if(curlinfo->features & CURL_VERSION_GSSNEGOTIATE) -config->authtype |= CURLAUTH_GSSNEGOTIATE; + if(curlinfo->features

Re: [PATCH 4/6] Deprecate GSS-Negotiate related macros due to bad naming

2014-07-18 Thread Daniel Stenberg
On Thu, 17 Jul 2014, Michael Osipov wrote: case 'l': /* --negotiate */ if(toggle) { - if(curlinfo->features & CURL_VERSION_GSSNEGOTIATE) -config->authtype |= CURLAUTH_GSSNEGOTIATE; + if(curlinfo->features & CURL_VERSION_GSSAPI || + curlinfo

Re: RE: [PATCH 4/6] Deprecate GSS-Negotiate related macros due to bad naming

2014-07-17 Thread Michael Osipov
> On Fri 18 Jul 2014, Michael Osipov wrote: > > > Deprecate GSS-Negotiate related macros due to bad naming > > Just a quick reminder, over something that is fairly trivial, but could we > please use our standard format for commit comments? > > I see some of the recent commits didn't follow this

RE: [PATCH 4/6] Deprecate GSS-Negotiate related macros due to bad naming

2014-07-17 Thread Steve Holme
On Fri 18 Jul 2014, Michael Osipov wrote: > Deprecate GSS-Negotiate related macros due to bad naming Just a quick reminder, over something that is fairly trivial, but could we please use our standard format for commit comments? I see some of the recent commits didn't follow this and I wouldn't