RE: URL parsing

2013-04-19 Thread Steve Holme
On Fri, 19 Apr 2013, Tor Arntsen wrote: > > Would someone be so kind to take a look at parse_login_details() in > > url.c (specifically the malloc at line 4510) please to see what I have > > done wrong? > > I just did a quick check, no fix, but there is a problem in url.c, function > parse_login_

Re: URL parsing

2013-04-19 Thread Tor Arntsen
On 19 April 2013 10:48, Steve Holme wrote: > Hi all, > > On Sun, 14 Apr 2013, Steve Holme wrote: > >> I've got a little stuck, as I'm not too sure which the best approach here >> is, so wondered if you could provide a little guidance please? > > I figured out a solution and am half way through pus

RE: URL parsing

2013-04-19 Thread Steve Holme
Hi all, On Sun, 14 Apr 2013, Steve Holme wrote: > I've got a little stuck, as I'm not too sure which the best approach here > is, so wondered if you could provide a little guidance please? I figured out a solution and am half way through pushing my changes to master. Unfortunately, I have broke

RE: URL parsing

2013-04-14 Thread Steve Holme
Hi Daniel, On Sun, 14 Apr 2013, Steve Holme wrote: > > At times authors of applications want to provide user + password > > separate from the URL for various reasons. I figure the same will go > > for "options" associated with it as well... > > Sure - I will work on adding this as well. I've g

RE: URL parsing

2013-04-14 Thread Steve Holme
On Sat, 13 Apr 2013, Daniel Stenberg wrote: > > 1) This only adds support to the URL and not to the username / > > password that may be specified with the --user or -u command line > > arguments. It wouldn't take much more work to add support for this > > as well but I wanted to gather others' o

Re: URL parsing

2013-04-13 Thread David Strauss
On Sat, Apr 13, 2013 at 2:18 PM, Daniel Stenberg wrote: > I've not seen any such that aren't either gigantic in size or complexity. > Also, it seems like a rather massive change to switch to at this point. I guessed the reasons would be along those lines. :-) > Is it really easier to prove corre

Re: URL parsing

2013-04-13 Thread Daniel Stenberg
On Sat, 13 Apr 2013, David Strauss wrote: Are you opposed to code generated using a lexer/parser or a library like uriparser? I've not seen any such that aren't either gigantic in size or complexity. Also, it seems like a rather massive change to switch to at this point. It's hard to prove

Re: URL parsing

2013-04-13 Thread Daniel Stenberg
On Sat, 13 Apr 2013, Steve Holme wrote: 1) This only adds support to the URL and not to the username / password that may be specified with the --user or -u command line arguments. It wouldn't take much more work to add support for this as well but I wanted to gather others' opinions on this be

Re: URL parsing

2013-04-13 Thread David Strauss
On Sat, Apr 13, 2013 at 3:12 AM, Steve Holme wrote: > Whilst I have 20 odd years' experience as a C/C++ developer would someone > be so kind to check the four uses of sscanf() in url.c between lines 4381 > and 4402 to see if this is the best / most optimal way of extracting the > user, password an