On Mon, 10 Feb 2014, Maciej Puzio wrote:
So I'd say go with the third one (as below), if it is not too difficult to
implement.
Not too dificult, just proving once again why this feature isn't merged yet.
It just isn't ready and there's not a lot of people stepping up to help it get
there. Th
On Fri, Feb 7, 2014 at 1:44 AM, Daniel Stenberg wrote:
> [...]
> It is really awkward.
> Many applications use HTTP and HTTPS interchangably in the same application
> and I think it would be unfortunate to push these applications into having
> to set different options depending on which specific p
On Thu, 6 Feb 2014, Maciej Puzio wrote:
In my opinion, if someone manually sets proxy headers separate from headers
intended for the end-server, then this use case is advanced enough that we
can assume that the user had read the manual.
Ok, but what should the manual say about this case?
"
On Tue, Feb 4, 2014 at 5:12 PM, Daniel Stenberg wrote:
> Assume your app wants to add a Proxy-authorization: header. In which list do
> you put it? CURLOPT_PROXYHEADER for CONNECT (https) and CURLOPT_HTTPHEADER
> for http? It doesn't make sense to me.
> If we instead say CURLOPT_PROXYHEADER is ri
Daniel, thanks for the info. I am very glad that you plan to merge
these changes soon, as the biggest problem for me is to maintain a
modified "fork" of curl that I am currently forced to do. I'm looking
forward to testing the final version of this modification.
Maciej
On Fri, 31 Jan 2014, Maciej Puzio wrote:
Now I'm back on this train and yeah, the question isn't exactly easy. I'll
try to discuss this matter with some guys over the FOSDEM weekend to see if
I can get a more firm opinion.
For me personally, any way of fixing this issue would be a step forwar
On Fri, Jan 31, 2014 at 1:59 AM, Daniel Stenberg wrote:
> Now I'm back on this train and yeah, the question isn't exactly easy. I'll
> try to discuss this matter with some guys over the FOSDEM weekend to see if
> I can get a more firm opinion.
For me personally, any way of fixing this issue woul
On Fri, 24 Jan 2014, Maciej Puzio wrote:
1. Break backward compatibility.
2. Keep behavior that is not only unsafe, but also default and accepted
silently.
Now I'm back on this train and yeah, the question isn't exactly easy. I'll try
to discuss this matter with some guys over the FOSDEM we
Daniel and Dan, thanks for your comments.
Dan:
> IMHO, it would be a pretty major break to change the default behaviour. There
> are undoubtedly applications out there that fall into all three categories,
> and
> a change would break at least one category.
I agree. Thinking aloud, perhaps the be
On Thu, Jan 23, 2014 at 11:56:43PM +0100, Daniel Stenberg wrote:
> I think this is a tricky question and I'd love to get more feedback
> on this. The existing (before this patch) features affect headers to
> both the server and the proxy, and since it does that we can't really
> know which of the f
On Thu, 23 Jan 2014, Maciej Puzio wrote:
1. The patch includes modifications to curl library, but not to the command
line curl tool. I attach the patch that adds --proxy-header command line
option.
Thanks!
3. When --proxy-header option is absent, but --header is present, curl sends
headers
Vijay Panghal's patch implements a feature that I need for my project,
so I am very glad that work is being done on it. I tested the patch
and have a few comments. Just in case this email won't be assigned to
a proper thread, I am replying to message
http://curl.haxx.se/mail/lib-2014-01/0079.html .
On Tue, 14 May 2013, Vijay Panghal wrote:
Hi again Vijay,
I have added libcurl unit test for the patch. During testing, I found that
enabling CURLOPT_PROXYHEADER breaks the searching of http header. To fix
this I have made these changes into the patch
1) Added function Curl_checkProxyheaders
accurate and that the code covers most cases. Feel like helping out?
--
/ daniel.haxx.seFrom 0aeb5e337ccd6c3f56b53cdfa09fbd4204c122c6 Mon Sep 17 00:00:00 2001
From: Daniel Stenberg
Date: Sun, 9 Sep 2012 13:21:06 +0200
Subject: [PATCH] CURLOPT_PROXYHEADER: send/replace proxy headers only
This
Link to the patch conversation.
http://www.mail-archive.com/curl-library@cool.haxx.se/msg14644.html
Vijay
On Sun, May 5, 2013 at 5:53 PM, Vijay Panghal wrote:
> Hi,
>
> Is the patch for proxyheader has been merged in master? if not, is there
> any plan to merge this into master?
>
> Vijay
>
-
Hi,
Is the patch for proxyheader has been merged in master? if not, is there
any plan to merge this into master?
Vijay
---
List admin: http://cool.haxx.se/list/listinfo/curl-library
Etiquette: http://curl.haxx.se/mail/etiquette.htm
ch.
--
/ daniel.haxx.seFrom e09426f0504701737b77fec74a1210f3273c9d24 Mon Sep 17 00:00:00 2001
From: Daniel Stenberg
Date: Sun, 9 Sep 2012 13:21:06 +0200
Subject: [PATCH] CURLOPT_PROXYHEADER: send/replace proxy headers only
This allows applications to set headers for CONNECT requests that will
not be used in the
Daniel Stenberg wrote:
> On Sat, 8 Sep 2012, Daniel Stenberg wrote:
> Here's my first take at a CURLOPT_PROXYHEADER option that should allow an
> application to select to affect only host, proxy or both request headers.
>
> I've not written any test cases yet for this nor pushed this commit,
hought I'd first offer everyone a chance to comment on the concept/idea.
--
/ daniel.haxx.seFrom b230ec0c6f8c555196c947e526f8f4a7e61bfe1a Mon Sep 17 00:00:00 2001
From: Daniel Stenberg
Date: Sun, 9 Sep 2012 13:21:06 +0200
Subject: [PATCH] CURLOPT_PROXYHEADER: send/replace proxy headers on
19 matches
Mail list logo
