Re: libcurl ignore timeout on sftp disconnect

On Tue, 26 May 2020, Estanislau Augé-Pujadas wrote: Absolutely, here it is https://github.com/curl/curl/pull/5465 Happy to help if help is required. Thanks a lot, I'll take a look asap and possibly do follow-up comments in that PR. -- / daniel.haxx.se | Commercial curl support up to 24x

Re: libcurl ignore timeout on sftp disconnect

Absolutely, here it is https://github.com/curl/curl/pull/5465 . Happy to help if help is required. > On May 26, 2020, at 3:15 PM, Daniel Stenberg wrote: > > On Tue, 26 May 2020, Estanislau Augé-Pujadas wrote: > >> Yes, I can confirm that when reverting

Re: libcurl ignore timeout on sftp disconnect

On Tue, 26 May 2020, Estanislau Augé-Pujadas wrote: Yes, I can confirm that when reverting that commit, the timeout is triggered by curl. As far as I can tell, with valgrind I couldn't see any memory leaks from libssh2 in this case, but I just ran it a couple of times so I wouldn't fully trust

Re: libcurl ignore timeout on sftp disconnect

Yes, I can confirm that when reverting that commit, the timeout is triggered by curl. As far as I can tell, with valgrind I couldn't see any memory leaks from libssh2 in this case, but I just ran it a couple of times so I wouldn't fully trust my small test to conclude that the memory leak is not th

Re: Memory leak with curl_multi_socket_action

On Tue, May 26, 2020 at 4:26 PM Daniel Stenberg wrote: > On Tue, 26 May 2020, James Read wrote: > > > So, I guess that's problem solved. Thanks. > > Lovely! > > With that issue nailed and perhaps with some newfound knowledge in your > head, > is there something we should think about to clarify or

Re: Memory leak with curl_multi_socket_action

On Tue, 26 May 2020, James Read wrote: So, I guess that's problem solved. Thanks. Lovely! With that issue nailed and perhaps with some newfound knowledge in your head, is there something we should think about to clarify or update in the documentation that would make this behavior clearer or

Re: Memory leak with curl_multi_socket_action

On Tue, May 26, 2020 at 3:43 PM Daniel Stenberg wrote: > On Tue, 26 May 2020, James Read via curl-library wrote: > > > When parallel connections reaches 0 g->still_running is still reporting > a > > number of easy handles in progress. How can this be? Surely, the answer > to > > this question is

Re: Memory leak with curl_multi_socket_action

On Tue, 26 May 2020, James Read via curl-library wrote: When parallel connections reaches 0 g->still_running is still reporting a number of easy handles in progress. How can this be? Surely, the answer to this question is the answer to the memory leaks? Your code makes funny assumptions about

Re: Memory leak with curl_multi_socket_action

On Tue, May 26, 2020 at 2:31 PM James Read wrote: > > > On Tue, May 26, 2020 at 12:47 PM James Read > wrote: > >> >> >> On Tue, May 26, 2020 at 7:30 AM Patrick Monnerat via curl-library < >> curl-library@cool.haxx.se> wrote: >> >>> On 5/26/20 1:15 AM, James Read via curl-library wrote: >>> > >>>

Re: Memory leak with curl_multi_socket_action

On Tue, May 26, 2020 at 12:47 PM James Read wrote: > > > On Tue, May 26, 2020 at 7:30 AM Patrick Monnerat via curl-library < > curl-library@cool.haxx.se> wrote: > >> On 5/26/20 1:15 AM, James Read via curl-library wrote: >> > >> > git clone https://github.com/JamesRead5737/libcurlmemoryleak.git >

Re: Memory leak with curl_multi_socket_action

On Tue, May 26, 2020 at 7:30 AM Patrick Monnerat via curl-library < curl-library@cool.haxx.se> wrote: > On 5/26/20 1:15 AM, James Read via curl-library wrote: > > > > git clone https://github.com/JamesRead5737/libcurlmemoryleak.git > > > > No need to make. Just compile with gcc crawler.c -g -lssl