[PATCH 4/4] cut: Optionally treat multiple consecutive delimiters as one

2023-08-01 Thread Dragan Simic
Add new command-line option and the required logic that allow multiple consecutive delimiters to be treated as a single delimiter. Of course, this option is valid only with the cut's field mode. This new feature should make cut much more usable in various real-world applications, some of which ar

[PATCH 1/4] doc: Minor reformatting to match width

2023-08-01 Thread Dragan Simic
Reformat the opening paragraphs slightly, simply to match the width of the entire text and make it more uniform. Signed-off-by: Dragan Simic --- HACKING | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/HACKING b/HACKING index 11f3967ec..0febaaf43 100644 --- a

[PATCH 2/4] cut: Promptly diagnose write errors, continued

2023-08-01 Thread Dragan Simic
Complete the error-handling improvements started in commit e0a4a60af5, by adding a couple of remaining checks for putchar(). White there, sprinkle a few rather useful comments, and perform a few small code cleanups, to make the code and the comments more uniform and more conformant to the official

[PATCH 3/4] cut: Minor comment cleanups

2023-08-01 Thread Dragan Simic
Adjust a few comments slightly, simply to have their trailing whitespace the same as in the majority of the comments. Signed-off-by: Dragan Simic --- src/cut.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/src/cut.c b/src/cut.c index 4e2bbd82b..b4

[PATCH] build: avoid use of C11 specific %t format size spec

2023-08-01 Thread Pádraig Brady
* cfg.mk (sc_prohibit-c11-printf-format): Renamed and updated from sc_prohibit-c99-printf-format. * src/dd.c: Adjust %td -> %"PRIdMAX". * src/dircolors.c: Likewise. * src/du.c: Likewise. * src/join.c: Likewise. * src/od.c: Likewise. * src/pathchk.c: Likewise. --- cfg.mk | 8 src

Re: [PATCH] build: avoid use of C11 specific %t format size spec

2023-08-01 Thread Pádraig Brady
On 01/08/2023 14:07, Pádraig Brady wrote: * cfg.mk (sc_prohibit-c11-printf-format): Renamed and updated from sc_prohibit-c99-printf-format. * src/dd.c: Adjust %td -> %"PRIdMAX". * src/dircolors.c: Likewise. * src/du.c: Likewise. * src/join.c: Likewise. * src/od.c: Likewise. * src/pathchk.c: Likew

Re: [PATCH 3/4] cut: Minor comment cleanups

2023-08-01 Thread Pádraig Brady
First three patches applied. Notes: We don't capitalize in first line of commit message. We use maint: prefix for non logic changes or trivial doc changes. We don't use Signed-off-by: tags as they're implicit in commit. We use a standatd "* file (where): What" format in commit message. thanks!

Re: [PATCH 4/4] cut: Optionally treat multiple consecutive delimiters as one

2023-08-01 Thread Pádraig Brady
On 01/08/2023 10:07, Dragan Simic wrote: Add new command-line option and the required logic that allow multiple consecutive delimiters to be treated as a single delimiter. Of course, this option is valid only with the cut's field mode. This new feature should make cut much more usable in variou

Re: [PATCH] build: avoid use of C11 specific %t format size spec

2023-08-01 Thread Andreas Schwab
%t is C99 -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different."

Re: [PATCH 4/4] cut: Optionally treat multiple consecutive delimiters as one

2023-08-01 Thread Rob Landley
On 8/1/23 04:07, Dragan Simic wrote: > Add new command-line option and the required logic that allow multiple > consecutive delimiters to be treated as a single delimiter. Of course, > this option is valid only with the cut's field mode. > > This new feature should make cut much more usable in va

Re: [PATCH 3/4] cut: Minor comment cleanups

2023-08-01 Thread Dragan Simic
On 2023-08-01 16:39, Pádraig Brady wrote: First three patches applied. Thanks! Notes: We don't capitalize in first line of commit message. We use maint: prefix for non logic changes or trivial doc changes. We don't use Signed-off-by: tags as they're implicit in commit. We use a standatd "* f

Re: [PATCH 4/4] cut: Optionally treat multiple consecutive delimiters as one

2023-08-01 Thread Dragan Simic
On 2023-08-01 16:42, Pádraig Brady wrote: On 01/08/2023 10:07, Dragan Simic wrote: Add new command-line option and the required logic that allow multiple consecutive delimiters to be treated as a single delimiter. Of course, this option is valid only with the cut's field mode. This new featu

Re: [PATCH 4/4] cut: Optionally treat multiple consecutive delimiters as one

2023-08-01 Thread Dragan Simic
On 2023-08-01 18:27, Rob Landley wrote: On 8/1/23 04:07, Dragan Simic wrote: Add new command-line option and the required logic that allow multiple consecutive delimiters to be treated as a single delimiter. Of course, this option is valid only with the cut's field mode. This new feature sho

Re: [PATCH] build: avoid use of C11 specific %t format size spec

2023-08-01 Thread Paul Eggert
On 2023-08-01 06:28, Pádraig Brady wrote: perhaps we can now use %j, %t, and %z now? I hope so, particularly as we haven't seen any issues with Coreutils 9.1 or later. I haven't run into problems using these printf formats for a while. Gnulib doc is ambiguous, but suggests it could be an is