Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-13 Thread Bruno Haible
Pádraig Brady wrote: > The attached fixes this issue in my testing. [tail-f-pipe-solaris.patch] I confirm, on Solaris 11.4: It fixes the test failure and does not cause test regressions. Bruno

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-13 Thread Pádraig Brady
On 11/04/2022 02:44, Bruno Haible wrote: Pádraig Brady wrote: FAIL: tests/tail-2/pipe-f = The following might help here: diff --git a/src/tail.c b/src/tail.c index f1b741783..a28fa61da 100644 --- a/src/tail.c +++ b/src/tail.c @@ -356,7 +356,7 @@ check_output_alive (voi

Re: coreutils-9.0.193-54bec on Solaris 11.4: stty

2022-04-13 Thread Bruno Haible
Pádraig Brady wrote: > > > > FAIL: tests/misc/stty-row-col > > = > > Any of the commands like `stty rows 40 columns 80` are being silently ignored. 'stty size' retrieves the info from an ioctl(1,TIOCGWINSZ) call and an ioctl(0,TIOCGWINSZ) call. Even the value of envir

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-13 Thread Pádraig Brady
On 13/04/2022 08:01, Paul Eggert wrote: On 4/12/22 17:51, Paul Eggert wrote: Your patch doesn't feel quite right to me but I haven't figured out why yet; I'll try to spring time to look at it in more detail. I did that installed the attached. Most of these are merely refactoring or minor tweak

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-13 Thread Paul Eggert
On 4/12/22 17:51, Paul Eggert wrote: Your patch doesn't feel quite right to me but I haven't figured out why yet; I'll try to spring time to look at it in more detail. I did that installed the attached. Most of these are merely refactoring or minor tweaking; the 3rd patch is the real change as

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-12 Thread Paul Eggert
On 4/12/22 07:05, Pádraig Brady wrote: This does seem like a bug in that O_DIRECTORY should take precedence, especially considering O_SEARCH is documented in the Solaris open man page to return ENOTDIR for non directories. I don't think it's a bug, as longstanding POSIX tradition is that if th

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-12 Thread Pádraig Brady
On 12/04/2022 23:29, Bruno Haible wrote: Pádraig Brady wrote: FAIL: tests/install/basic-1 === FAIL: tests/mv/diag === The attached addresses these two test failures in my testing. Confirmed: It fixes these two test failures also on Solaris 11.4. Thank

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-12 Thread Bruno Haible
Pádraig Brady wrote: > FAIL: tests/install/basic-1 > === > FAIL: tests/mv/diag > === > The attached addresses these two test failures in my testing. Confirmed: It fixes these two test failures also on Solaris 11.4. Bruno

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-12 Thread Pádraig Brady
On 11/04/2022 14:55, Pádraig Brady wrote: On 11/04/2022 02:44, Bruno Haible wrote: Pádraig Brady wrote: FAIL: tests/install/basic-1 === FAIL: tests/mv/diag === These two are the same issue I think ... diff --git a/src/system.h b/src/system.h index c2

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-11 Thread Pádraig Brady
On 11/04/2022 02:44, Bruno Haible wrote: Pádraig Brady wrote: FAIL: tests/install/basic-1 === FAIL: tests/mv/diag === These two are the same issue I think ... diff --git a/src/system.h b/src/system.h index c24cb4dc3..d2c473a59 100644 --- a/src/system.

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-10 Thread Bruno Haible
Pádraig Brady wrote: > > FAIL: tests/misc/stty-row-col > > = > > Any of the commands like `stty rows 40 columns 80` are being silently ignored. > FWIW on the Solaris 10 system I've access to, this test passes. > I'd need access to investigate. I'm sorry, the license te

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-10 Thread Pádraig Brady
On 10/04/2022 15:37, Bruno Haible wrote: On Solaris 11.4 (x86_64, in 64-bit mode), there are 4 test failures: FAIL: tests/misc/stty-row-col = Any of the commands like `stty rows 40 columns 80` are being silently ignored. FWIW on the Solaris 10 system I've access to

Re: coreutils-9.0.193-54bec on Solaris 11.4

2022-04-10 Thread Bruno Haible
On Solaris 11.4 (x86_64, in 64-bit mode), there are 4 test failures: FAIL: tests/misc/stty-row-col = ++ initial_cwd_=/export/home/bruno/coreutils-9.0.193-54bec/build-64 +++ testdir_prefix_ +++ printf gt ++ pfx_=gt +++ mktempd_ /export/home/bruno/coreutils-9.0.193-54be