Re: [PATCH] maint: improve ERE in sc_tests_list_consistency

2024-06-01 Thread Bernhard Voelker
On 6/1/24 16:27, Pádraig Brady wrote: Looks good. You could also remove the redundant escaping, i.e. \$$ -> $$ to be consistent with the rest of this file. Thanks, pushed with that. Have a nice day, Berny

Re: [PATCH] maint: improve ERE in sc_tests_list_consistency

2024-06-01 Thread Pádraig Brady
On 01/06/2024 15:02, Bernhard Voelker wrote: The ERE used lacks the grouping of the extensions and therefore would also match files where the first two patterns are not at the end of the line: grep -E '\.sh|\.pl|\.xpl$' * cfg.mk (sc_tests_list_consistency): Add grouping (...) around the sub-p

[PATCH] maint: improve ERE in sc_tests_list_consistency

2024-06-01 Thread Bernhard Voelker
The ERE used lacks the grouping of the extensions and therefore would also match files where the first two patterns are not at the end of the line: grep -E '\.sh|\.pl|\.xpl$' * cfg.mk (sc_tests_list_consistency): Add grouping (...) around the sub-patterns. --- cfg.mk | 2 +- 1 file changed, 1 i